875: Enhanced error outputting for new Magento 2 data model generation

Author: bohdan-harniuk

resources/magento2/validation.properties

@@ -1,6 +1,7 @@
 validator.notEmpty=The {0} field must not be empty
 validator.box.notEmpty=The {0} field must contain a valid selection from the dropdown
 validator.package.validPath=Please specify a valid Magento 2 installation path
+validator.properties.notEmpty=The properties must not be empty
 validator.alphaNumericCharacters=The {0} field must contain letters and numbers only
 validator.alphaNumericAndUnderscoreCharacters={0} must contain letters, numbers and underscores only
 validator.alphaAndPeriodCharacters=The {0} field must contain alphabets and periods only

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewDataModelDialog.form

@@ -10,7 +10,7 @@
     </properties>
     <border type="none"/>
     <children>
-      <grid id="e3588" layout-manager="GridLayoutManager" row-count="3" column-count="2" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
+      <grid id="e3588" layout-manager="GridLayoutManager" row-count="4" column-count="2" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
         <margin top="0" left="0" bottom="0" right="0"/>
         <constraints>
           <grid row="0" column="0" row-span="1" col-span="1" vsize-policy="3" hsize-policy="3" anchor="0" fill="3" indent="0" use-parent-layout="false"/>
@@ -36,6 +36,14 @@
               <text value=""/>
             </properties>
           </component>
+          <component id="8fecc" class="javax.swing.JLabel" binding="modelNameErrorMessage">
+            <constraints>
+              <grid row="2" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
+            </constraints>
+            <properties>
+              <text value=""/>
+            </properties>
+          </component>
         </children>
       </grid>
       <grid id="ebe15" layout-manager="GridLayoutManager" row-count="3" column-count="1" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewDataModelDialog.java

@@ -40,6 +40,7 @@
 import javax.swing.JButton;
 import javax.swing.JCheckBox;
 import javax.swing.JComponent;
+import javax.swing.JLabel;
 import javax.swing.JOptionPane;
 import javax.swing.JPanel;
 import javax.swing.JTable;
@@ -77,6 +78,8 @@ public class NewDataModelDialog extends AbstractDialog {
     @FieldValidation(rule = RuleRegistry.PHP_CLASS, message = {PhpClassRule.MESSAGE, MODEL_NAME})
     private JTextField modelName;
 
+    private JLabel modelNameErrorMessage;//NOPMD
+
     /**
      * Constructor.
      */
@@ -162,6 +165,17 @@ protected boolean validateFormFields() {
             valid = true;
             final String errorTitle = commonBundle.message("common.error");
             final int column = 0;
+
+            if (propertyTable.getRowCount() == 0) {
+                valid = false;
+                JOptionPane.showMessageDialog(
+                        null,
+                        validatorBundle.message("validator.properties.notEmpty"),
+                        errorTitle,
+                        JOptionPane.ERROR_MESSAGE
+                );
+            }
+
             for (int row = 0; row < propertyTable.getRowCount(); row++) {
                 final String propertyName = ((String) propertyTable.getValueAt(row, column)).trim();
                 if (propertyName.isEmpty()) {