Skip to content

Commit df337f4

Browse files
Merge pull request #894 from Iamwade/842-incomplete-trailing-escape
842 incomplete trailing escape
2 parents 40192fb + 703fc13 commit df337f4

File tree

2 files changed

+32
-25
lines changed

2 files changed

+32
-25
lines changed

src/com/magento/idea/magento2plugin/actions/generation/generator/MessageQueueClassGenerator.java

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,13 @@
2121
import com.magento.idea.magento2plugin.magento.packages.File;
2222
import com.magento.idea.magento2plugin.util.GetFirstClassOfFile;
2323
import com.magento.idea.magento2plugin.util.GetPhpClassByFQN;
24+
import java.util.ArrayList;
25+
import java.util.List;
2426
import java.util.Properties;
2527
import javax.swing.JOptionPane;
2628

2729
public class MessageQueueClassGenerator extends FileGenerator {
30+
2831
private final MessageQueueClassData messageQueueClassDataName;
2932
private final Project project;
3033
private final DirectoryGenerator directoryGenerator;
@@ -33,6 +36,7 @@ public class MessageQueueClassGenerator extends FileGenerator {
3336
private final CommonBundle commonBundle;
3437
private final String moduleName;
3538
private final GetFirstClassOfFile getFirstClassOfFile;
39+
private final List<String> errors = new ArrayList<>();
3640

3741
/**
3842
* Message queue handler constructor.
@@ -68,40 +72,34 @@ public PsiFile generate(final String actionName) {
6872
);
6973

7074
if (handler != null) {
71-
final String errorMessage = this.validatorBundle.message(
75+
errors.add(validatorBundle.message(
7276
"validator.file.alreadyExists",
7377
"Handler Class"
74-
);
75-
JOptionPane.showMessageDialog(
76-
null,
77-
errorMessage,
78-
commonBundle.message("common.error"),
79-
JOptionPane.ERROR_MESSAGE
80-
);
81-
78+
));
8279
return;
8380
}
84-
8581
handler = createHandlerClass(actionName);
8682

8783
if (handler == null) {
88-
final String errorMessage = this.validatorBundle.message(
84+
errors.add(validatorBundle.message(
8985
"validator.file.cantBeCreated",
9086
"Handler Class"
91-
);
92-
JOptionPane.showMessageDialog(
93-
null,
94-
errorMessage,
95-
commonBundle.message("common.error"),
96-
JOptionPane.ERROR_MESSAGE
97-
);
98-
87+
));
9988
return;
10089
}
10190

10291
handlerFiles[0] = handler.getContainingFile();
10392
});
10493

94+
for (final String errorMessage : errors) {
95+
JOptionPane.showMessageDialog(
96+
null,
97+
errorMessage,
98+
commonBundle.message("common.error"),
99+
JOptionPane.ERROR_MESSAGE
100+
);
101+
}
102+
105103
return handlerFiles[0];
106104
}
107105

src/com/magento/idea/magento2plugin/project/diagnostic/github/GitHubNewIssueBodyBuilderUtil.java

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,22 @@ public static String buildNewBugReportBody(
5151
if (encode(stackTrace).length() <= maxAllowedStackTraceLength) {
5252
return buildTemplate(project, bugDescription, stackTrace);
5353
}
54+
boolean isFound = false;
55+
int step = 1;
56+
String encodedCutStackTrace = "";
57+
58+
while (!isFound) {
59+
final String cutStackTrace = stackTrace.substring(0, maxAllowedStackTraceLength - step);
60+
encodedCutStackTrace = encode(cutStackTrace);
61+
62+
if (encodedCutStackTrace.length() <= maxAllowedStackTraceLength) {
63+
isFound = true;
64+
} else {
65+
step += 10;
66+
}
67+
}
5468

55-
final String cutStackTrace = encode(stackTrace).substring(
56-
0,
57-
maxAllowedStackTraceLength - 1
58-
);
59-
60-
return buildTemplate(project, bugDescription, decode(cutStackTrace));
69+
return buildTemplate(project, bugDescription, decode(encodedCutStackTrace));
6170
}
6271

6372
/**

0 commit comments

Comments
 (0)