39854: Add support for typographical apostrophe and underscore in city validation and update test cases

Author: bhushan-cs

app/code/Magento/Customer/Model/Validator/City.php

@@ -23,13 +23,14 @@ class City extends AbstractValidator
      * \d: Digits (0-9).
      * \s: Whitespace characters (spaces, tabs, newlines, etc.).
      * -: Hyphen.
-     * ': Apostrophe mark.
+     * _: Underscore.
+     * ', ’: Apostrophes (straight and typographical).
      * .: Period/full stop.
      * ,: Comma.
      * &: Ampersand.
      * (): Parentheses.
      */
-    private const PATTERN_CITY = '/^[\p{L}\p{M}\d\s\-\'\.,&\(\)]{1,100}$/u';
+    private const PATTERN_CITY = '/^[\p{L}\p{M}\d\s\-_\'’\.,&\(\)]{1,100}$/u';
 
     /**
      * Validate city fields.
@@ -41,7 +42,7 @@ public function isValid($customer)
     {
         if (!$this->isValidCity($customer->getCity())) {
             parent::_addMessages([[
-                'city' => "Invalid City. Please use letters, numbers, spaces, and the following characters: - ' . , & ( )"
+                'city' => "Invalid City. Please use letters, numbers, spaces, and the following characters: - _ ' ’ . , & ( )"
             ]]);
         }
 

app/code/Magento/Customer/Test/Unit/Model/Validator/CityTest.php

@@ -79,6 +79,38 @@ public static function expectedPunctuationInNamesDataProvider(): array
             [
                 'city' => ' Moscow Moscow',
                 'message' => 'Whitespace characters must be allowed in city'
+            ],
+            [
+                'city' => 'O\'Higgins',
+                'message' => 'Straight apostrophe must be allowed in city names'
+            ],
+            [
+                'city' => 'O’Higgins',
+                'message' => 'Typographical apostrophe must be allowed in city names'
+            ],
+            [
+                'city' => 'Saint_Petersburg',
+                'message' => 'Underscore must be allowed in city names'
+            ],
+            [
+                'city' => 'Stratford-upon-Avon',
+                'message' => 'Hyphens must be allowed in city names'
+            ],
+            [
+                'city' => 'St. Petersburg',
+                'message' => 'Periods must be allowed in city names'
+            ],
+            [
+                'city' => 'Trinidad & Tobago',
+                'message' => 'Ampersand must be allowed in city names'
+            ],
+            [
+                'city' => 'Winston-Salem (NC)',
+                'message' => 'Parentheses must be allowed in city names'
+            ],
+            [
+                'city' => 'Rostov-on-Don, Russia',
+                'message' => 'Commas must be allowed in city names'
             ]
         ];
     }