ACQE-8858: Verify that The store that was requested should be visible on credit memo grid page in admin

Karishmathakare19 · Karishmathakare19 · commit 0f22b0d22805 · 2025-10-15T00:16:09.000+05:30
- Fixed cart issue as it was not being created in custom store
diff --git a/dev/tests/integration/testsuite/Magento/Sales/Model/StoreWithNumericNameCreditmemoWorkflowTest.php b/dev/tests/integration/testsuite/Magento/Sales/Model/StoreWithNumericNameCreditmemoWorkflowTest.php
@@ -10,29 +10,30 @@
 use PHPUnit\Framework\TestCase;
 use Magento\Framework\ObjectManagerInterface;
 use Magento\Sales\Api\CreditmemoRepositoryInterface;
+use Magento\Sales\Api\Data\CreditmemoInterface;
+use Magento\Sales\Api\Data\OrderInterface;
 use Magento\TestFramework\Helper\Bootstrap;
 use Magento\Catalog\Test\Fixture\Product as ProductFixture;
 use Magento\Store\Test\Fixture\Website as WebsiteFixture;
 use Magento\Store\Test\Fixture\Group as StoreGroupFixture;
 use Magento\Store\Test\Fixture\Store as StoreFixture;
+use Magento\Store\Api\Data\StoreInterface;
 use Magento\Customer\Test\Fixture\Customer as CustomerFixture;
-use Magento\Quote\Test\Fixture\CustomerCart as CustomerCartFixture;
 use Magento\Checkout\Test\Fixture\SetBillingAddress as SetBillingAddressFixture;
 use Magento\Checkout\Test\Fixture\SetShippingAddress as SetShippingAddressFixture;
 use Magento\Checkout\Test\Fixture\SetDeliveryMethod as SetDeliveryMethodFixture;
 use Magento\Checkout\Test\Fixture\SetPaymentMethod as SetPaymentMethodFixture;
 use Magento\Checkout\Test\Fixture\PlaceOrder as PlaceOrderFixture;
 use Magento\Sales\Test\Fixture\Invoice as InvoiceFixture;
 use Magento\Sales\Test\Fixture\Creditmemo as CreditmemoFixture;
-use Magento\Quote\Test\Fixture\AddProductToCart as AddProductToCartFixture;
 use Magento\TestFramework\Fixture\DataFixture;
 use Magento\TestFramework\Fixture\DataFixtureStorageManager;
 
 /**
  * Integration test for complete workflow:
  * Create website, store, and store view with numeric names -> Place orders -> Create credit memo -> Verify grid display
  *
- * @magentoDbIsolation enabled
+ * @magentoDbIsolation disabled
  * @magentoAppIsolation enabled
  * @magentoConfigFixture default/general/country/allow US
  * @magentoConfigFixture default/general/country/default US
@@ -52,13 +53,6 @@ class StoreWithNumericNameCreditmemoWorkflowTest extends TestCase
      */
     private $creditmemoRepository;
 
-    /**
-     * Test data constants
-     */
-    private const WEBSITE_NAME = '123test Website';
-    private const STORE_GROUP_NAME = '123test Store Group';
-    private const STORE_NAME = '123test Store View';
-
     /**
      * @inheritdoc
      */
@@ -91,56 +85,85 @@ protected function setUp(): void
             ],
             'test_store'
         ),
-        DataFixture(ProductFixture::class, ['sku' => 'simple', 'price' => 10], 'product'),
-        DataFixture(CustomerFixture::class, ['email' => 'customer@123test.com'], 'customer'),
         DataFixture(
-            CustomerCartFixture::class,
-            ['customer_id' => '$customer.id$', 'store_id' => '$test_store.id$'],
-            'cart'
+            ProductFixture::class,
+            ['sku' => 'simple', 'price' => 10, 'website_ids' => [1, '$test_website.id$']],
+            'product'
         ),
-        DataFixture(SetBillingAddressFixture::class, ['cart_id' => '$cart.id$']),
-        DataFixture(SetShippingAddressFixture::class, ['cart_id' => '$cart.id$']),
         DataFixture(
-            AddProductToCartFixture::class,
-            ['cart_id' => '$cart.id$', 'product_id' => '$product.id$', 'qty' => 2]
+            CustomerFixture::class,
+            ['email' => 'customer@123test.com', 'website_id' => '$test_website.id$'],
+            'customer'
         ),
-        DataFixture(
-            SetDeliveryMethodFixture::class,
-            ['cart_id' => '$cart.id$']
-        ),
-        DataFixture(SetPaymentMethodFixture::class, ['cart_id' => '$cart.id$']),
-        DataFixture(PlaceOrderFixture::class, ['cart_id' => '$cart.id$'], 'order'),
-        DataFixture(InvoiceFixture::class, ['order_id' => '$order.id$'], 'invoice'),
-        DataFixture(
-            CreditmemoFixture::class,
-            ['order_id' => '$order.id$', 'items' => [['qty' => 1, 'product_id' => '$product.id$']]],
-            'creditmemo'
-        )
     ]
     public function testCompleteWorkflowWithNumericStoreNames(): void
     {
-        // Step 1: Get fixtures
+        // Step 1: Get basic fixtures
         $fixtures = DataFixtureStorageManager::getStorage();
+        /** @var StoreInterface $store */
         $store = $fixtures->get('test_store');
-        $order = $fixtures->get('order');
-        $creditmemo = $fixtures->get('creditmemo');
+        $customer = $fixtures->get('customer');
+        $product = $fixtures->get('product');
+
+        // Step 2: Create cart manually with correct store ID (CustomerCartFixture doesn't support store_id)
+        $cartManagement = $this->objectManager->get('Magento\Quote\Api\CartManagementInterface');
+        $cartRepository = $this->objectManager->get('Magento\Quote\Api\CartRepositoryInterface');
+
+        $cartId = $cartManagement->createEmptyCartForCustomer($customer->getId());
+        $cart = $cartRepository->get($cartId);
+        $cart->setStoreId($store->getId());
+        $cartRepository->save($cart);
+
+        // Add product to cart
+        $cart->addProduct($product, 2);
+        $cartRepository->save($cart);
+
+        // Step 3: Use fixtures for checkout process
+        $billingAddressFixture = $this->objectManager->create(SetBillingAddressFixture::class);
+        $billingAddressFixture->apply(['cart_id' => $cart->getId()]);
+
+        $shippingAddressFixture = $this->objectManager->create(SetShippingAddressFixture::class);
+        $shippingAddressFixture->apply(['cart_id' => $cart->getId()]);
 
-        // Step 2: Verify credit memo grid displays records
-        $this->verifyCreditMemoGridDisplaysRecords($creditmemo, $order);
+        $deliveryMethodFixture = $this->objectManager->create(SetDeliveryMethodFixture::class);
+        $deliveryMethodFixture->apply(
+            ['cart_id' => $cart->getId(), 'carrier_code' => 'flatrate', 'method_code' => 'flatrate']
+        );
 
-        // Step 3: Verify store name rendering in grid context (UI validation proves DB layer works)
-        $this->verifyStoreNameRenderingInGrid($creditmemo, $store);
+        $paymentMethodFixture = $this->objectManager->create(SetPaymentMethodFixture::class);
+        $paymentMethodFixture->apply(['cart_id' => $cart->getId()]);
+
+        $placeOrderFixture = $this->objectManager->create(PlaceOrderFixture::class);
+        $order = $placeOrderFixture->apply(['cart_id' => $cart->getId()]);
+
+        $invoiceFixture = $this->objectManager->create(InvoiceFixture::class);
+        $invoiceFixture->apply(['order_id' => $order->getId()]);
+
+        $creditmemoFixture = $this->objectManager->create(CreditmemoFixture::class);
+        $creditmemo = $creditmemoFixture->apply([
+            'order_id' => $order->getId(),
+            'items' => [['qty' => 1, 'product_id' => $product->getId()]]
+        ]);
+
+        $this->assertEquals($store->getId(), $creditmemo->getStoreId(), 'Credit memo should be in test store');
+
+        // Step 4: Verify credit memo displays in grid page
+        $this->verifyCreditMemoGridDisplaysRecords($creditmemo, $order, $store);
     }
 
     /**
      * Verify credit memo grid displays records correctly
      *
      * @param CreditmemoInterface $creditmemo
      * @param OrderInterface $order
+     * @param StoreInterface $store
      * @return void
      */
-    private function verifyCreditMemoGridDisplaysRecords($creditmemo, $order): void
-    {
+    private function verifyCreditMemoGridDisplaysRecords(
+        CreditmemoInterface $creditmemo,
+        OrderInterface $order,
+        StoreInterface $store
+    ): void {
         // Test credit memo retrieval by order ID
         $creditmemoByOrder = $this->getCreditmemosByFilter('order_id', $order->getId());
         $this->assertCount(1, $creditmemoByOrder);
@@ -159,6 +182,39 @@ private function verifyCreditMemoGridDisplaysRecords($creditmemo, $order): void
         $foundCreditmemoById = reset($creditmemoById);
         $this->assertEquals($creditmemo->getId(), $foundCreditmemoById->getId());
         $this->assertEquals($order->getStoreId(), $foundCreditmemoById->getStoreId());
+
+        // Explicitly verify the credit memo is created in "123test Store View"
+        $this->assertEquals(
+            $store->getId(),
+            $creditmemo->getStoreId(),
+            'Credit memo should be created in the test store'
+        );
+        $this->assertEquals(
+            '123test Store View',
+            $store->getName(),
+            'Test store should have numeric name'
+        );
+
+        // Verify credit memo is visible when filtering by test store
+        $creditmemosByTestStore = $this->getCreditmemosByFilter('store_id', $store->getId());
+        $this->assertGreaterThan(
+            0,
+            count($creditmemosByTestStore),
+            'Credit memo should be visible when filtering by test store'
+        );
+
+        // Verify our specific credit memo is in the store-filtered results
+        $foundInStoreFilter = false;
+        foreach ($creditmemosByTestStore as $cm) {
+            if ($cm->getId() === $creditmemo->getId()) {
+                $foundInStoreFilter = true;
+                break;
+            }
+        }
+        $this->assertTrue(
+            $foundInStoreFilter,
+            'Credit memo should be found when filtering grid by "123test Store View"'
+        );
     }
 
     /**
@@ -168,82 +224,12 @@ private function verifyCreditMemoGridDisplaysRecords($creditmemo, $order): void
      * @param mixed $value
      * @return array
      */
-    private function getCreditmemosByFilter(string $field, $value): array
+    private function getCreditmemosByFilter(string $field, mixed $value): array
     {
         $searchCriteria = $this->objectManager->get('Magento\Framework\Api\SearchCriteriaBuilder')
             ->addFilter($field, $value)
             ->create();
 
         return $this->creditmemoRepository->getList($searchCriteria)->getItems();
     }
-
-    /**
-     * Verify store name rendering for credit memo
-     * Tests how store names with numeric prefixes are displayed
-     *
-     * @param CreditmemoInterface $creditmemo
-     * @param StoreInterface $store
-     * @return void
-     */
-    private function verifyStoreNameRenderingInGrid($creditmemo, $store): void
-    {
-        // Test store name rendering using the store renderer that would be used in grids
-        $storeRenderer = $this->objectManager->create('Magento\Backend\Block\Widget\Grid\Column\Renderer\Store');
-
-        // Create a mock grid column for the renderer
-        $mockColumn = $this->objectManager->create('Magento\Framework\DataObject');
-        $mockColumn->setData([
-            'index' => 'store_id',
-            'type' => 'store',
-            'skipEmptyStoresLabel' => false,
-            'skipAllStoresLabel' => false
-        ]);
-
-        $storeRenderer->setColumn($mockColumn);
-
-        // Create a mock row data object representing a grid row
-        $mockRow = $this->objectManager->create('Magento\Framework\DataObject');
-        $mockRow->setData([
-            'store_id' => $store->getId(),
-            'entity_id' => $creditmemo->getId()
-        ]);
-
-        // Test rendering of store name
-        $renderedOutput = $storeRenderer->render($mockRow);
-
-        // Verify that the store name is properly rendered and includes our numeric store name
-        $this->assertIsString($renderedOutput);
-        $this->assertNotEmpty($renderedOutput);
-
-        // The rendered output should contain the store hierarchy
-        $this->assertStringContainsString(self::WEBSITE_NAME, $renderedOutput); // '123test Website'
-        $this->assertStringContainsString(self::STORE_GROUP_NAME, $renderedOutput); // '123test Store Group'
-        $this->assertStringContainsString(self::STORE_NAME, $renderedOutput); // '123test Store View'
-
-        // Verify that numeric prefixes are properly handled (not truncated or misinterpreted)
-        $this->assertStringContainsString('123test', $renderedOutput);
-
-        // Verify store hierarchy rendering with numeric names
-        $lines = explode('<br/>', $renderedOutput);
-        $this->assertGreaterThan(0, count($lines));
-
-        // Basic structure validation
-        $flattenedOutput = strip_tags($renderedOutput);
-        $this->assertNotEmpty(trim($flattenedOutput));
-
-        // Test alternative rendering scenario - what happens with just store ID array
-        $mockRowWithArray = $this->objectManager->create('Magento\Framework\DataObject');
-        $mockRowWithArray->setData([
-            'store_id' => [$store->getId()], // Array format
-            'entity_id' => $creditmemo->getId()
-        ]);
-
-        $arrayRenderedOutput = $storeRenderer->render($mockRowWithArray);
-        $this->assertStringContainsString('123test', $arrayRenderedOutput);
-
-        // Verify grid display integrity - no XSS or formatting issues with numeric store names
-        $this->assertStringNotContainsString('<script', strtolower($renderedOutput));
-        $cleanOutput = strip_tags($renderedOutput);
-        $this->assertStringNotContainsString('<', $cleanOutput);
-    }
 }
