CR improvements

Author: andrewbess

app/code/Magento/Customer/Model/Options.php

@@ -47,11 +47,10 @@ public function __construct(
      */
     public function getNamePrefixOptions($store = null)
     {
-        $options = $this->addressHelper->getConfig('prefix_options', $store);
-        return $options !== null ? $this->prepareNamePrefixSuffixOptions(
-            $options,
+        return $this->prepareNamePrefixSuffixOptions(
+            $this->addressHelper->getConfig('prefix_options', $store),
             $this->addressHelper->getConfig('prefix_show', $store) === NooptreqSource::VALUE_OPTIONAL
-        ) : false;
+        );
     }
 
     /**
@@ -95,13 +94,12 @@ protected function _prepareNamePrefixSuffixOptions($options, $isOptional = false
      */
     private function prepareNamePrefixSuffixOptions($options, $isOptional = false)
     {
-        $options = trim($options);
-        if (empty($options)) {
+        if ($options === null || empty(trim($options))) {
             return false;
         }
-
         $result = [];
-        $options = explode(';', $options);
+        $options = explode(';', trim($options));
+
         foreach ($options as $value) {
             $result[] = $this->escaper->escapeHtml(trim($value)) ?: ' ';
         }

app/code/Magento/Dhl/Model/Carrier.php

@@ -940,7 +940,7 @@ protected function _getDimension($dimension, $configWeightUnit = false)
             );
         }
 
-        return $dimension ? round($dimension, 3) : 0.0;
+        return round((float) $dimension, 3);
     }
 
     /**