MC-42704:Admin Checkout validation bug

- Updated for code refactoring

Author: pradeep.rauthan

app/code/Magento/Sales/Model/AdminOrder/Create.php

@@ -679,32 +679,9 @@ public function initFromOrderItem(\Magento\Sales\Model\Order\Item $orderItem, $q
                 $buyRequest->setQty($qty);
             }
             $productOptions = $orderItem->getProductOptions();
-            if ($productOptions !== null && !empty($productOptions['options'])) {
-                $formattedOptions = [];
-                foreach ($productOptions['options'] as $option) {
-                    if (in_array($option['option_type'], ['date', 'date_time', 'time', 'file'])) {
-                        $product->setSkipCheckRequiredOption(false);
-                        if ($option['option_type'] === 'file') {
-                            try {
-                                $formattedOptions[$option['option_id']] =
-                                    $this->serializer->unserialize($option['option_value']);
-                                continue;
-                            } catch (\InvalidArgumentException $exception) {
-                                //log the exception as warning
-                                $this->_logger->warning($exception);
-                            }
-                        }
-                        $formattedOptions[$option['option_id']] =
-                            $buyRequest->getDataByKey('options')[$option['option_id']];
-                        continue;
-                    }
 
-                    $formattedOptions[$option['option_id']] = $option['option_value'];
-                }
-                if (!empty($formattedOptions)) {
-                    $buyRequest->setData('options', $formattedOptions);
-                }
-            }
+            $this->formattedOptions($product, $buyRequest, $productOptions);
+
             $item = $this->getQuote()->addProduct($product, $buyRequest);
             if (is_string($item)) {
                 return $item;
@@ -2181,4 +2158,42 @@ private function isAddressesAreEqual(Order $order)
 
         return $shippingData == $billingData;
     }
+
+    /**
+     * Set $buyRequest with formatted product options.
+     *
+     * @param \Magento\Catalog\Model\Product $product
+     * @param $buyRequest
+     * @param $productOptions
+     *
+     */
+    private function formattedOptions(\Magento\Catalog\Model\Product $product, $buyRequest, $productOptions): void
+    {
+        if ($productOptions !== null && !empty($productOptions['options'])) {
+            $formattedOptions = [];
+            foreach ($productOptions['options'] as $option) {
+                if (in_array($option['option_type'], ['date', 'date_time', 'time', 'file'])) {
+                    $product->setSkipCheckRequiredOption(false);
+                    if ($option['option_type'] === 'file') {
+                        try {
+                            $formattedOptions[$option['option_id']] =
+                                $this->serializer->unserialize($option['option_value']);
+                            continue;
+                        } catch (\InvalidArgumentException $exception) {
+                            //log the exception as warning
+                            $this->_logger->warning($exception);
+                        }
+                    }
+                    $formattedOptions[$option['option_id']] =
+                        $buyRequest->getDataByKey('options')[$option['option_id']];
+                    continue;
+                }
+
+                $formattedOptions[$option['option_id']] = $option['option_value'];
+            }
+            if (!empty($formattedOptions)) {
+                $buyRequest->setData('options', $formattedOptions);
+            }
+        }
+    }
 }