Fix static tests failure and updated request changes

Author: mahesh-singh-rajawat

lib/internal/Magento/Framework/Session/SaveHandler.php

@@ -6,6 +6,7 @@
 
 namespace Magento\Framework\Session;
 
+use Magento\Framework\App\Area;
 use Magento\Framework\App\ObjectManager;
 use Magento\Framework\App\State;
 use Magento\Framework\Exception\LocalizedException;
@@ -51,7 +52,10 @@ class SaveHandler implements SaveHandlerInterface
      */
     private $sessionMaxSizeConfig;
 
-    private ?ManagerInterface $messageManager;
+    /**
+     * @var ManagerInterface
+     */
+    private $messageManager;
 
     /**
      * @var State|mixed
@@ -113,19 +117,17 @@ public function close()
      * @param string $sessionId
      * @return string
      */
-    public function read($sessionId)
+    public function read($sessionId): string
     {
         $sessionData = $this->callSafely('read', $sessionId);
         $sessionMaxSize = $this->sessionMaxSizeConfig->getSessionMaxSize();
         $sessionSize = strlen($sessionData);
 
         if ($sessionSize !== null && $sessionMaxSize < $sessionSize) {
             $sessionData = '';
-            if ($this->appState->getAreaCode() == 'frontend') {
+            if ($this->appState->getAreaCode() === Area::AREA_FRONTEND) {
                 $this->messageManager->addErrorMessage(
-                    __(
-                        'There is an error. Please Contact store administrator.'
-                    )
+                    __('There is an error. Please Contact store administrator.')
                 );
             }
         }
@@ -141,7 +143,7 @@ public function read($sessionId)
      * @return bool
      * @throws LocalizedException
      */
-    public function write($sessionId, $data)
+    public function write($sessionId, $data): bool
     {
         $sessionMaxSize = $this->sessionMaxSizeConfig->getSessionMaxSize();
         $sessionSize = strlen($data);

lib/internal/Magento/Framework/Session/Test/Unit/SaveHandlerTest.php

@@ -119,17 +119,35 @@ public function testWriteSessionMaxSizeNull()
         $this->assertTrue($this->saveHandler->write("test_session_id", "testdata"));
     }
 
-    public function testWriteMoreThanSessionMaxSize()
+    /**
+     * @throws \Magento\Framework\Exception\LocalizedException
+     */
+    public function testWriteMoreThanSessionMaxSize(): void
     {
         $this->sessionMaxSizeConfigMock->expects($this->once())
             ->method('getSessionMaxSize')
             ->willReturn(1);
 
-        $this->saveHandlerAdapterMock->expects($this->any())
+        $this->saveHandlerAdapterMock->expects($this->never())
+            ->method('read');
+
+        $this->assertTrue($this->saveHandler->write("test_session_id", "testdata"));
+    }
+
+    /**
+     * @return void
+     */
+    public function testReadMoreThanSessionMaxSize(): void
+    {
+        $this->sessionMaxSizeConfigMock->expects($this->once())
+            ->method('getSessionMaxSize')
+            ->willReturn(1);
+
+        $this->saveHandlerAdapterMock->expects($this->once())
             ->method('read')
             ->with('test_session_id')
             ->willReturn('test_session_data');
 
-        $this->assertTrue($this->saveHandler->write("test_session_id", "testdata"));
+        $this->assertEquals(null, $this->saveHandler->read("test_session_id"));
     }
 }