AC-15800::[CE] PHPUnit 12: Refactor Inline Anonymous Classes to Helper Classes in PR #2559 & PR#2579 | Catalog Helper Refactoring

Author: cod43156

app/code/Magento/Catalog/Test/Unit/Helper/CategoryCollectionFactoryTestHelper.php

@@ -1,6 +1,6 @@
 <?php
 /**
- * Copyright 2025 Adobe
+ * Copyright 2024 Adobe
  * All Rights Reserved.
  */
 declare(strict_types=1);
@@ -9,6 +9,9 @@
 
 use Magento\Catalog\Model\ProductLink\Link;
 
+/**
+ * Test helper for ProductLink\Link
+ */
 class ProductLinkInterfaceTestHelper extends Link
 {
     /**
@@ -28,7 +31,7 @@ class ProductLinkInterfaceTestHelper extends Link
 
     public function __construct()
     {
-        // Empty constructor
+        // Empty constructor - skip parent dependencies
     }
 
     /**
@@ -89,4 +92,3 @@ public function getExtensionAttributes()
         return $this->extensionAttributesOverride;
     }
 }
-

app/code/Magento/Catalog/Test/Unit/Helper/ProductLinkInterfaceTestHelper.php

@@ -1,67 +1,78 @@
 <?php
 /**
- * Copyright 2025 Adobe
+ * Copyright 2015 Adobe
  * All Rights Reserved.
  */
 declare(strict_types=1);
 
 namespace Magento\Catalog\Test\Unit\Helper;
 
-use Magento\Catalog\Model\ResourceModel\Product\Link;
+use Magento\Catalog\Model\Product\Link;
 
+/**
+ * Test helper for Product\Link
+ */
 class ProductLinkTestHelper extends Link
 {
     /**
-     * @var mixed
+     * @var string
      */
-    private $linkedProductId = null;
+    private $linkedProductId;
 
     /**
-     * @var mixed
+     * @var array
      */
-    private $arrayData = null;
+    private $arrayData = [];
 
+    /**
+     * Skip parent constructor
+     */
     public function __construct()
     {
-        // Empty constructor
+        // Intentionally empty - skip parent constructor for testing
     }
 
     /**
-     * @return mixed
+     * Get linked product ID
+     *
+     * @return string
      */
     public function getLinkedProductId()
     {
         return $this->linkedProductId;
     }
 
     /**
-     * @param mixed $id
-     * @return $this
+     * Set linked product ID
+     *
+     * @param string $id
+     * @return void
      */
     public function setLinkedProductId($id)
     {
         $this->linkedProductId = $id;
-        return $this;
     }
 
     /**
-     * @param mixed $keys
-     * @return mixed
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     * Convert to array
+     *
+     * @param array $keys
+     * @return array
      */
-    public function toArray($keys = null)
+    public function toArray(array $keys = [])
     {
         return $this->arrayData;
     }
 
     /**
-     * @param mixed $data
-     * @return $this
+     * Set array data
+     *
+     * @param array $data
+     * @return void
      */
-    public function setArrayData($data)
+    public function setArrayData(array $data)
     {
         $this->arrayData = $data;
-        return $this;
     }
 }