Use constructor property promotion in module send friend graph ql

Replace allmost all properties with constructor property promotion in module send friend graph ql: https://stitcher.io/blog/constructor-promotion-in-php-8

Readable code
* Make Magento less complex by removing properties which take up a lot of lines.
* Imported all classes to make code more readable.

I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now.

Author: l-helmus-youwe

app/code/Magento/SendFriendGraphQl/Model/Provider/GetVisibleProduct.php

@@ -18,22 +18,14 @@
  */
 class GetVisibleProduct
 {
-    /** @var ProductRepositoryInterface */
-    private $productRepository;
-
-    /** @var Visibility */
-    private $visibility;
-
     /**
      * @param ProductRepositoryInterface $productRepository
      * @param Visibility $visibility
      */
     public function __construct(
-        ProductRepositoryInterface $productRepository,
-        Visibility $visibility
+        private readonly ProductRepositoryInterface $productRepository,
+        private readonly Visibility $visibility
     ) {
-        $this->productRepository = $productRepository;
-        $this->visibility = $visibility;
     }
 
     /**

app/code/Magento/SendFriendGraphQl/Model/Resolver/SendEmailToFriend.php

@@ -21,26 +21,14 @@
  */
 class SendEmailToFriend implements ResolverInterface
 {
-    /**
-     * @var SendFriendHelper
-     */
-    private $sendFriendHelper;
-
-    /**
-     * @var SendEmail
-     */
-    private $sendEmail;
-
     /**
      * @param SendEmail $sendEmail
      * @param SendFriendHelper $sendFriendHelper
      */
     public function __construct(
-        SendEmail $sendEmail,
-        SendFriendHelper $sendFriendHelper
+        private readonly SendEmail $sendEmail,
+        private readonly SendFriendHelper $sendFriendHelper
     ) {
-        $this->sendEmail = $sendEmail;
-        $this->sendFriendHelper = $sendFriendHelper;
     }
 
     /**

app/code/Magento/SendFriendGraphQl/Model/Resolver/SendFriendConfiguration.php

@@ -17,17 +17,12 @@
  */
 class SendFriendConfiguration implements ResolverInterface
 {
-    /**
-     * @var SendFriendHelper
-     */
-    private $sendFriendHelper;
-
     /**
      * @param SendFriendHelper $sendFriendHelper
      */
-    public function __construct(SendFriendHelper $sendFriendHelper)
-    {
-        $this->sendFriendHelper = $sendFriendHelper;
+    public function __construct(
+        private readonly SendFriendHelper $sendFriendHelper
+    ) {
     }
 
     /**

app/code/Magento/SendFriendGraphQl/Model/SendFriend/SendEmail.php

@@ -11,6 +11,7 @@
 use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Framework\DataObjectFactory;
 use Magento\Framework\Event\ManagerInterface;
+use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\GraphQl\Exception\GraphQlInputException;
 use Magento\Framework\GraphQl\Exception\GraphQlNoSuchEntityException;
@@ -23,31 +24,6 @@
  */
 class SendEmail
 {
-    /**
-     * @var DataObjectFactory
-     */
-    private $dataObjectFactory;
-
-    /**
-     * @var ProductRepositoryInterface
-     */
-    private $productRepository;
-
-    /**
-     * @var SendFriendFactory
-     */
-    private $sendFriendFactory;
-
-    /**
-     * @var ManagerInterface
-     */
-    private $eventManager;
-
-    /**
-     * @var GetVisibleProduct
-     */
-    private $visibleProductProvider;
-
     /**
      * SendEmail constructor.
      * @param DataObjectFactory $dataObjectFactory
@@ -57,17 +33,12 @@ class SendEmail
      * @param GetVisibleProduct $visibleProductProvider
      */
     public function __construct(
-        DataObjectFactory $dataObjectFactory,
-        ProductRepositoryInterface $productRepository,
-        SendFriendFactory $sendFriendFactory,
-        ManagerInterface $eventManager,
-        GetVisibleProduct $visibleProductProvider
+        private readonly DataObjectFactory $dataObjectFactory,
+        private readonly ProductRepositoryInterface $productRepository,
+        private readonly SendFriendFactory $sendFriendFactory,
+        private readonly ManagerInterface $eventManager,
+        private readonly GetVisibleProduct $visibleProductProvider
     ) {
-        $this->dataObjectFactory = $dataObjectFactory;
-        $this->productRepository = $productRepository;
-        $this->sendFriendFactory = $sendFriendFactory;
-        $this->eventManager = $eventManager;
-        $this->visibleProductProvider = $visibleProductProvider;
     }
 
     /**
@@ -78,7 +49,7 @@ public function __construct(
      * @param array $recipientsData
      * @throws GraphQlInputException
      * @throws GraphQlNoSuchEntityException
-     * @throws \Magento\Framework\Exception\LocalizedException
+     * @throws LocalizedException
      */
     public function execute(int $productId, array $senderData, array $recipientsData): void
     {

app/code/Magento/SendFriendGraphQl/registration.php

@@ -7,4 +7,8 @@
 
 use Magento\Framework\Component\ComponentRegistrar;
 
-ComponentRegistrar::register(ComponentRegistrar::MODULE, 'Magento_SendFriendGraphQl', __DIR__);
+ComponentRegistrar::register(
+    ComponentRegistrar::MODULE,
+    'Magento_SendFriendGraphQl',
+    __DIR__
+);