Skip to content

Commit 2ed1ad0

Browse files
committed
Fix static test warnings
1 parent 03ae0e1 commit 2ed1ad0

File tree

2 files changed

+8
-2
lines changed
  • app/code/Magento/MediaGalleryUi
    • Model/SearchCriteria/CollectionProcessor/FilterProcessor
    • Test/Unit/Model/SearchCriteria/CollectionProcessor/FilterProcessor

2 files changed

+8
-2
lines changed

app/code/Magento/MediaGalleryUi/Model/SearchCriteria/CollectionProcessor/FilterProcessor/Directory.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ class Directory implements CustomFilterInterface
1919
*/
2020
private $logger;
2121

22+
/**
23+
* @param LoggerInterface $logger
24+
*/
2225
public function __construct(LoggerInterface $logger)
2326
{
2427
$this->logger = $logger;
@@ -44,7 +47,10 @@ public function apply(Filter $filter, AbstractDb $collection): bool
4447
} catch (\Exception $e) {
4548
// Log the error for debugging but continue with case-insensitive fallback
4649
// Note: This fallback means directory filtering will not be case-sensitive
47-
$this->logger->error('MediaGallery Directory Filter: BINARY REGEXP not supported, using case-insensitive fallback: ' . $e->getMessage());
50+
$this->logger->error(
51+
'MediaGallery Directory Filter: BINARY REGEXP not supported, ' .
52+
'using case-insensitive fallback: ' . $e->getMessage()
53+
);
4854
$collection->getSelect()->where('path REGEXP ? ', '^' . $value . '/[^\/]*$');
4955
}
5056

app/code/Magento/MediaGalleryUi/Test/Unit/Model/SearchCriteria/CollectionProcessor/FilterProcessor/DirectoryTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class DirectoryTest extends TestCase
4444
*/
4545
protected function setUp(): void
4646
{
47-
$this->directoryFilterProcessor = new Directory();
47+
$this->directoryFilterProcessor = new Directory($this->createMock(\Psr\Log\LoggerInterface::class));
4848
$this->collectionMock = $this->createMock(AbstractDb::class);
4949
$this->selectMock = $this->createMock(Select::class);
5050
$this->filterMock = $this->createMock(Filter::class);

0 commit comments

Comments
 (0)