MC-42158: [Improvement request] Module List Loading Taking Extremely Long

tsviklinskyi · tsviklinskyi · commit 344d7ed7d358 · 2021-05-24T16:57:14.000+03:00
diff --git a/lib/internal/Magento/Framework/Module/ModuleList/Loader.php b/lib/internal/Magento/Framework/Module/ModuleList/Loader.php
@@ -222,8 +222,11 @@ private function expandSequence(
                 $allSequences[] = $relatedSequence;
             }
             $allSequences[] = $sequence;
+
             // Caching the full sequence list
-            $sequenceCache[$name] = array_unique(array_merge(...$allSequences));
+            if (!empty($allSequences)) {
+                $sequenceCache[$name] = array_unique(array_merge(...$allSequences));
+            }
         }
 
         return $sequenceCache[$name] ?? [];

Original file line number	Diff line number	Diff line change
`@@ -222,8 +222,11 @@ private function expandSequence(`
`222`	`222`	`$allSequences[] = $relatedSequence;`
`223`	`223`	`}`
`224`	`224`	`$allSequences[] = $sequence;`
	`225`	`+`
`225`	`226`	`// Caching the full sequence list`
`226`		`- $sequenceCache[$name] = array_unique(array_merge(...$allSequences));`
	`227`	`+ if (!empty($allSequences)) {`
	`228`	`+ $sequenceCache[$name] = array_unique(array_merge(...$allSequences));`
	`229`	`+ }`
`227`	`230`	`}`
`228`	`231`
`229`	`232`	`return $sequenceCache[$name] ?? [];`