39099: fix failed unit test and remove extra line

Author: engcom-Dash

app/code/Magento/PageCache/Test/Unit/Model/App/Request/Http/IdentifierForSaveTest.php

@@ -8,7 +8,10 @@
 namespace Magento\PageCache\Test\Unit\Model\App\Request\Http;
 
 use Magento\Framework\App\Http\Context;
+use Magento\Framework\App\ObjectManager;
+use Magento\Framework\App\PageCache\Identifier;
 use Magento\Framework\App\Request\Http as HttpRequest;
+use Magento\Framework\ObjectManagerInterface;
 use Magento\Framework\Serialize\Serializer\Json;
 use Magento\PageCache\Model\App\Request\Http\IdentifierForSave;
 use Magento\PageCache\Model\App\Request\Http\IdentifierStoreReader;
@@ -46,6 +49,11 @@ class IdentifierForSaveTest extends TestCase
      */
     private $identifierStoreReader;
 
+    /**
+     * @var Identifier
+     */
+    private $identifierMock;
+
     /**
      * @inheritdoc
      */
@@ -74,6 +82,16 @@ function ($value) {
             ->disableOriginalConstructor()
             ->getMock();
 
+        $this->identifierMock = $this->getMockBuilder(Identifier::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $objectManagerMock = $this->getMockForAbstractClass(ObjectManagerInterface::class);
+        $objectManagerMock->expects($this->once())
+            ->method('get')
+            ->willReturn($this->identifierMock);
+        ObjectManager::setInstance($objectManagerMock);
+
         $this->model = new IdentifierForSave(
             $this->requestMock,
             $this->contextMock,
@@ -90,6 +108,10 @@ function ($value) {
      */
     public function testGetValue(): void
     {
+        $this->identifierMock->expects($this->once())
+            ->method('getMarketingParameterPatterns')
+            ->willReturn($this->getpattern());
+
         $this->requestMock->expects($this->any())
             ->method('isSecure')
             ->willReturn(true);
@@ -129,6 +151,10 @@ function ($value) {
      */
     public function testGetValueWithMarketingParameters(): void
     {
+        $this->identifierMock->expects($this->any())
+            ->method('getMarketingParameterPatterns')
+            ->willReturn($this->getPattern());
+
         $this->requestMock->expects($this->any())
             ->method('isSecure')
             ->willReturn(true);
@@ -160,4 +186,33 @@ function ($value) {
             $this->model->getValue()
         );
     }
+
+    /**
+     * @return string[]
+     */
+    public function getPattern(): array
+    {
+        return [
+            '/&?gad_source\=[^&]+/',
+            '/&?gbraid\=[^&]+/',
+            '/&?wbraid\=[^&]+/',
+            '/&?_gl\=[^&]+/',
+            '/&?dclid\=[^&]+/',
+            '/&?gclsrc\=[^&]+/',
+            '/&?srsltid\=[^&]+/',
+            '/&?msclkid\=[^&]+/',
+            '/&?_kx\=[^&]+/',
+            '/&?gclid\=[^&]+/',
+            '/&?cx\=[^&]+/',
+            '/&?ie\=[^&]+/',
+            '/&?cof\=[^&]+/',
+            '/&?siteurl\=[^&]+/',
+            '/&?zanpid\=[^&]+/',
+            '/&?origin\=[^&]+/',
+            '/&?fbclid\=[^&]+/',
+            '/&?mc_(.*?)\=[^&]+/',
+            '/&?utm_(.*?)\=[^&]+/',
+            '/&?_bta_(.*?)\=[^&]+/',
+        ];
+    }
 }

lib/internal/Magento/Framework/App/PageCache/Identifier.php

@@ -65,7 +65,6 @@ public function getValue()
     /**
      * Pattern detect marketing parameters
      *
-     *
      * @return array
      */
     public function getMarketingParameterPatterns(): array