Skip to content

Commit 436510c

Browse files
committed
Merge remote-tracking branch 'origin/ACP2E-4324' into PR_2025_11_20_flowers
2 parents 255e840 + 3192cbf commit 436510c

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

app/code/Magento/PageCache/Model/App/Response/HttpPlugin.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ public function beforeSendResponse(HttpResponse $subject)
4343

4444
$currentVary = $this->context->getVaryString();
4545
$varyCookie = $this->request->get(HttpResponse::COOKIE_VARY_STRING);
46-
if ($currentVary !== $varyCookie) {
47-
//prevent caching with the old vary cookie
46+
if (isset($varyCookie) && ($currentVary !== $varyCookie)) {
4847
$subject->setNoCacheHeaders();
4948
}
5049
$subject->sendVary();

app/code/Magento/PageCache/Test/Unit/Model/App/Response/HttpPluginTest.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,4 +92,16 @@ public function testBeforeSendResponseVaryMismatch()
9292

9393
$this->httpPlugin->beforeSendResponse($responseMock);
9494
}
95+
96+
public function testBeforeSendResponseVaryNotSet()
97+
{
98+
/** @var HttpResponse|MockObject $responseMock */
99+
$this->context->expects($this->any())->method('getVaryString')->willReturn('currentVary');
100+
$this->request->expects($this->any())->method('get')->willReturn(null);
101+
/** @var HttpResponse|MockObject $responseMock */
102+
$responseMock = $this->createMock(HttpResponse::class);
103+
$responseMock->expects($this->never())->method('setNoCacheHeaders');
104+
$responseMock->expects($this->once())->method('sendVary');
105+
$this->httpPlugin->beforeSendResponse($responseMock);
106+
}
95107
}

0 commit comments

Comments
 (0)