Skip to content

Commit 44d49ca

Browse files
committed
AC-15049 : [CE] PHPUnit 12: Upgrade Security & Authentication related test cases
1 parent 0ca95ed commit 44d49ca

File tree

8 files changed

+6
-20
lines changed

8 files changed

+6
-20
lines changed

app/code/Magento/Captcha/Test/Unit/Observer/CheckContactUsFormObserverTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ class CheckContactUsFormObserverTest extends TestCase
3232
{
3333
use MockCreationTrait;
3434

35-
3635
/**
3736
* @var CheckContactUsFormObserver
3837
*/

app/code/Magento/EncryptionKey/Test/Unit/Model/ResourceModel/Key/ChangeTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,10 @@ protected function setUp(): void
9595
$this->objRelationMock = $this->createMock(ObjectRelationProcessor::class);
9696
$this->randomMock = $this->createMock(Random::class);
9797

98-
$contextMock = $this->createPartialMock(\Magento\Framework\Model\ResourceModel\Db\Context::class, ['getResources']);
98+
$contextMock = $this->createPartialMock(
99+
\Magento\Framework\Model\ResourceModel\Db\Context::class,
100+
['getResources']
101+
);
99102
$contextMock->method('getResources')->willReturn($this->resourceMock);
100103

101104
$this->model = new Change(

app/code/Magento/User/Test/Unit/Controller/Adminhtml/User/SaveTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@ class SaveTest extends TestCase
6868

6969
protected function setUp(): void
7070
{
71-
$objectManagerHelper = new ObjectManagerHelper($this);
72-
7371
$this->requestMock = $this->createMock(Http::class);
7472
$this->messageManagerMock = $this->createMock(ManagerInterface::class);
7573
$this->userFactoryMock = $this->createPartialMock(UserFactory::class, ['create']);

app/code/Magento/User/Test/Unit/Model/ResourceModel/UserTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ public function testHasAssigned2Role()
138138

139139
public function testHasAssigned2RolePassAnObject()
140140
{
141-
$helper = new ObjectManager($this);
142141
$methodUserMock = $this->createPartialMockWithReflection(
143142
AbstractModel::class,
144143
['getUserId']
@@ -310,7 +309,6 @@ public function testGetOldPassword()
310309

311310
public function testDeleteFromRole()
312311
{
313-
$helper = new ObjectManager($this);
314312
$methodUserMock = $this->createPartialMockWithReflection(
315313
AbstractModel::class,
316314
['getUserId', 'getRoleId']
@@ -330,7 +328,6 @@ public function testDeleteFromRole()
330328

331329
public function testRoleUserExists()
332330
{
333-
$helper = new ObjectManager($this);
334331
$methodUserMock = $this->createPartialMockWithReflection(
335332
AbstractModel::class,
336333
['getUserId', 'getRoleId']

app/code/Magento/User/Test/Unit/Observer/Backend/AuthObserverTest.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,6 @@ public function testAdminAuthenticate()
130130
'last_updated' => 1496248367
131131
];
132132

133-
$helper = new ObjectManager($this);
134-
135133
/** @var Observer|MockObject $eventObserverMock */
136134
$eventObserverMock = $this->createPartialMock(Observer::class, ['getEvent']);
137135

@@ -181,8 +179,6 @@ public function testAdminAuthenticateThrowsException()
181179
$authResult = true;
182180
$lockExpires = '3015-07-08 11:14:15.638276';
183181

184-
$helper = new ObjectManager($this);
185-
186182
/** @var Observer|MockObject $eventObserverMock */
187183
$eventObserverMock = $this->createPartialMock(Observer::class, ['getEvent']);
188184

@@ -228,8 +224,6 @@ public function testAdminAuthenticatePasswordExpire(): void
228224
'last_updated' => 1694661402
229225
];
230226

231-
$helper = new ObjectManager($this);
232-
233227
/** @var Observer|MockObject $eventObserverMock */
234228
$eventObserverMock = $this->createPartialMock(Observer::class, ['getEvent']);
235229

@@ -281,8 +275,6 @@ public function testAdminAuthenticateUpdateLockingInfo()
281275
$firstFailure = '1965-07-08 11:14:15.638276';
282276
$numOfFailures = 5;
283277

284-
$helper = new ObjectManager($this);
285-
286278
/** @var Observer|MockObject $eventObserverMock */
287279
$eventObserverMock = $this->createPartialMock(Observer::class, ['getEvent']);
288280

app/code/Magento/User/Test/Unit/Observer/Backend/ForceAdminPasswordChangeObserverTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,6 @@ protected function setUp(): void
109109

110110
public function testForceAdminPasswordChange()
111111
{
112-
$helper = new ObjectManager($this);
113-
114112
/** @var Observer|MockObject $eventObserverMock */
115113
$eventObserverMock = $this->createPartialMock(Observer::class, ['getEvent']);
116114

app/code/Magento/User/Test/Unit/Observer/Backend/TrackAdminNewPasswordObserverTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ protected function setUp(): void
8686

8787
public function testTrackAdminPassword()
8888
{
89-
$helper = new ObjectManager($this);
9089
$newPW = "mYn3wpassw0rd";
9190
$uid = 123;
9291
/** @var Observer|MockObject $eventObserverMock */

lib/internal/Magento/Framework/TestFramework/Unit/Helper/MockCreationTrait.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2025 Adobe
4+
* All Rights Reserved.
55
*/
66
declare(strict_types=1);
77

0 commit comments

Comments
 (0)