Refactor ResourceConnection.php

Author: lbajsarowicz

lib/internal/Magento/Framework/App/ResourceConnection.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\App;
 
 use Magento\Framework\App\ResourceConnection\ConfigInterface as ResourceConfigInterface;
@@ -18,13 +20,10 @@
  */
 class ResourceConnection
 {
-    const AUTO_UPDATE_ONCE = 0;
-
-    const AUTO_UPDATE_NEVER = -1;
-
-    const AUTO_UPDATE_ALWAYS = 1;
-
-    const DEFAULT_CONNECTION = 'default';
+    public const AUTO_UPDATE_ONCE = 0;
+    public const AUTO_UPDATE_NEVER = -1;
+    public const AUTO_UPDATE_ALWAYS = 1;
+    public const DEFAULT_CONNECTION = 'default';
 
     /**
      * Instances of actual connections.
@@ -93,8 +92,7 @@ public function __construct(
     public function getConnection($resourceName = self::DEFAULT_CONNECTION)
     {
         $connectionName = $this->config->getConnectionName($resourceName);
-        $connection = $this->getConnectionByName($connectionName);
-        return $connection;
+        return $this->getConnectionByName($connectionName);
     }
 
     /**
@@ -160,13 +158,13 @@ public function getConnectionByName($connectionName)
      */
     private function getProcessConnectionName($connectionName)
     {
-        return  $connectionName . '_process_' . getmypid();
+        return $connectionName . '_process_' . getmypid();
     }
 
     /**
      * Get resource table name, validated by db adapter.
      *
-     * @param   string|string[] $modelEntity
+     * @param string|string[] $modelEntity
      * @param string $connectionName
      * @return  string
      * @api
@@ -212,9 +210,9 @@ public function getTablePlaceholder($tableName)
     /**
      * Build a trigger name.
      *
-     * @param string $tableName  The table that is the subject of the trigger
-     * @param string $time  Either "before" or "after"
-     * @param string $event  The DB level event which activates the trigger, i.e. "update" or "insert"
+     * @param string $tableName The table that is the subject of the trigger
+     * @param string $time Either "before" or "after"
+     * @param string $event The DB level event which activates the trigger, i.e. "update" or "insert"
      * @return string
      */
     public function getTriggerName($tableName, $time, $event)
@@ -275,9 +273,9 @@ public function getIdxName(
     /**
      * Retrieve 32bit UNIQUE HASH for a Table foreign key.
      *
-     * @param string $priTableName  the target table name
+     * @param string $priTableName the target table name
      * @param string $priColumnName the target table column name
-     * @param string $refTableName  the reference table name
+     * @param string $refTableName the reference table name
      * @param string $refColumnName the reference table column name
      * @return string
      */
@@ -302,10 +300,7 @@ public function getFkName($priTableName, $priColumnName, $refTableName, $refColu
     public function getSchemaName($resourceName)
     {
         return $this->deploymentConfig->get(
-            ConfigOptionsListConstants::CONFIG_PATH_DB_CONNECTIONS .
-            '/' .
-            $resourceName .
-            '/dbname'
+            ConfigOptionsListConstants::CONFIG_PATH_DB_CONNECTIONS . '/' . $resourceName . '/dbname'
         );
     }
 
@@ -320,8 +315,6 @@ public function getTablePrefix()
             return $this->tablePrefix;
         }
 
-        return (string) $this->deploymentConfig->get(
-            ConfigOptionsListConstants::CONFIG_PATH_DB_PREFIX
-        );
+        return (string)$this->deploymentConfig->get(ConfigOptionsListConstants::CONFIG_PATH_DB_PREFIX);
     }
 }