AC-15635: PHPUnit 12 Upgrade | Optimize code

Author: manishranjan-adobe

app/code/Magento/AdvancedPricingImportExport/Test/Unit/Helper/AdvancedPricingExportTestHelper.php

@@ -8,6 +8,8 @@
 namespace Magento\AdvancedPricingImportExport\Test\Unit\Helper;
 
 use Magento\AdvancedPricingImportExport\Model\Export\AdvancedPricing;
+use Magento\Eav\Model\Entity\Collection\AbstractCollection;
+use Magento\Store\Model\Store;
 
 /**
  * Test helper for AdvancedPricing Export
@@ -164,14 +166,14 @@ public function _customHeadersMapping($rowData)
     /**
      * Prepare entity collection
      *
-     * @param \Magento\Eav\Model\Entity\Collection\AbstractCollection $collection
+     * @param AbstractCollection $collection
      * @return $this
      */
-    public function _prepareEntityCollection(\Magento\Eav\Model\Entity\Collection\AbstractCollection $collection)
+    public function _prepareEntityCollection(AbstractCollection $collection)
     {
         $this->entityCollection = $collection;
         // Call setStoreId on the collection to satisfy the test expectation
-        $collection->setStoreId(\Magento\Store\Model\Store::DEFAULT_STORE_ID);
+        $collection->setStoreId(Store::DEFAULT_STORE_ID);
         return $this;
     }
 

app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Export/AdvancedPricingTest.php

@@ -37,7 +37,7 @@
 use Magento\Catalog\Model\ResourceModel\Product\Collection as ProductCollection;
 use Magento\Eav\Model\Entity\Collection\AbstractCollection;
 use Magento\ImportExport\Model\Export\Config as ExportConfig;
-use ReflectionClass;
+use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use stdClass;
 
 /**
@@ -224,12 +224,15 @@ protected function setUp(): void
             'correctExportData'
         ]);
 
-        $this->advancedPricing = new AdvancedPricingExportTestHelper();
-        
-        // Manually set the required properties that would normally be set by the parent constructor
-        $this->setPropertyValue($this->advancedPricing, '_storeResolver', $this->storeResolver);
-        $this->setPropertyValue($this->advancedPricing, '_groupRepository', $this->groupRepository);
-        $this->setPropertyValue($this->advancedPricing, '_resource', $this->resource);
+        $objectManager = new ObjectManager($this);
+        $this->advancedPricing = $objectManager->getObject(
+            AdvancedPricingExportTestHelper::class,
+            [
+                '_storeResolver' => $this->storeResolver,
+                '_groupRepository' => $this->groupRepository,
+                '_resource' => $this->resource
+            ]
+        );
     }
 
     /**
@@ -308,38 +311,4 @@ protected function tearDown(): void
     {
         unset($this->object);
     }
-
-    /**
-     * Get any object property value.
-     *
-     * @param $object
-     * @param $property
-     * @return mixed
-     * @throws \ReflectionException
-     */
-    protected function getPropertyValue($object, $property)
-    {
-        $reflection = new ReflectionClass(get_class($object));
-        $reflectionProperty = $reflection->getProperty($property);
-        $reflectionProperty->setAccessible(true);
-        return $reflectionProperty->getValue($object);
-    }
-
-    /**
-     * Set object property value.
-     *
-     * @param $object
-     * @param $property
-     * @param $value
-     * @return mixed
-     * @throws \ReflectionException
-     */
-    protected function setPropertyValue(&$object, $property, $value)
-    {
-        $reflection = new ReflectionClass(get_class($object));
-        $reflectionProperty = $reflection->getProperty($property);
-        $reflectionProperty->setAccessible(true);
-        $reflectionProperty->setValue($object, $value);
-        return $object;
-    }
 }

app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Import/AdvancedPricing/Validator/TierPriceTest.php

@@ -22,12 +22,12 @@
 use Magento\Framework\App\ResourceConnection;
 use Magento\Framework\Json\Helper\Data;
 use Magento\Framework\Stdlib\StringUtils;
+use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\ImportExport\Helper\Data as ImportExportHelperData;
 use Magento\ImportExport\Model\ResourceModel\Helper;
 use Magento\ImportExport\Model\ResourceModel\Import\Data as ResourceImportData;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
-use ReflectionClass;
 
 /**
  * @SuppressWarnings(PHPMD)
@@ -54,8 +54,14 @@ class TierPriceTest extends TestCase
      */
     protected $tierPrice;
 
+    /**
+     * @var ObjectManager
+     */
+    protected $objectManager;
+
     protected function setUp(): void
     {
+        $this->objectManager = new ObjectManager($this);
         $this->groupRepository = $this->createMock(GroupRepositoryInterface::class);
 
         $this->searchCriteriaBuilder = $this->createMock(SearchCriteriaBuilder::class);
@@ -114,13 +120,16 @@ public function testInitAddToCustomerGroups()
 
         $this->tierPrice->init(null);
 
-        $this->assertEquals($expectedCustomerGroups, $this->getPropertyValue($this->tierPrice, 'customerGroups'));
+        $reflection = new \ReflectionClass($this->tierPrice);
+        $property = $reflection->getProperty('customerGroups');
+        $property->setAccessible(true);
+        $this->assertEquals($expectedCustomerGroups, $property->getValue($this->tierPrice));
     }
 
     public function testIsValidResultTrue()
     {
         $this->tierPrice->expects($this->once())->method('isValidValueAndLength')->willReturn(false);
-        $this->setPropertyValue($this->tierPrice, 'customerGroups', true);
+        $this->objectManager->setBackwardCompatibleProperty($this->tierPrice, 'customerGroups', true);
 
         $result = $this->tierPrice->isValid([]);
         $this->assertTrue($result);
@@ -152,7 +161,7 @@ public function testIsValidAddMessagesCall($value, $hasEmptyColumns, $customerGr
 
         $this->tierPrice->expects($this->once())->method('isValidValueAndLength')->willReturn(true);
         $this->tierPrice->method('hasEmptyColumns')->willReturn($hasEmptyColumns);
-        $this->setPropertyValue($this->tierPrice, 'customerGroups', $customerGroups);
+        $this->objectManager->setBackwardCompatibleProperty($this->tierPrice, 'customerGroups', $customerGroups);
 
         $searchCriteria = $this->createMock(SearchCriteria::class);
         $this->searchCriteriaBuilder->method('create')->willReturn($searchCriteria);
@@ -330,40 +339,4 @@ public static function isValidAddMessagesCallDataProvider()
             ],
         ];
     }
-
-    /**
-     * Get any object property value.
-     *
-     * @param object $object
-     * @param string $property
-     * @return mixed
-     * @throws \ReflectionException
-     */
-    protected function getPropertyValue($object, $property)
-    {
-        $reflection = new ReflectionClass(get_class($object));
-        $reflectionProperty = $reflection->getProperty($property);
-        $reflectionProperty->setAccessible(true);
-
-        return $reflectionProperty->getValue($object);
-    }
-
-    /**
-     * Set object property value.
-     *
-     * @param object $object
-     * @param string $property
-     * @param mixed $value
-     * @return object
-     * @throws \ReflectionException
-     */
-    protected function setPropertyValue(&$object, $property, $value)
-    {
-        $reflection = new ReflectionClass(get_class($object));
-        $reflectionProperty = $reflection->getProperty($property);
-        $reflectionProperty->setAccessible(true);
-        $reflectionProperty->setValue($object, $value);
-
-        return $object;
-    }
 }

app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Import/AdvancedPricingTest.php

@@ -27,6 +27,7 @@
 use Magento\Framework\Json\Helper\Data;
 use Magento\Framework\Stdlib\DateTime\DateTime;
 use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
+use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Catalog\Helper\Data as CatalogHelperData;
 use Magento\Catalog\Model\Product as CatalogProduct;
 use Magento\ImportExport\Helper\Data as ImportExportHelperData;
@@ -151,13 +152,20 @@ class AdvancedPricingTest extends AbstractImportTestCase
      */
     private $currencyResolver;
 
+    /**
+     * @var ObjectManager
+     */
+    protected $objectManager;
+
     /**
      * @inheritDoc
      */
     protected function setUp(): void
     {
         parent::setUp();
 
+        $this->objectManager = new ObjectManager($this);
+
         $this->jsonHelper = $this->createMock(Data::class);
         $this->importExportData = $this->createMock(ImportExportHelperData::class);
         $this->resourceHelper = $this->createMock(Helper::class);
@@ -302,7 +310,7 @@ public function testValidateRowValidatorCall(): void
                 'getWebSiteId'
             ]
         );
-        $this->setPropertyValue($advancedPricingMock, '_validatedRows', []);
+        $this->objectManager->setBackwardCompatibleProperty($advancedPricingMock, '_validatedRows', []);
         $this->validator->expects($this->once())->method('isValid')->willReturn(false);
         $messages = ['value'];
         $this->validator->expects($this->once())->method('getMessages')->willReturn($messages);
@@ -624,14 +632,17 @@ function ($arg1, $arg2) use ($expectedSkuList) {
      */
     public function testDeleteAdvancedPricingResetCachedSkuToDelete(): void
     {
-        $this->setPropertyValue($this->advancedPricing, '_cachedSkuToDelete', 'some value');
+        $this->objectManager->setBackwardCompatibleProperty($this->advancedPricing, '_cachedSkuToDelete', 'some value');
         $this->dataSourceModel
             ->method('getNextBunch')
             ->willReturnOnConsecutiveCalls([]);
 
         $this->advancedPricing->deleteAdvancedPricing();
 
-        $cachedSkuToDelete = $this->getPropertyValue($this->advancedPricing, '_cachedSkuToDelete');
+        $reflection = new \ReflectionClass($this->advancedPricing);
+        $property = $reflection->getProperty('_cachedSkuToDelete');
+        $property->setAccessible(true);
+        $cachedSkuToDelete = $property->getValue($this->advancedPricing);
         $this->assertNull($cachedSkuToDelete);
     }
 
@@ -1049,44 +1060,6 @@ public static function processCountExistingPricesDataProvider(): array
         ];
     }
 
-    /**
-     * Get any object property value.
-     *
-     * @param $object
-     * @param $property
-     *
-     * @return mixed
-     * @throws \ReflectionException
-     */
-    protected function getPropertyValue($object, $property)
-    {
-        $reflection = new ReflectionClass(get_class($object));
-        $reflectionProperty = $reflection->getProperty($property);
-        $reflectionProperty->setAccessible(true);
-
-        return $reflectionProperty->getValue($object);
-    }
-
-    /**
-     * Set object property value.
-     *
-     * @param $object
-     * @param $property
-     * @param $value
-     *
-     * @return mixed
-     * @throws \ReflectionException
-     */
-    protected function setPropertyValue(&$object, $property, $value)
-    {
-        $reflection = new ReflectionClass(get_class($object));
-        $reflectionProperty = $reflection->getProperty($property);
-        $reflectionProperty->setAccessible(true);
-        $reflectionProperty->setValue($object, $value);
-
-        return $object;
-    }
-
     /**
      * Invoke any method of class AdvancedPricing.
      *

lib/internal/Magento/Framework/TestFramework/Unit/Helper/ObjectManager.php

@@ -393,4 +393,27 @@ public function prepareObjectManager(array $map = [])
         $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($objectManagerMock, $objectManagerMock);
     }
+
+    /**
+     * Create a partial mock with reflection.
+     *
+     * @param string $className
+     * @param array $methods
+     * @return MockObject
+     */
+    public function createPartialMockWithReflection(string $className, array $methods): MockObject
+    {
+        $reflection = new \ReflectionClass($this->_testObject);
+        $getMockBuilderMethod = $reflection->getMethod('getMockBuilder');
+        $getMockBuilderMethod->setAccessible(true);
+        $mockBuilder = $getMockBuilderMethod->invoke($this->_testObject, $className);
+        
+        $builderReflection = new \ReflectionClass($mockBuilder);
+        $methodsProperty = $builderReflection->getProperty('methods');
+        $methodsProperty->setAccessible(true);
+        $methodsProperty->setValue($mockBuilder, $methods);
+        
+        $mockBuilder->disableOriginalConstructor();
+        return $mockBuilder->getMock();
+    }
 }