Update lib/internal/Magento/Framework/Encryption/Helper/Security.php

texboy · sivaschenko · web-flow · commit 590062a8b58a · 2021-06-18T09:12:04.000-03:00
Thanks! Great suggestion!

Co-authored-by: Sergii Ivashchenko &lt;serg.ivashchenko@gmail.com&gt;
diff --git a/lib/internal/Magento/Framework/Encryption/Helper/Security.php b/lib/internal/Magento/Framework/Encryption/Helper/Security.php
@@ -21,8 +21,6 @@ class Security
      */
     public static function compareStrings($expected, $actual)
     {
-        $expected     = (string) $expected;
-        $actual       = (string) $actual;
-        return hash_equals($expected, $actual);
+        return hash_equals((string) $expected, (string) $actual);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,6 @@ class Security`
`21`	`21`	`*/`
`22`	`22`	`public static function compareStrings($expected, $actual)`
`23`	`23`	`{`
`24`		`- $expected = (string) $expected;`
`25`		`- $actual = (string) $actual;`
`26`		`- return hash_equals($expected, $actual);`
	`24`	`+ return hash_equals((string) $expected, (string) $actual);`
`27`	`25`	`}`
`28`	`26`	`}`