ACP2E-3501: VAPT: Business Logic Error - future date as customer date of birth

Author: veloraven

app/code/Magento/Customer/Model/Validator/Dob.php

@@ -12,19 +12,19 @@
 use Magento\Store\Model\StoreManagerInterface;
 
 /**
- * Customer name fields validator.
+ * Customer dob field validator.
  */
 class Dob extends AbstractValidator
 {
     /**
      * @var \DateTime
      */
-    private $currentDate;
+    private \DateTime $currentDate;
 
    /**
     * @var StoreManagerInterface
     */
-    private $storeManager;
+    private StoreManagerInterface $storeManager;
 
     /**
      * @param StoreManagerInterface $storeManager
@@ -41,7 +41,7 @@ public function __construct(StoreManagerInterface $storeManager)
      * @param Customer $customer
      * @return bool
      */
-    public function isValid($customer)
+    public function isValid($customer): bool
     {
         if (!$this->isValidDob($customer->getDob(), $customer->getStoreId())) {
             parent::_addMessages([['dob' => 'The Date of Birth should not be greater than today.']]);
@@ -57,7 +57,7 @@ public function isValid($customer)
      * @param int $storeId
      * @return bool
      */
-    private function isValidDob($dobValue, $storeId)
+    private function isValidDob(?string $dobValue, int $storeId): bool
     {
         if ($dobValue != null) {
 

dev/tests/api-functional/testsuite/Magento/Customer/Api/AccountManagementTest.php

@@ -240,7 +240,9 @@ public function testCreateCustomerWithDateOfBirthInFuture()
             $this->customerHelper->createSampleCustomerDataObject(),
             \Magento\Customer\Api\Data\CustomerInterface::class
         );
-        $futureDob = '14-12-2044';
+        $date = new \DateTime();
+        $date->modify('+1 month');
+        $futureDob = $date->format('Y-m-d');
         $customerDataArray['dob'] = $futureDob;
         $requestData = ['customer' => $customerDataArray, 'password' => CustomerHelper::PASSWORD];
         try {