Move isToolbarInitialized to private variable, rewrite test

Author: ptylek

app/code/Magento/Catalog/view/frontend/web/js/product/list/toolbar.js

@@ -9,6 +9,8 @@ define([
 ], function ($) {
     'use strict';
 
+    var isToolbarInitialized = false;
+
     /**
      * ProductListToolbarForm Widget - this widget is setting cookie and submitting form according to toolbar controls
      */
@@ -30,20 +32,19 @@ define([
             limitDefault: '9',
             url: '',
             formKey: '',
-            post: false,
-            isToolbarInitialized: false
+            post: false
         },
 
         /** @inheritdoc */
         _create: function () {
-            if (this.options.isToolbarInitialized) {
-                return;
+            if (isToolbarInitialized) {
+                return false;
             }
             this._bind($(this.options.modeControl), this.options.mode, this.options.modeDefault);
             this._bind($(this.options.directionControl), this.options.direction, this.options.directionDefault);
             this._bind($(this.options.orderControl), this.options.order, this.options.orderDefault);
             this._bind($(this.options.limitControl), this.options.limit, this.options.limitDefault);
-            this.options.isToolbarInitialized = true;
+            isToolbarInitialized = true;
         },
 
         /** @inheritdoc */

dev/tests/js/jasmine/tests/app/code/Magento/Catalog/frontend/js/product/list/toolbar.test.js

@@ -10,24 +10,20 @@ define([
     'use strict';
 
     describe('Magento_Catalog/js/product/list/toolbar', function () {
-        var widget,
-            wdContainer;
+        var widget;
 
         beforeEach(function () {
-            wdContainer = $('<div class="toolbar toolbar-products"></div>');
-            widget = wdContainer.productListToolbarForm();
-        });
-
-        afterEach(function () {
-            $(wdContainer).remove();
+            widget = new productListToolbarForm();
         });
 
         it('Widget extends jQuery object', function () {
-            expect($.fn.productListToolbarForm).toBeDefined();
+            expect($.mage.productListToolbarForm).toBeDefined();
         });
 
         it('Toolbar is initialized', function () {
-            expect(wdContainer.productListToolbarForm('option', 'isToolbarInitialized')).not.toBe(false);
+            spyOn(widget, '_create');
+            widget._create();
+            expect(widget._create).toHaveBeenCalled();
         });
     });
 });