Fixed static test failures.

engcom-Echo · engcom-Echo · commit 6ab343b360d4 · 2024-06-18T11:24:16.000+05:30
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Totals/Tax.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Totals/Tax.php
@@ -80,11 +80,10 @@ public function getFullTaxInfo()
         }
 
         $taxClassAmount = [];
-        //phpcs:disable
-        if (empty($source)) {
+        if ($source == null) {
             return $taxClassAmount;
         }
-        //phpcs:enable
+
         $taxClassAmount = $this->_taxHelper->getCalculatedTaxes($source);
         if (empty($taxClassAmount)) {
             $rates = $this->_taxOrderFactory->create()->getCollection()->loadByOrder($this->getOrder())->toArray();
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/View/Messages.php b/app/code/Magento/Sales/Block/Adminhtml/Order/View/Messages.php
@@ -17,8 +17,6 @@
 class Messages extends \Magento\Framework\View\Element\Messages
 {
     /**
-     * Core registry
-     *
      * @var \Magento\Framework\Registry
      */
     protected $coreRegistry = null;

Original file line number	Diff line number	Diff line change
`@@ -80,11 +80,10 @@ public function getFullTaxInfo()`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`$taxClassAmount = [];`
`83`		`- //phpcs:disable`
`84`		`- if (empty($source)) {`
	`83`	`+ if ($source == null) {`
`85`	`84`	`return $taxClassAmount;`
`86`	`85`	`}`
`87`		`- //phpcs:enable`
	`86`	`+`
`88`	`87`	`$taxClassAmount = $this->_taxHelper->getCalculatedTaxes($source);`
`89`	`88`	`if (empty($taxClassAmount)) {`
`90`	`89`	`$rates = $this->_taxOrderFactory->create()->getCollection()->loadByOrder($this->getOrder())->toArray();`
Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,6 @@`
`17`	`17`	`class Messages extends \Magento\Framework\View\Element\Messages`
`18`	`18`	`{`
`19`	`19`	`/**`
`20`		`- * Core registry`
`21`		`- *`
`22`	`20`	`* @var \Magento\Framework\Registry`
`23`	`21`	`*/`
`24`	`22`	`protected $coreRegistry = null;`