Fix #27523: fix tests for phpunit9 and php7.4

korostii · korostii · commit 75bb2c3537b3 · 2020-07-09T23:01:25.000+03:00
diff --git a/app/code/Magento/Developer/Test/Unit/Console/Command/GeneratePatchCommandTest.php b/app/code/Magento/Developer/Test/Unit/Console/Command/GeneratePatchCommandTest.php
@@ -44,7 +44,7 @@ class GeneratePatchCommandTest extends TestCase
      */
     private $command;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->componentRegistrarMock = $this->createMock(ComponentRegistrar::class);
         $this->directoryListMock = $this->createMock(DirectoryList::class);
@@ -86,7 +86,7 @@ public function testExecute()
                 GeneratePatchCommand::INPUT_KEY_PATCH_NAME => 'SomePatch'
             ]
         );
-        $this->assertContains('successfully generated', $commandTester->getDisplay());
+        $this->assertStringContainsString('successfully generated', $commandTester->getDisplay());
     }
 
     public function testWrongParameter()

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ class GeneratePatchCommandTest extends TestCase`
`44`	`44`	`*/`
`45`	`45`	`private $command;`
`46`	`46`
`47`		`- protected function setUp()`
	`47`	`+ protected function setUp(): void`
`48`	`48`	`{`
`49`	`49`	`$this->componentRegistrarMock = $this->createMock(ComponentRegistrar::class);`
`50`	`50`	`$this->directoryListMock = $this->createMock(DirectoryList::class);`
`@@ -86,7 +86,7 @@ public function testExecute()`
`86`	`86`	`GeneratePatchCommand::INPUT_KEY_PATCH_NAME => 'SomePatch'`
`87`	`87`	`]`
`88`	`88`	`);`
`89`		`- $this->assertContains('successfully generated', $commandTester->getDisplay());`
	`89`	`+ $this->assertStringContainsString('successfully generated', $commandTester->getDisplay());`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`public function testWrongParameter()`