AC-15048::[CE] PHPUnit 12: Upgrade Search & Navigation related test cases | Test Case Improvements

Author: cod43156

app/code/Magento/Elasticsearch/Test/Unit/ElasticAdapter/Model/Adapter/FieldMapper/Product/FieldProvider/FieldType/Resolver/IntegerTypeTest.php

@@ -51,6 +51,11 @@ protected function setUp(): void
     }
 
     /**
+     * @param string $attributeCode
+     * @param bool $isIntegerType
+     * @param bool $isBooleanType
+     * @param string $expected
+     * @return void
      */
     #[DataProvider('getFieldTypeProvider')]
     public function testGetFieldType(

app/code/Magento/Elasticsearch/Test/Unit/ElasticAdapter/Model/Adapter/FieldMapper/Product/FieldProvider/FieldType/Resolver/KeywordTypeTest.php

@@ -51,6 +51,13 @@ protected function setUp(): void
     }
 
     /**
+     * @param bool $isComplexType
+     * @param bool $isSearchable
+     * @param bool $isAlwaysIndexable
+     * @param bool $isFilterable
+     * @param bool $isBoolean
+     * @param string $expected
+     * @return void
      */
     #[DataProvider('getFieldTypeProvider')]
     public function testGetFieldType(

app/code/Magento/Elasticsearch/Test/Unit/Model/Adapter/ElasticsearchTest.php

@@ -9,6 +9,7 @@
 
 use Elasticsearch\Client;
 use Elasticsearch\Namespaces\IndicesNamespace;
+use Elasticsearch\ClientBuilder;
 use Exception;
 use Magento\AdvancedSearch\Model\Client\ClientInterface as ElasticsearchClient;
 use Magento\AdvancedSearch\Model\Client\ClientOptionsInterface;
@@ -110,7 +111,7 @@ class ElasticsearchTest extends TestCase
      */
     protected function setUp(): void
     {
-        if (!class_exists(\Elasticsearch\ClientBuilder::class)) {
+        if (!class_exists(ClientBuilder::class)) {
             $this->markTestSkipped('AC-6597: Skipped as Elasticsearch 8 is configured');
         }
 

app/code/Magento/Elasticsearch/Test/Unit/Model/Adapter/FieldMapper/CopySearchableFieldsToSearchFieldTest.php

@@ -20,6 +20,8 @@ class CopySearchableFieldsToSearchFieldTest extends TestCase
     /**
      * Test "copy_to" parameter should be added to searchable fields.
      *
+     * @param array $mappingBefore
+     * @param array $mappingAfter
      */
     #[DataProvider('processDataProvider')]
     public function testProcess(array $mappingBefore, array $mappingAfter)

app/code/Magento/Elasticsearch/Test/Unit/Model/Adapter/FieldMapper/Product/AttributeAdapterTest.php

@@ -46,7 +46,7 @@ protected function setUp(): void
              'usesSource', 'setUsesSource', 'getCustomAttributes', 'setCustomAttributes',
              'getCustomAttribute', 'setCustomAttribute']
         );
-        
+
         // Create stateful mock data storage
         $data = [
             'isFilterable' => false,
@@ -57,7 +57,7 @@ protected function setUp(): void
             'frontendInput' => 'text',
             'usesSource' => false
         ];
-        
+
         $this->attribute->method('getIsFilterable')->willReturnCallback(function () use (&$data) {
             return $data['isFilterable'];
         });
@@ -121,6 +121,10 @@ protected function setUp(): void
     }
 
     /**
+     * @param $isFilterable
+     * @param $isFilterableInSearch
+     * @param $expected
+     * @return void
      */
     #[DataProvider('isFilterableProvider')]
     public function testIsFilterable($isFilterable, $isFilterableInSearch, $expected)
@@ -134,6 +138,12 @@ public function testIsFilterable($isFilterable, $isFilterableInSearch, $expected
     }
 
     /**
+     * @param $isSearchable
+     * @param $isVisibleInAdvancedSearch
+     * @param $isFilterable
+     * @param $isFilterableInSearch
+     * @param $expected
+     * @return void
      */
     #[DataProvider('isSearchableProvider')]
     public function testIsSearchable(
@@ -154,6 +164,8 @@ public function testIsSearchable(
     }
 
     /**
+     * @param $expected
+     * @return void
      */
     #[DataProvider('isAlwaysIndexableProvider')]
     public function testIsAlwaysIndexable($expected)
@@ -165,6 +177,9 @@ public function testIsAlwaysIndexable($expected)
     }
 
     /**
+     * @param $backendType
+     * @param $expected
+     * @return void
      */
     #[DataProvider('isDateTimeTypeProvider')]
     public function testIsDateTimeType($backendType, $expected)
@@ -177,6 +192,9 @@ public function testIsDateTimeType($backendType, $expected)
     }
 
     /**
+     * @param $backendType
+     * @param $expected
+     * @return void
      */
     #[DataProvider('isFloatTypeProvider')]
     public function testIsFloatType($backendType, $expected)
@@ -189,6 +207,9 @@ public function testIsFloatType($backendType, $expected)
     }
 
     /**
+     * @param $backendType
+     * @param $expected
+     * @return void
      */
     #[DataProvider('isIntegerTypeProvider')]
     public function testIsIntegerType($backendType, $expected)
@@ -201,6 +222,10 @@ public function testIsIntegerType($backendType, $expected)
     }
 
     /**
+     * @param $frontendInput
+     * @param $backendType
+     * @param $expected
+     * @return void
      */
     #[DataProvider('isBooleanTypeProvider')]
     public function testIsBooleanType($frontendInput, $backendType, $expected)

app/code/Magento/Elasticsearch/Test/Unit/Model/Adapter/FieldMapper/Product/FieldProvider/FieldName/Resolver/PriceTest.php

@@ -61,6 +61,10 @@ protected function setUp(): void
     }
 
     /**
+     * @param $attributeCode
+     * @param $context
+     * @param $expected
+     * @return void
      */
     #[DataProvider('getFieldNameProvider')]
     public function testGetFieldName($attributeCode, $context, $expected)

app/code/Magento/Elasticsearch/Test/Unit/Model/Adapter/FieldMapper/Product/FieldProvider/FieldName/Resolver/SpecialAttributeTest.php

@@ -38,6 +38,9 @@ protected function setUp(): void
     }
 
     /**
+     * @param $attributeCode
+     * @param $expected
+     * @return void
      */
     #[DataProvider('getFieldNameProvider')]
     public function testGetFieldName($attributeCode, $expected)

app/code/Magento/Elasticsearch/Test/Unit/Model/Adapter/FieldMapper/Product/FieldProvider/FieldType/ConverterTest.php

@@ -37,6 +37,9 @@ protected function setUp(): void
     }
 
     /**
+     * @param $internalType
+     * @param $expected
+     * @return void
      */
     #[DataProvider('convertProvider')]
     public function testConvert($internalType, $expected)

app/code/Magento/Elasticsearch/Test/Unit/Model/Adapter/FieldMapper/Product/FieldProvider/FieldType/Resolver/DateTimeTypeTest.php

@@ -50,6 +50,9 @@ protected function setUp(): void
     }
 
     /**
+     * @param $isDateTimeType
+     * @param $expected
+     * @return void
      */
     #[DataProvider('getFieldTypeProvider')]
     public function testGetFieldType($isDateTimeType, $expected)

app/code/Magento/Elasticsearch/Test/Unit/Model/Adapter/FieldMapper/Product/FieldProvider/FieldType/Resolver/DefaultResolverTest.php

@@ -50,6 +50,8 @@ protected function setUp(): void
     }
 
     /**
+     * @param $expected
+     * @return void
      */
     #[DataProvider('getFieldTypeProvider')]
     public function testGetFieldType($expected)