phpstan fixes.

Author: Bashev

lib/internal/Magento/Framework/Image/Adapter/AbstractAdapter.php

@@ -27,25 +27,25 @@ abstract class AbstractAdapter implements AdapterInterface
      * Position constants.
      * Used mainly for watermarks
      */
-    const POSITION_TOP_LEFT = 'top-left';
+    public const POSITION_TOP_LEFT = 'top-left';
 
-    const POSITION_TOP_RIGHT = 'top-right';
+    public const POSITION_TOP_RIGHT = 'top-right';
 
-    const POSITION_BOTTOM_LEFT = 'bottom-left';
+    public const POSITION_BOTTOM_LEFT = 'bottom-left';
 
-    const POSITION_BOTTOM_RIGHT = 'bottom-right';
+    public const POSITION_BOTTOM_RIGHT = 'bottom-right';
 
-    const POSITION_STRETCH = 'stretch';
+    public const POSITION_STRETCH = 'stretch';
 
-    const POSITION_TILE = 'tile';
+    public const POSITION_TILE = 'tile';
 
-    const POSITION_CENTER = 'center';
+    public const POSITION_CENTER = 'center';
     /**#@-*/
 
     /**
      * The size of the font to use as default
      */
-    const DEFAULT_FONT_SIZE = 15;
+    public const DEFAULT_FONT_SIZE = 15;
 
     /**
      * @var  int
@@ -274,8 +274,7 @@ abstract public function getColorAt($x, $y);
      */
     public function __construct(
         \Magento\Framework\Filesystem $filesystem,
-        \Psr\Log\LoggerInterface $logger,
-        array $data = []
+        \Psr\Log\LoggerInterface $logger
     ) {
         $this->_filesystem = $filesystem;
         $this->logger = $logger;
@@ -622,10 +621,7 @@ protected function _checkAspectRatio($frameWidth, $frameHeight)
      */
     protected function _checkDimensions($frameWidth, $frameHeight)
     {
-        if ($frameWidth !== null && $frameWidth <= 0 ||
-            $frameHeight !== null && $frameHeight <= 0 ||
-            empty($frameWidth) && empty($frameHeight)
-        ) {
+        if ($frameWidth !== null && $frameWidth <= 0 || $frameHeight !== null && $frameHeight <= 0) {
             //phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new \InvalidArgumentException('Invalid image dimensions.');
         }