magento2-login-as-customer/issues/154: LoginAsCustomer API/extension points refactoring

Author: naydav

app/code/Magento/LoginAsCustomerAdminUi/Block/Adminhtml/ConfirmationPopup.php

@@ -7,10 +7,10 @@
 
 namespace Magento\LoginAsCustomerAdminUi\Block\Adminhtml;
 
-use Magento\Framework\Serialize\Serializer\Json;
-use Magento\Store\Ui\Component\Listing\Column\Store\Options as StoreOptions;
 use Magento\Backend\Block\Template;
+use Magento\Framework\Serialize\Serializer\Json;
 use Magento\LoginAsCustomerApi\Api\ConfigInterface;
+use Magento\Store\Ui\Component\Listing\Column\Store\Options as StoreOptions;
 
 /**
  * Login confirmation pop-up
@@ -77,15 +77,13 @@ public function getJsLayout()
     }
 
     /**
-     * Render block HTML
-     *
-     * @return string
+     * @inheritdoc
      */
-    protected function _toHtml()
+    public function toHtml()
     {
         if (!$this->config->isEnabled()) {
             return '';
         }
-        return parent::_toHtml();
+        return parent::toHtml();
     }
 }

app/code/Magento/LoginAsCustomerAdminUi/composer.json

@@ -5,10 +5,14 @@
         "php": "~7.3.0||~7.4.0",
         "magento/framework": "*",
         "magento/module-login-as-customer-api": "*",
+        "magento/module-login-as-customer-frontend-ui": "*",
         "magento/module-backend": "*",
         "magento/module-customer": "*",
         "magento/module-store": "*"
     },
+    "suggest": {
+        "magento/module-login-as-customer": "*"
+    },
     "type": "magento2-module",
     "license": [
         "OSL-3.0",

app/code/Magento/LoginAsCustomerFrontendUi/CustomerData/LoginAsCustomerUi.php

@@ -17,7 +17,7 @@
  *
  * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  */
-class LoginAsCustomerFrontendUi implements SectionSourceInterface
+class LoginAsCustomerUi implements SectionSourceInterface
 {
     /**
      * @var Session

app/code/Magento/LoginAsCustomerFrontendUi/etc/frontend/di.xml

@@ -9,7 +9,7 @@
     <type name="Magento\Customer\CustomerData\SectionPoolInterface">
         <arguments>
             <argument name="sectionSourceMap" xsi:type="array">
-                <item name="loggedAsCustomer" xsi:type="string">Magento\LoginAsCustomerFrontendUi\CustomerData\LoginAsCustomerFrontendUi</item>
+                <item name="loggedAsCustomer" xsi:type="string">Magento\LoginAsCustomerFrontendUi\CustomerData\LoginAsCustomerUi</item>
             </argument>
         </arguments>
     </type>