ACP2E-2266: added test coverage

Author: alzota

dev/tests/integration/testsuite/Magento/Catalog/Controller/ProductTest.php

@@ -10,8 +10,13 @@
 use Magento\Catalog\Api\Data\ProductInterface;
 use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Catalog\Model\Session;
+use Magento\Catalog\Test\Fixture\Category;
+use Magento\Catalog\Test\Fixture\Product;
 use Magento\Framework\Registry;
 use Magento\TestFramework\Catalog\Model\ProductLayoutUpdateManager;
+use Magento\TestFramework\Fixture\DataFixture;
+use Magento\TestFramework\Fixture\DataFixtureStorage;
+use Magento\TestFramework\Fixture\DataFixtureStorageManager;
 use Magento\TestFramework\Helper\Bootstrap;
 use Magento\TestFramework\Helper\Xpath;
 use Magento\TestFramework\TestCase\AbstractController;
@@ -34,6 +39,11 @@ class ProductTest extends AbstractController
     /** @var Session */
     private $session;
 
+    /**
+     * @var DataFixtureStorage
+     */
+    private $fixture;
+
     /**
      * @inheritdoc
      */
@@ -53,6 +63,7 @@ protected function setUp(): void
         $this->registry = $this->_objectManager->get(Registry::class);
         $this->productRepository = $this->_objectManager->get(ProductRepositoryInterface::class);
         $this->session = $this->_objectManager->get(Session::class);
+        $this->fixture = DataFixtureStorageManager::getStorage();
     }
 
     /**
@@ -255,4 +266,33 @@ public function testViewWithCustomUpdate(): void
             ->getHandles();
         $this->assertContains("catalog_product_view_selectable_{$sku}_{$file}", $handles);
     }
+
+    #[
+        DataFixture(Category::class, as: 'category'),
+        DataFixture(
+            Product::class,
+            ['category_ids' => ['$category.id$'], 'short_description' => 'Product Short Description'],
+            as: 'product'
+        )
+    ]
+    public function testItempropOnProductPage()
+    {
+        $product = $this->fixture->get('product');
+        $this->dispatch(sprintf('catalog/product/view/id/%s', $product->getEntityId()));
+        $html = $this->getResponse()->getBody();
+        $this->assertEquals(
+            1,
+            Xpath::getElementsCountForXpath(
+                '//*[@itemprop="image"]',
+                $html
+            )
+        );
+        $this->assertEquals(
+            1,
+            Xpath::getElementsCountForXpath(
+                '//*[@itemprop="description"]',
+                $html
+            )
+        );
+    }
 }

dev/tests/js/jasmine/tests/lib/mage/gallery/gallery.test.js

@@ -101,7 +101,7 @@ define([
             expect(gallery.settings.api).toBeDefined();
             expect(gallery.settings.activeBreakpoint).toEqual({});
             expect(gallery.config.options.height).toEqual(element.height());
-            expect(gallery.settings.$elementF.find('.fotorama__stage__frame.fotorama__active img')).toBeDefined();
+            expect(gallery.settings.$elementF.find('img[itemprop]')).toBeDefined();
 
             $.fn.data = originSpy;
         });