MC-42026: [Cloud] Custom theme is not applied and the default LUMA theme is used.

Author: thiaramus

app/code/Magento/Deploy/Process/Queue.php

@@ -46,6 +46,11 @@ class Queue
      */
     private $inProgress = [];
 
+    /**
+     * @var Package[]
+     */
+    private $failed = [];
+
     /**
      * @var int
      */
@@ -193,8 +198,13 @@ public function process()
 
         $this->awaitForAllProcesses();
 
-        if (!empty($packages)) {
-            throw new TimeoutException('Not all packages are deployed.');
+        $failedPackages = array_merge($this->failed, $packages);
+        if (!empty($failedPackages)) {
+            throw new \RuntimeException(
+                'The following packages have failed to deploy '
+                .PHP_EOL
+                .implode(PHP_EOL, array_keys($failedPackages))
+            );
         }
 
         return $returnStatus;
@@ -280,9 +290,7 @@ private function awaitForAllProcesses()
                 $isDeployed = $this->isDeployed($package);
 
                 if ($isDeployed === false) {
-                    throw new \RuntimeException(
-                        "Deploy of the package " . $package->getPath() . " has failed."
-                    );
+                    $this->failed[$package->getPath()]= $this->packages[$package->getPath()];
                 } elseif ($isDeployed) {
                     unset($this->inProgress[$name]);
                 }
@@ -363,9 +371,7 @@ function () use ($package) {
         } else {
             $isDeployed = $this->deployPackageService->deploy($package, $this->options);
             if ($isDeployed === false) {
-                throw new \RuntimeException(
-                    "Deploy of the package " . $package->getPath() . " has failed."
-                );
+                $this->failed[$package->getPath()]= $this->packages[$package->getPath()];
             }
             return $isDeployed;
         }

app/code/Magento/Deploy/Process/TimeoutException.php

@@ -99,10 +99,6 @@ public function deploy(Package $package, array $options, $skipLogging = false)
             function () use ($package, $options, $skipLogging) {
                 // emulate application locale needed for correct file path resolving
                 $this->localeResolver->setLocale($package->getLocale());
-                /**
-                 * \Magento\Framework\App\State::emulateAreaCode was returning the result of this
-                 * anonymous function, and the result wasn't provided
-                 */
                 return $this->deployEmulated($package, $options, $skipLogging);
             }
         );
@@ -154,7 +150,7 @@ public function deployEmulated(Package $package, array $options, $skipLogging =
         foreach ($package->getPostProcessors() as $processor) {
             $processor->process($package, $options);
         }
-        // $this->errorsCount was counted but never checked in the end. Return was always true.
+
         return !(bool)$this->errorsCount;
     }