removed static failures

Author: del02433

app/code/Magento/Catalog/Model/Indexer/Category/Product/Action/Full.php

@@ -205,7 +205,7 @@ protected function reindex(): void
     private function reindexStore($store): void
     {
         // Ensure the same adapter instance that created the TEMP table is used for all operations
-        $this->connection = $this->tableMaintainer->getWriteConnection();
+        $this->connection = $this->tableMaintainer->getConnection();
         $this->reindexRootCategory($store);
         $this->reindexAnchorCategories($store);
         $this->reindexNonAnchorCategories($store);

app/code/Magento/Catalog/Model/Indexer/Category/Product/TableMaintainer.php

@@ -35,11 +35,15 @@ class TableMaintainer
 
     /**
      * Catalog tmp category index table name
+     *
+     * @var string
      */
     private $tmpTableSuffix = '_tmp';
 
     /**
      * Catalog tmp category index table name
+     *
+     * @var string
      */
     private $additionalTableSuffix = '_replica';
 
@@ -65,25 +69,14 @@ public function __construct(
      *
      * @return AdapterInterface
      */
-    private function getConnection()
+    public function getConnection()
     {
         if (!isset($this->connection)) {
             $this->connection = $this->resource->getConnection();
         }
         return $this->connection;
     }
 
-    /**
-     * Expose write connection so callers can use the same adapter instance
-     * that created temporary tables.
-     *
-     * @return AdapterInterface
-     */
-    public function getWriteConnection(): AdapterInterface
-    {
-        return $this->getConnection();
-    }
-
     /**
      * Return validated table name
      *
@@ -131,7 +124,7 @@ private function dropTable($tableName)
     /**
      * Return main index table name
      *
-     * @param $storeId
+     * @param int $storeId
      *
      * @return string
      */
@@ -145,7 +138,7 @@ public function getMainTable(int $storeId)
     /**
      * Create main and replica index tables for store
      *
-     * @param $storeId
+     * @param int $storeId
      *
      * @return void
      *
@@ -172,7 +165,7 @@ public function createTablesForStore(int $storeId)
     /**
      * Drop main and replica index tables for store
      *
-     * @param $storeId
+     * @param int $storeId
      *
      * @return void
      */
@@ -188,7 +181,7 @@ public function dropTablesForStore(int $storeId)
     /**
      * Return replica index table name
      *
-     * @param $storeId
+     * @param int $storeId
      *
      * @return string
      */
@@ -200,7 +193,7 @@ public function getMainReplicaTable(int $storeId)
     /**
      * Create temporary index table for store
      *
-     * @param $storeId
+     * @param int $storeId
      *
      * @return void
      */
@@ -217,7 +210,7 @@ public function createMainTmpTable(int $storeId)
     /**
      * Return temporary index table name
      *
-     * @param $storeId
+     * @param int $storeId
      *
      * @return string
      *