AC-15635: PHPUnit 12 Upgrade | Fix Static Failure

manishranjan-adobe · manishranjan-adobe · commit 9a8de22f552f · 2025-10-28T19:51:01.000+05:30
diff --git a/app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Import/AdvancedPricing/Validator/TierPriceTest.php b/app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Import/AdvancedPricing/Validator/TierPriceTest.php
@@ -75,12 +75,7 @@ public function testInitInternalCalls()
     {
         $searchCriteria = $this->createMock(SearchCriteria::class);
         $this->searchCriteriaBuilder->method('create')->willReturn($searchCriteria);
-        $groupSearchResult = $this->createMock(
-            GroupSearchResultsInterface::class,
-            [],
-            '',
-            false
-        );
+        $groupSearchResult = $this->createMock(GroupSearchResultsInterface::class);
         $this->groupRepository
             ->method('getList')
             ->with($searchCriteria)
@@ -99,12 +94,7 @@ public function testInitAddToCustomerGroups()
     {
         $searchCriteria = $this->createMock(SearchCriteria::class);
         $this->searchCriteriaBuilder->method('create')->willReturn($searchCriteria);
-        $groupSearchResult = $this->createMock(
-            GroupSearchResultsInterface::class,
-            [],
-            '',
-            false
-        );
+        $groupSearchResult = $this->createMock(GroupSearchResultsInterface::class);
         $this->groupRepository
             ->method('getList')
             ->with($searchCriteria)
@@ -166,12 +156,7 @@ public function testIsValidAddMessagesCall($value, $hasEmptyColumns, $customerGr
 
         $searchCriteria = $this->createMock(SearchCriteria::class);
         $this->searchCriteriaBuilder->method('create')->willReturn($searchCriteria);
-        $groupSearchResult = $this->createMock(
-            GroupSearchResultsInterface::class,
-            [],
-            '',
-            false
-        );
+        $groupSearchResult = $this->createMock(GroupSearchResultsInterface::class);
         $this->groupRepository
             ->method('getList')
             ->with($searchCriteria)
diff --git a/app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Import/AdvancedPricing/ValidatorTest.php b/app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Import/AdvancedPricing/ValidatorTest.php
@@ -32,12 +32,7 @@ class ValidatorTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->validatorTest = $this->createMock(
-            RowValidatorInterface::class,
-            [],
-            '',
-            false
-        );
+        $this->validatorTest = $this->createMock(RowValidatorInterface::class);
         $messages = ['messages'];
         $this->validatorTest->method('getMessages')->willReturn($messages);
         $this->validators = [$this->validatorTest];
diff --git a/app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Import/AdvancedPricingTest.php b/app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Import/AdvancedPricingTest.php
@@ -162,12 +162,7 @@ protected function setUp(): void
         $this->importExportData = $this->createMock(ImportExportHelperData::class);
         $this->resourceHelper = $this->createMock(Helper::class);
         $this->resource = $this->createPartialMock(ResourceConnection::class, ['getConnection']);
-        $this->connection = $this->createMock(
-            AdapterInterface::class,
-            [],
-            '',
-            false
-        );
+        $this->connection = $this->createMock(AdapterInterface::class);
         $this->resource->method('getConnection')->willReturn($this->connection);
         $this->dataSourceModel = $this->createMock(ResourceImportData::class);
         $entityType = $this->createMock(Type::class);
diff --git a/app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Indexer/Product/Price/Plugin/ImportTest.php b/app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Indexer/Product/Price/Plugin/ImportTest.php
@@ -39,12 +39,7 @@ class ImportTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->indexer = $this->createMock(
-            IndexerInterface::class,
-            [],
-            '',
-            false
-        );
+        $this->indexer = $this->createMock(IndexerInterface::class);
         $this->indexerRegistry = $this->createMock(
             IndexerRegistry::class
         );
diff --git a/app/code/Magento/AdvancedSearch/Test/Unit/Model/Indexer/Fulltext/Plugin/CustomerGroupTest.php b/app/code/Magento/AdvancedSearch/Test/Unit/Model/Indexer/Fulltext/Plugin/CustomerGroupTest.php
@@ -55,15 +55,7 @@ protected function setUp(): void
         $this->customerOptionsMock = $this->createMock(
             ClientOptionsInterface::class
         );
-        $this->indexerMock = $this->createMock(
-            IndexerInterface::class,
-            [],
-            '',
-            false,
-            false,
-            true,
-            ['getId', 'getState', '__wakeup']
-        );
+        $this->indexerMock = $this->createMock(IndexerInterface::class);
         $this->indexerRegistryMock = $this->createPartialMock(
             IndexerRegistry::class,
             ['get']
diff --git a/app/code/Magento/Catalog/Test/Unit/Helper/AbstractCollectionTestHelper.php b/app/code/Magento/Catalog/Test/Unit/Helper/AbstractCollectionTestHelper.php
@@ -49,4 +49,3 @@ protected function _construct(): void
         // Mock implementation
     }
 }
-
diff --git a/app/code/Magento/Catalog/Test/Unit/Helper/AttributeResourceModelTestHelper.php b/app/code/Magento/Catalog/Test/Unit/Helper/AttributeResourceModelTestHelper.php
@@ -49,4 +49,3 @@ protected function _construct(): void
         // Mock implementation
     }
 }
-
diff --git a/app/code/Magento/Catalog/Test/Unit/Helper/CategoryInterfaceTestHelper.php b/app/code/Magento/Catalog/Test/Unit/Helper/CategoryInterfaceTestHelper.php
@@ -12,7 +12,7 @@
 
 /**
  * Mock class for CategoryInterface with additional methods
- * 
+ *
  * @SuppressWarnings(PHPMD.UnusedFormalParameter)
  */
 class CategoryInterfaceTestHelper implements CategoryInterface, CustomAttributesDataInterface
@@ -31,7 +31,7 @@ class CategoryInterfaceTestHelper implements CategoryInterface, CustomAttributes
      * Mock method for getResource
      *
      * @return mixed
-    */
+     */
     public function getResource()
     {
         return $this->resource;
@@ -53,7 +53,7 @@ public function setResource($resource)
      * Mock method for getIsAnchor
      *
      * @return mixed
-    */
+     */
     public function getIsAnchor()
     {
         return $this->isAnchor;
diff --git a/app/code/Magento/Catalog/Test/Unit/Helper/FilterItemTestHelper.php b/app/code/Magento/Catalog/Test/Unit/Helper/FilterItemTestHelper.php
@@ -87,4 +87,3 @@ protected function _construct(): void
         // Mock implementation
     }
 }
-
diff --git a/app/code/Magento/Catalog/Test/Unit/Helper/PriceDataProviderTestHelper.php b/app/code/Magento/Catalog/Test/Unit/Helper/PriceDataProviderTestHelper.php
@@ -65,4 +65,3 @@ protected function _construct(): void
         // Mock implementation
     }
 }
-
diff --git a/app/code/Magento/Catalog/Test/Unit/Helper/ProductCollectionTestHelper.php b/app/code/Magento/Catalog/Test/Unit/Helper/ProductCollectionTestHelper.php
@@ -63,4 +63,3 @@ protected function _construct(): void
         // Mock implementation
     }
 }
-
diff --git a/app/code/Magento/Catalog/Test/Unit/Helper/ProductTestHelper.php b/app/code/Magento/Catalog/Test/Unit/Helper/ProductTestHelper.php
@@ -18,7 +18,7 @@ class ProductTestHelper extends Product
      * Mock method for getUrlKey
      *
      * @return string|null
-    */
+     */
     public function getUrlKey()
     {
         return $this->getData('url_key');
diff --git a/app/code/Magento/CatalogImportExport/Test/Unit/Helper/ResourceFactoryTestHelper.php b/app/code/Magento/CatalogImportExport/Test/Unit/Helper/ResourceFactoryTestHelper.php
@@ -65,4 +65,4 @@ public function create(array $data = [])
     {
         return $this;
     }
-}
+}
diff --git a/app/code/Magento/CatalogSearch/Test/Unit/Helper/EngineInterfaceTestHelper.php b/app/code/Magento/CatalogSearch/Test/Unit/Helper/EngineInterfaceTestHelper.php
@@ -11,7 +11,7 @@
 
 /**
  * Mock class for EngineInterface with additional methods
- * 
+ *
  * @SuppressWarnings(PHPMD.UnusedFormalParameter)
  */
 class EngineInterfaceTestHelper implements EngineInterface
diff --git a/app/code/Magento/CatalogSearch/Test/Unit/Helper/RequestTestHelper.php b/app/code/Magento/CatalogSearch/Test/Unit/Helper/RequestTestHelper.php
@@ -14,6 +14,11 @@
  */
 class RequestTestHelper extends Request
 {
+    /**
+     * @var mixed
+     */
+    private $queryValue;
+
     /**
      * Mock method for getQueryValue
      *
diff --git a/app/code/Magento/CatalogSearch/Test/Unit/Helper/SearchCriteriaBuilderTestHelper.php b/app/code/Magento/CatalogSearch/Test/Unit/Helper/SearchCriteriaBuilderTestHelper.php
@@ -25,7 +25,7 @@ class SearchCriteriaBuilderTestHelper extends SearchCriteriaBuilder
      *
      * @param string $requestName
      * @return $this
-    */
+     */
     public function setRequestName($requestName)
     {
         $this->requestName = $requestName;
@@ -36,7 +36,7 @@ public function setRequestName($requestName)
      * Get the request name
      *
      * @return string|null
-    */
+     */
     public function getRequestName()
     {
         return $this->requestName;
diff --git a/app/code/Magento/CatalogSearch/Test/Unit/Model/Indexer/Fulltext/Plugin/AttributeTest.php b/app/code/Magento/CatalogSearch/Test/Unit/Model/Indexer/Fulltext/Plugin/AttributeTest.php
@@ -71,15 +71,7 @@ protected function setUp(): void
     {
         $this->objectManager = new ObjectManager($this);
         $this->subjectMock = $this->createMock(\Magento\Catalog\Model\ResourceModel\Attribute::class);
-        $this->indexerMock = $this->createMock(
-            IndexerInterface::class,
-            [],
-            '',
-            false,
-            false,
-            true,
-            ['getId', 'getState', '__wakeup']
-        );
+        $this->indexerMock = $this->createMock(IndexerInterface::class);
         $this->indexerRegistryMock = $this->createPartialMock(
             IndexerRegistry::class,
             ['get']
diff --git a/app/code/Magento/Eav/Test/Unit/Helper/AttributeTestHelper.php b/app/code/Magento/Eav/Test/Unit/Helper/AttributeTestHelper.php
@@ -75,4 +75,3 @@ protected function _construct(): void
         // Mock implementation
     }
 }
-
diff --git a/app/code/Magento/GraphQl/Test/Unit/Helper/ContextExtensionTestHelper.php b/app/code/Magento/GraphQl/Test/Unit/Helper/ContextExtensionTestHelper.php
@@ -40,4 +40,4 @@ public function setStore($store)
         $this->store = $store;
         return $this;
     }
-}
+}
diff --git a/app/code/Magento/Search/Test/Unit/Helper/ItemTestHelper.php b/app/code/Magento/Search/Test/Unit/Helper/ItemTestHelper.php
@@ -75,4 +75,3 @@ protected function _construct(): void
         // Mock implementation
     }
 }
-
diff --git a/app/code/Magento/Store/Test/Unit/Helper/StoreInterfaceTestHelper.php b/app/code/Magento/Store/Test/Unit/Helper/StoreInterfaceTestHelper.php
@@ -45,4 +45,3 @@ protected function _construct()
         // Mock implementation - no actual resource initialization needed
     }
 }
-
diff --git a/app/code/Magento/Store/Test/Unit/Helper/StoreManagerInterfaceTestHelper.php b/app/code/Magento/Store/Test/Unit/Helper/StoreManagerInterfaceTestHelper.php
@@ -15,7 +15,7 @@
 
 /**
  * Mock class for StoreManagerInterface with all required methods
- * 
+ *
  * @SuppressWarnings(PHPMD.UnusedFormalParameter)
  */
 class StoreManagerInterfaceTestHelper implements StoreManagerInterface
@@ -25,7 +25,7 @@ class StoreManagerInterfaceTestHelper implements StoreManagerInterface
      *
      * @param bool $value
      * @return void
-    */
+     */
     public function setIsSingleStoreModeAllowed($value): void
     {
         // Mock implementation
@@ -35,7 +35,7 @@ public function setIsSingleStoreModeAllowed($value): void
      * Mock method for hasSingleStore
      *
      * @return bool
-    */
+     */
     public function hasSingleStore(): bool
     {
         return false;
@@ -45,7 +45,7 @@ public function hasSingleStore(): bool
      * Mock method for isSingleStoreMode
      *
      * @return bool
-    */
+     */
     public function isSingleStoreMode(): bool
     {
         return false;
@@ -57,7 +57,7 @@ public function isSingleStoreMode(): bool
      * @param null|string|bool|int|StoreInterface $storeId
      * @return StoreInterface
      * @throws NoSuchEntityException
-    */
+     */
     public function getStore($storeId = null): StoreInterface
     {
         // Return a mock store - this would need to be properly mocked in tests
@@ -70,7 +70,7 @@ public function getStore($storeId = null): StoreInterface
      * @param bool $withDefault
      * @param bool $codeKey
      * @return StoreInterface[]
-    */
+     */
     public function getStores($withDefault = false, $codeKey = false): array
     {
         return [];
@@ -82,7 +82,7 @@ public function getStores($withDefault = false, $codeKey = false): array
      * @param null|bool|int|string|WebsiteInterface $websiteId
      * @return WebsiteInterface
      * @throws \Magento\Framework\Exception\LocalizedException
-    */
+     */
     public function getWebsite($websiteId = null): WebsiteInterface
     {
         // Return a mock website - this would need to be properly mocked in tests
@@ -95,7 +95,7 @@ public function getWebsite($websiteId = null): WebsiteInterface
      * @param bool $withDefault
      * @param bool $codeKey
      * @return WebsiteInterface[]
-    */
+     */
     public function getWebsites($withDefault = false, $codeKey = false): array
     {
         return [];
@@ -105,7 +105,7 @@ public function getWebsites($withDefault = false, $codeKey = false): array
      * Mock method for reinitStores
      *
      * @return void
-    */
+     */
     public function reinitStores(): void
     {
         // Mock implementation
@@ -115,7 +115,7 @@ public function reinitStores(): void
      * Mock method for getDefaultStoreView
      *
      * @return StoreInterface|null
-    */
+     */
     public function getDefaultStoreView(): ?StoreInterface
     {
         return null;
@@ -158,4 +158,3 @@ public function setCurrentStore($store): void
         // Mock implementation
     }
 }
-
diff --git a/app/code/Magento/Theme/Test/Unit/Helper/PagerTestHelper.php b/app/code/Magento/Theme/Test/Unit/Helper/PagerTestHelper.php
@@ -54,4 +54,4 @@ public function setTotalLimit($limit)
     {
         return $this->setData('total_limit', $limit);
     }
-}
+}
diff --git a/app/code/Magento/UrlRewrite/Test/Unit/Helper/UrlFinderInterfaceTestHelper.php b/app/code/Magento/UrlRewrite/Test/Unit/Helper/UrlFinderInterfaceTestHelper.php
@@ -39,4 +39,3 @@ public function findAllByData(array $data): array
         return [];
     }
 }
-
diff --git a/app/code/Magento/UrlRewrite/Test/Unit/Helper/UrlRewriteTestHelper.php b/app/code/Magento/UrlRewrite/Test/Unit/Helper/UrlRewriteTestHelper.php
@@ -63,4 +63,3 @@ protected function _construct(): void
         // Mock implementation
     }
 }
-
diff --git a/lib/internal/Magento/Framework/Data/Test/Unit/Helper/TextTestHelper.php b/lib/internal/Magento/Framework/Data/Test/Unit/Helper/TextTestHelper.php
@@ -108,4 +108,3 @@ public function getForm()
         return $this->form;
     }
 }
-
diff --git a/lib/internal/Magento/Framework/EntityManager/Test/Unit/Helper/MetadataPoolTestHelper.php b/lib/internal/Magento/Framework/EntityManager/Test/Unit/Helper/MetadataPoolTestHelper.php
@@ -13,6 +13,8 @@
 /**
  * TestHelper for MetadataPool
  * Provides implementation for MetadataPool with additional test methods
+ *
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
  */
 class MetadataPoolTestHelper extends MetadataPool
 {
diff --git a/lib/internal/Magento/Framework/Event/Test/Unit/Helper/EventTestHelper.php b/lib/internal/Magento/Framework/Event/Test/Unit/Helper/EventTestHelper.php
@@ -54,4 +54,3 @@ public function getProduct()
         return $this->getData('product');
     }
 }
-
diff --git a/lib/internal/Magento/Framework/Event/Test/Unit/Helper/ObserverTestHelper.php b/lib/internal/Magento/Framework/Event/Test/Unit/Helper/ObserverTestHelper.php
@@ -24,4 +24,3 @@ public function getCategory()
         return $this->getData('category');
     }
 }
-
diff --git a/lib/internal/Magento/Framework/Model/Test/Unit/Helper/AbstractResourceTestHelper.php b/lib/internal/Magento/Framework/Model/Test/Unit/Helper/AbstractResourceTestHelper.php
@@ -13,6 +13,8 @@
 /**
  * TestHelper for AbstractResource
  * Provides implementation for AbstractResource with additional test methods
+ *
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
  */
 class AbstractResourceTestHelper extends AbstractResource
 {
diff --git a/lib/internal/Magento/Framework/Stdlib/Test/Unit/Helper/DateTimeTestHelper.php b/lib/internal/Magento/Framework/Stdlib/Test/Unit/Helper/DateTimeTestHelper.php
@@ -34,4 +34,3 @@ public function setFormatValue($value)
         return $this;
     }
 }
-
diff --git a/lib/internal/Magento/Framework/Test/Unit/Helper/AbstractBlockTestHelper.php b/lib/internal/Magento/Framework/Test/Unit/Helper/AbstractBlockTestHelper.php
diff --git a/lib/internal/Magento/Framework/Test/Unit/Helper/AbstractElementTestHelper.php b/lib/internal/Magento/Framework/Test/Unit/Helper/AbstractElementTestHelper.php
diff --git a/lib/internal/Magento/Framework/Test/Unit/Helper/CollectionTestHelper.php b/lib/internal/Magento/Framework/Test/Unit/Helper/CollectionTestHelper.php
diff --git a/lib/internal/Magento/Framework/Test/Unit/Helper/DateTimeTestHelper.php b/lib/internal/Magento/Framework/Test/Unit/Helper/DateTimeTestHelper.php
diff --git a/lib/internal/Magento/Framework/Test/Unit/Helper/IndexerInterfaceTestHelper.php b/lib/internal/Magento/Framework/Test/Unit/Helper/IndexerInterfaceTestHelper.php
diff --git a/lib/internal/Magento/Framework/Test/Unit/Helper/LayoutTestHelper.php b/lib/internal/Magento/Framework/Test/Unit/Helper/LayoutTestHelper.php
diff --git a/lib/internal/Magento/Framework/Test/Unit/Helper/QueryInterfaceTestHelper.php b/lib/internal/Magento/Framework/Test/Unit/Helper/QueryInterfaceTestHelper.php
diff --git a/lib/internal/Magento/Framework/View/Element/Test/Unit/Helper/BlockInterfaceTestHelper.php b/lib/internal/Magento/Framework/View/Element/Test/Unit/Helper/BlockInterfaceTestHelper.php

Original file line number	Diff line number	Diff line change
`@@ -49,4 +49,3 @@ protected function _construct(): void`
`49`	`49`	`// Mock implementation`
`50`	`50`	`}`
`51`	`51`	`}`
`52`		`-`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`
`13`	`13`	`/**`
`14`	`14`	`* Mock class for CategoryInterface with additional methods`
`15`		`- *`
	`15`	`+ *`
`16`	`16`	`* @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`17`	`17`	`*/`
`18`	`18`	`class CategoryInterfaceTestHelper implements CategoryInterface, CustomAttributesDataInterface`
`@@ -31,7 +31,7 @@ class CategoryInterfaceTestHelper implements CategoryInterface, CustomAttributes`
`31`	`31`	`* Mock method for getResource`
`32`	`32`	`*`
`33`	`33`	`* @return mixed`
`34`		`- */`
	`34`	`+ */`
`35`	`35`	`public function getResource()`
`36`	`36`	`{`
`37`	`37`	`return $this->resource;`
`@@ -53,7 +53,7 @@ public function setResource($resource)`
`53`	`53`	`* Mock method for getIsAnchor`
`54`	`54`	`*`
`55`	`55`	`* @return mixed`
`56`		`- */`
	`56`	`+ */`
`57`	`57`	`public function getIsAnchor()`
`58`	`58`	`{`
`59`	`59`	`return $this->isAnchor;`
Original file line number	Diff line number	Diff line change
`@@ -87,4 +87,3 @@ protected function _construct(): void`
`87`	`87`	`// Mock implementation`
`88`	`88`	`}`
`89`	`89`	`}`
`90`		`-`
Original file line number	Diff line number	Diff line change
`@@ -65,4 +65,3 @@ protected function _construct(): void`
`65`	`65`	`// Mock implementation`
`66`	`66`	`}`
`67`	`67`	`}`
`68`		`-`