ACP2E-2204: Price indexing performance gradually degrades overtime

- fixed static

Author: aplapana

app/code/Magento/Catalog/Test/Unit/Model/Indexer/Product/Price/CustomOptionPriceModifierTest.php

@@ -92,7 +92,7 @@ public function testModifyPrice(): void
         $connection->expects($this->exactly(2))->method('delete');
         $connection->expects($this->any())->method('select')->willReturn($select);
         $connection->expects($this->any())->method('fetchRow')->willReturn(['exists']);
-        $connection->expects($this->exactly(2))->method('truncate');
+        $connection->expects($this->exactly(2))->method('truncateTable');
         $this->resource->expects($this->any())->method('getConnection')->willReturn($connection);
         $this->resource->expects($this->any())->method('getTableName')->willReturn('table');
         $this->tableStrategy->expects($this->any())

lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php

@@ -2729,12 +2729,12 @@ public function isTableExists($tableName, $schemaName = null)
     /**
      * Checks if temporary table exists with given name
      *
-     * @param $tableName
-     * @param $schemaName
+     * @param string $tableName
+     * @param string $schemaName
      * @return bool
-     * @throws LocalizedException
+     * @throws LocalizedException|Zend_Db_Adapter_Exception
      */
-    private function isTemporaryTable($tableName, $schemaName): bool
+    private function isTemporaryTable(string $tableName, string $schemaName): bool
     {
         $query = "CALL sys.table_exists(" . $schemaName . ", '" . $tableName . "', @exists)";
         $this->query($query);