CABPI-27::Implement Admin Users export from Adobe to Commerce - Additional check added during save

Author: rimple-saini

app/code/Magento/AdminAdobeIms/Model/SaveImsUser.php

@@ -11,8 +11,9 @@
 use Magento\User\Model\User;
 use Magento\User\Model\ResourceModel\User\CollectionFactory as UserCollectionFactory;
 use Magento\Authorization\Model\ResourceModel\Role\CollectionFactory as RoleCollectionFactory;
-use Magento\Authorization\Model\Acl\Role\User as UserRoleType;
 use Magento\AdminAdobeIms\Logger\AdminAdobeImsLogger;
+use Magento\AdminAdobeIms\Service\ImsConfig;
+use Magento\Authorization\Model\Acl\Role\User as UserRoleType;
 use Exception;
 use Magento\Framework\Exception\CouldNotSaveException;
 
@@ -44,30 +45,42 @@ class SaveImsUser implements SaveImsUserInterface
      */
     private AdminAdobeImsLogger $logger;
 
+    /**
+     * @var ImsConfig
+     */
+    private ImsConfig $adminImsConfig;
+
     /**
      * SaveImsUserAndRole constructor.
      * @param User $user
      * @param UserCollectionFactory $userCollectionFactory
      * @param RoleCollectionFactory $roleCollectionFactory
      * @param AdminAdobeImsLogger $logger
+     * @param ImsConfig $adminImsConfig
      */
     public function __construct(
         User $user,
         UserCollectionFactory $userCollectionFactory,
         RoleCollectionFactory $roleCollectionFactory,
-        AdminAdobeImsLogger $logger
+        AdminAdobeImsLogger $logger,
+        ImsConfig $adminImsConfig
     ) {
         $this->user = $user;
         $this->userCollectionFactory = $userCollectionFactory;
         $this->roleCollectionFactory = $roleCollectionFactory;
         $this->logger = $logger;
+        $this->adminImsConfig = $adminImsConfig;
     }
 
     /**
      * @inheritdoc
      */
     public function save(array $profile): void
     {
+        if (!$this->adminImsConfig->enabled() || empty($profile['email'])) {
+            throw new CouldNotSaveException(__('Could not save ims user.'));
+        }
+
         $username = strtolower(strstr($profile['email'], '@', true));
         $userCollection = $this->userCollectionFactory->create()
             ->addFieldToFilter('email', ['eq' => $profile['email']])

dev/tests/integration/testsuite/Magento/AdminAdobeIms/Model/SaveImsUserTest.php

@@ -13,6 +13,7 @@
 use Magento\User\Model\ResourceModel\User\CollectionFactory as UserCollectionFactory;
 use Magento\Authorization\Model\ResourceModel\Role\CollectionFactory as RoleCollectionFactory;
 use Magento\AdminAdobeIms\Logger\AdminAdobeImsLogger;
+use Magento\AdminAdobeIms\Service\ImsConfig;
 use Magento\Authorization\Test\Fixture\Role as RoleFixture;
 use Magento\TestFramework\Fixture\DataFixture;
 use Magento\TestFramework\Fixture\AppArea;
@@ -57,6 +58,11 @@ class SaveImsUserTest extends TestCase
      */
     private $logger;
 
+    /**
+     * @var ImsConfig
+     */
+    private $adminImsConfig;
+
     /**
      * @var Session
      */
@@ -78,16 +84,21 @@ protected function setUp(): void
         $this->userCollectionFactory    = $this->objectManager->create(UserCollectionFactory::class);
         $this->roleCollectionFactory    = $this->objectManager->create(RoleCollectionFactory::class);
         $this->logger                   = $this->createMock(AdminAdobeImsLogger::class);
+        $this->adminImsConfig           = $this->createMock(ImsConfig::class);
         $this->authSession              = $this->objectManager->create(Session::class);
         $this->saveImsUser              = $this->objectManager->create(
             SaveImsUser::class,
             [
                 'user'                  => $this->user,
                 'userCollectionFactory' => $this->userCollectionFactory,
                 'roleCollectionFactory' => $this->roleCollectionFactory,
-                'logger'                => $this->logger
+                'logger'                => $this->logger,
+                'adminImsConfig'        => $this->adminImsConfig
             ]
         );
+        $this->adminImsConfig->expects($this->any())
+            ->method('enabled')
+            ->willReturn(true);
     }
 
     /**
@@ -152,4 +163,23 @@ public function testExceptionWhenSaveImsUserFails(): void
 
         $this->saveImsUser->save($profile);
     }
+
+    /**
+     * Handle Exception when $profile array doesn't have email
+     *
+     * @return void
+     * @throws CouldNotSaveException
+     */
+    #[
+        AppArea(Area::AREA_ADMINHTML),
+        DataFixture(RoleFixture::class, ['role_name' => self::ADMIN_IMS_ROLE]),
+    ]
+    public function testExceptionWhenProfileEmailNotFound(): void
+    {
+        $profile = ['email' => ''];
+        $this->expectException(CouldNotSaveException::class);
+        $this->expectExceptionMessage('Could not save ims user.');
+
+        $this->saveImsUser->save($profile);
+    }
 }