Deliver community converted tests

 - fix failing tests

Author: okolesnyk

app/code/Magento/Backend/Test/Mftf/Test/AdminLoginWithRestrictPermissionTest.xml

@@ -54,7 +54,8 @@
         <!--Log out of admin and login with newly created user-->
         <actionGroup ref="AdminLogoutActionGroup" stepKey="logoutOfAdmin"/>
         <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsNewUser">
-            <argument name="adminUser" value="admin2"/>
+            <argument name="username" value="{{admin2.username}}"/>
+            <argument name="password" value="{{admin2.password}}"/>
         </actionGroup>
         <actionGroup ref="AssertUserRoleRestrictedAccessActionGroup" stepKey="assertRestrictPage"/>
     </test>

app/code/Magento/Captcha/Test/Mftf/Test/AdminLoginWithCaptchaTest.xml

@@ -32,17 +32,20 @@
         </after>
 
         <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdminWithWrongCredentialsFirstAttempt">
-            <argument name="adminUser" value="AdminUserWrongCredentials" />
+            <argument name="username" value="{{AdminUserWrongCredentials.username}}"/>
+            <argument name="password" value="{{AdminUserWrongCredentials.password}}"/>
         </actionGroup>
         <actionGroup ref="AssertMessageOnAdminLoginActionGroup" stepKey="seeFirstLoginErrorMessage" />
 
         <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdminWithWrongCredentialsSecondAttempt">
-            <argument name="adminUser" value="AdminUserWrongCredentials" />
+            <argument name="username" value="{{AdminUserWrongCredentials.username}}"/>
+            <argument name="password" value="{{AdminUserWrongCredentials.password}}"/>
         </actionGroup>
         <actionGroup ref="AssertMessageOnAdminLoginActionGroup" stepKey="seeSecondLoginErrorMessage" />
 
         <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdminWithWrongCredentialsThirdAttempt">
-            <argument name="adminUser" value="AdminUserWrongCredentials" />
+            <argument name="username" value="{{AdminUserWrongCredentials.username}}"/>
+            <argument name="password" value="{{AdminUserWrongCredentials.password}}"/>
         </actionGroup>
         <actionGroup ref="AssertMessageOnAdminLoginActionGroup" stepKey="seeThirdLoginErrorMessage" />
 

app/code/Magento/Catalog/Test/Mftf/Test/AdminRestrictedUserAddCategoryFromProductPageTest.xml

@@ -76,7 +76,8 @@
         <comment userInput="Log out of admin and login with newly created user" stepKey="commentLoginWithNewUser"/>
         <actionGroup ref="AdminLogoutActionGroup" stepKey="logoutOfAdmin"/>
         <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsNewUser">
-            <argument name="adminUser" value="admin2"/>
+            <argument name="username" value="{{admin2.username}}"/>
+            <argument name="password" value="{{admin2.password}}"/>
         </actionGroup>
         <!--Go to create product page-->
         <comment userInput="Go to create product page" stepKey="commentGoCreateProductPage"/>

app/code/Magento/User/Test/Mftf/Test/AdminBulkOperationsLogIsNotAccessibleForAdminUserWithLimitedAccessTest.xml

@@ -48,7 +48,8 @@
 
         <!-- Login as user2 -->
         <actionGroup ref="AdminLoginActionGroup" stepKey="LoginAsUser">
-            <argument name="adminUser" value="NewAdminUser"/>
+            <argument name="username" value="{{NewAdminUser.username}}"/>
+            <argument name="password" value="{{NewAdminUser.password}}"/>
         </actionGroup>
 
         <!-- Bulk operation menu item isn't visible( System > Action Logs > -Bulk Actions-) -->

app/code/Magento/User/Test/Mftf/Test/AdminDeleteOwnAdminUserAccountTest.xml

@@ -26,7 +26,8 @@
                 <field key="current_password">{$adminPassword}</field>
             </createData>
             <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsNewUser">
-                <argument name="adminUser" value="$$user$$"/>
+                <argument name="username" value="$$user.username$$"/>
+                <argument name="password" value="$$user.password$$"/>
             </actionGroup>
         </before>
         <after>

app/code/Magento/User/Test/Mftf/Test/AdminLockAdminUserEntityTest.xml

@@ -21,11 +21,13 @@
         </annotations>
         <before>
             <magentoCLI command="config:set admin/captcha/enable 0" stepKey="disableAdminCaptcha"/>
+            <magentoCLI command="config:set admin/security/lockout_failures 2" stepKey="setDefaultMaximumLoginFailures"/>
             <magentoCLI command="cache:clean config full_page" stepKey="cleanInvalidatedCaches1"/>
             <actionGroup ref="AdminLoginActionGroup" stepKey="adminLogin"/>
         </before>
         <after>
             <magentoCLI command="config:set admin/captcha/enable 1" stepKey="enableAdminCaptcha"/>
+            <magentoCLI command="config:set admin/security/lockout_failures 6" stepKey="setDefaultMaximumLoginFailures"/>
             <magentoCLI command="cache:clean config full_page" stepKey="cleanInvalidatedCaches"/>
             <actionGroup ref="AdminLogoutActionGroup" stepKey="adminLogout"/>
         </after>
@@ -37,14 +39,6 @@
         </actionGroup>
         <actionGroup ref="AdminClickSaveButtonOnUserFormActionGroup" stepKey="saveNewUser"/>
 
-        <!--Set 'Maximum Login Failures to Lockout Account'-->
-        <actionGroup ref="AdminOpenConfigAdminPageActionGroup" stepKey="goToConfigAdminSectionPage"/>
-        <actionGroup ref="AdminExpandSecurityTabActionGroup" stepKey="openSecurityTab"/>
-        <actionGroup ref="AdminSetMaximumLoginFailuresToLockoutAccountActionGroup" stepKey="setMaximumLoginFailures">
-            <argument name="qty" value="2"/>
-        </actionGroup>
-        <actionGroup ref="AdminSaveConfigActionGroup" stepKey="saveChanges"/>
-
         <!-- Log in to Admin Panel with incorrect password specified number of times-->
         <actionGroup ref="AdminLogoutActionGroup" stepKey="logoutAsDefaultUser"/>
         <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsNewUserFirstAttempt">