#35906 GraphQL Routes query with fragments has issue in the category page #35906

- Test fixes adapted for the new version of webonyx/graphql-php

Author: monteshot

app/code/Magento/CatalogGraphQl/Test/Unit/Model/Resolver/Category/DepthCalculatorTest.php

@@ -41,12 +41,12 @@ class DepthCalculatorTest extends TestCase
     public function testCalculateWithNullAsSelectionSet(): void
     {
         $this->fieldNodeMock->kind = NodeKind::FIELD;
-        /** @var SelectionSetNode $selectionSetMock */
-        $selectionSetMock = $this->createMock(SelectionSetNode::class);
-        $selectionSetMock->selections = $this->getMockSelectionsArrayForNullCase();
-        $this->fieldNodeMock->selectionSet = $selectionSetMock;
+        /** @var SelectionSetNode $selectionSetNode */
+        $selectionSetNode = new SelectionSetNode([]);
+        $selectionSetNode->selections = $this->getSelectionsArrayForNullCase();
+        $this->fieldNodeMock->selectionSet = $selectionSetNode;
         $result = $this->depthCalculator->calculate($this->resolveInfoMock, $this->fieldNodeMock);
-        $this->assertEquals(1, $result);
+        $this->assertSame(1, $result);
     }
 
     /**
@@ -56,66 +56,60 @@ public function testCalculateWithNullAsSelectionSet(): void
     public function testCalculateNonNullAsSelectionSet(): void
     {
         $this->fieldNodeMock->kind = NodeKind::FIELD;
-        $selectionSetMock = $this->createMock(SelectionSetNode::class);
-        $selectionSetMock->selections = $this->getMockSelectionsArrayForNonNullCase();
-        $this->fieldNodeMock->selectionSet = $selectionSetMock;
+        $selectionSetNode = $this->getSelectionSetNode();
+        $selectionSetNode->selections = $this->getSelectionsArrayForNonNullCase();
+        $this->fieldNodeMock->selectionSet = $selectionSetNode;
         $result = $this->depthCalculator->calculate($this->resolveInfoMock, $this->fieldNodeMock);
         $this->assertEquals(2, $result);
     }
 
     /**
      * @return NodeList
      */
-    private function getMockSelectionsArrayForNullCase()
+    private function getSelectionsArrayForNullCase()
     {
-        /** @var SelectionSetNode $selectionSetMock */
-        $selectionSetMock = $this->createMock(SelectionSetNode::class);
-        $selectionSetMock->selections = [$this->getNewFieldNodeMock()];
-        $inlineFragmentMock = $this->getNewInlineFragmentNodeMock();
-        $inlineFragmentMock->selectionSet = $selectionSetMock;
+        $selectionSetNode = $this->getSelectionSetNode();
+        $selectionSetNode->selections = $this->getNodeList();
+        $inlineFragmentNode = $this->getNewInlineFragmentNode();
+        $inlineFragmentNode->selectionSet = $selectionSetNode;
         return new NodeList([
-            $this->getNewFieldNodeMock(),
-            $inlineFragmentMock
+            $this->getNewFieldNode(),
+            $inlineFragmentNode
         ]);
     }
 
     /**
-     * @return FieldNode|MockObject
+     * @return FieldNode
      */
-    private function getNewFieldNodeMock()
+    private function getNewFieldNode()
     {
-        return $this->getMockBuilder(FieldNode::class)
-            ->setConstructorArgs(['vars' => []])
-            ->getMock();
+        return new FieldNode([]);
     }
 
     /**
-     * @return InlineFragmentNode|MockObject
+     * @return InlineFragmentNode
      */
-    private function getNewInlineFragmentNodeMock()
+    private function getNewInlineFragmentNode()
     {
-        return $this->getMockBuilder(InlineFragmentNode::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        return new InlineFragmentNode([]);
     }
 
     /**
      * @return NodeList
      */
-    private function getMockSelectionsArrayForNonNullCase()
+    private function getSelectionsArrayForNonNullCase()
     {
-        $newFieldMock = $this->getNewFieldNodeMock();
-        $newFieldMock->selectionSet = $this->createMock(SelectionSetNode::class);
-        $newFieldMock->selectionSet->selections = [$this->getNewFieldNodeMock()];
-        /** @var SelectionSetNode $selectionSetMock */
-        $selectionSetMock = $this->createMock(SelectionSetNode::class);
-        $selectionSetMock->selections = [$newFieldMock];
-
-        $inlineFragmentMock = $this->getNewInlineFragmentNodeMock();
-        $inlineFragmentMock->selectionSet = $selectionSetMock;
+        $newFieldNode = $this->getNewFieldNode();
+        $newFieldNode->selectionSet = $this->getSelectionSetNode();
+        $newFieldNode->selectionSet->selections = $this->getNodeList();
+        $newFieldNode->selectionSet->selections[] = $this->getNewFieldNode();
+        $selectionSetNode = $this->getSelectionSetNode();
+        $selectionSetNode->selections = new NodeList([$newFieldNode]);
+        $inlineFragmentNode = $this->getNewInlineFragmentNode();
+        $inlineFragmentNode->selectionSet = $selectionSetNode;
         return new NodeList([
-            $this->getNewFieldNodeMock(),
-            $inlineFragmentMock
+            $newFieldNode,
+            $inlineFragmentNode
         ]);
     }
 
@@ -130,4 +124,20 @@ protected function setUp(): void
             ->disableOriginalConstructor()
             ->getMock();
     }
+
+    /**
+     * @return \GraphQL\Language\AST\SelectionSetNode
+     */
+    protected function getSelectionSetNode($nodes = []): SelectionSetNode
+    {
+        return new SelectionSetNode($nodes);
+    }
+
+    /**
+     * @return \GraphQL\Language\AST\NodeList
+     */
+    protected function getNodeList(): NodeList
+    {
+        return new NodeList([]);
+    }
 }