AC-15047::[CE] PHPUnit 12: Upgrade Media & Asset Management related test cases | TestHelper Refactoring

Author: cod43156

app/code/Magento/MediaStorage/Test/Unit/Helper/File/Storage/DatabaseTest.php

@@ -1,10 +1,6 @@
 <?php
 /**
-<<<<<<< HEAD
- * Copyright 2018 Adobe
-=======
  * Copyright 2015 Adobe
->>>>>>> origin/2.4-develop
  * All Rights Reserved.
  */
 declare(strict_types=1);
@@ -18,11 +14,11 @@
 use Magento\Framework\Filesystem\Directory\ReadInterface;
 use Magento\Framework\Filesystem\Directory\WriteInterface;
 use Magento\Framework\Model\ResourceModel\Db\AbstractDb;
+use Magento\Framework\TestFramework\Unit\Helper\MockCreationTrait;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\MediaStorage\Helper\File\Storage\Database;
 use Magento\MediaStorage\Model\File\Storage;
 use Magento\MediaStorage\Model\File\Storage\DatabaseFactory;
-use Magento\Framework\Model\Test\Unit\Helper\AbstractDbTestHelper;
 use Magento\MediaStorage\Model\File\Storage\File;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
@@ -33,6 +29,7 @@
  */
 class DatabaseTest extends TestCase
 {
+    use MockCreationTrait;
     /**
      * @var ObjectManager
      */
@@ -364,7 +361,10 @@ public function testDeleteFolder($storage, $callNum)
         $this->dbStorageFactoryMock->expects($this->exactly($callNum))
             ->method('create')
             ->willReturn($dbModelMock);
-        $resourceModelMock = new AbstractDbTestHelper();
+        $resourceModelMock = $this->createPartialMockWithReflection(
+            AbstractDb::class,
+            ['deleteFolder', '_construct']
+        );
         $dbModelMock->expects($this->exactly($callNum))
             ->method('getResource')
             ->willReturn($resourceModelMock);

app/code/Magento/MediaStorage/Test/Unit/Helper/File/StorageTest.php

@@ -1,10 +1,6 @@
 <?php
 /**
-<<<<<<< HEAD
- * Copyright 2018 Adobe
-=======
  * Copyright 2015 Adobe
->>>>>>> origin/2.4-develop
  * All Rights Reserved.
  */
 declare(strict_types=1);
@@ -14,17 +10,18 @@
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\App\Helper\Context;
 use Magento\Framework\Model\AbstractModel;
+use Magento\Framework\TestFramework\Unit\Helper\MockCreationTrait;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\MediaStorage\Helper\File\Storage;
 use Magento\MediaStorage\Helper\File\Storage\Database as DatabaseHelper;
 use Magento\MediaStorage\Model\File\Storage\File;
-use Magento\Framework\Model\Test\Unit\Helper\AbstractModelTestHelper;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class StorageTest extends TestCase
 {
+    use MockCreationTrait;
     /**
      * @var ObjectManager
      */
@@ -136,19 +133,23 @@ public function testProcessStorageFile($expected, $storage, $callNum, $callSaveF
             ->with($filename)
             ->willReturn($relativePath);
 
-        $storageModelMock = new AbstractModelTestHelper();
-        $this->storageMock->expects($this->exactly($callNum))
-            ->method('getStorageModel')
-            ->willReturn($storageModelMock);
         $fileMock = $this->createPartialMock(
             \Magento\MediaStorage\Model\File\Storage\Database::class,
             ['getId', '__wakeup']
         );
-        $storageModelMock->setFileMock($fileMock);
         $fileMock->expects($this->exactly($callNum))
             ->method('getId')
             ->willReturn($fileId);
 
+        $storageModelMock = $this->createPartialMockWithReflection(
+            AbstractModel::class,
+            ['loadByFilename']
+        );
+        $storageModelMock->method('loadByFilename')->willReturn($fileMock);
+        $this->storageMock->expects($this->exactly($callNum))
+            ->method('getStorageModel')
+            ->willReturn($storageModelMock);
+
         $this->filesystemStorageMock->expects($this->exactly($callSaveFileNum))
             ->method('saveFile')
             ->with($fileMock, true)

app/code/Magento/MediaStorage/Test/Unit/Model/File/Storage/FileTest.php

@@ -1,10 +1,6 @@
 <?php
 /**
-<<<<<<< HEAD
  * Copyright 2018 Adobe
-=======
- * Copyright 2021 Adobe
->>>>>>> origin/2.4-develop
  * All Rights Reserved.
  */
 declare(strict_types=1);

lib/internal/Magento/Framework/TestFramework/Unit/Helper/MockCreationTrait.php

@@ -0,0 +1,46 @@
+<?php
+/**
+ * Copyright 2025 Adobe
+ * All Rights Reserved.
+ */
+declare(strict_types=1);
+
+namespace Magento\Framework\TestFramework\Unit\Helper;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use ReflectionClass;
+
+/**
+ * Trait for creating partial mocks with reflection for PHPUnit 12 migration
+ *
+ * Provides helper methods for creating mocks when standard PHPUnit methods are insufficient
+ */
+trait MockCreationTrait
+{
+    /**
+     * Create a partial mock with reflection.
+     *
+     * Use this when you need to mock methods that don't exist in the class/interface
+     * and cannot use standard createPartialMock() which would throw CannotUseOnlyMethodsException.
+     *
+     * @param string $className
+     * @param array $methods Methods to mock
+     * @return MockObject
+     */
+    protected function createPartialMockWithReflection(string $className, array $methods): MockObject
+    {
+        $reflection = new ReflectionClass($this);
+        $getMockBuilderMethod = $reflection->getMethod('getMockBuilder');
+        $getMockBuilderMethod->setAccessible(true);
+        $mockBuilder = $getMockBuilderMethod->invoke($this, $className);
+
+        $builderReflection = new ReflectionClass($mockBuilder);
+        $methodsProperty = $builderReflection->getProperty('methods');
+        $methodsProperty->setAccessible(true);
+        $methodsProperty->setValue($mockBuilder, $methods);
+
+        $mockBuilder->disableOriginalConstructor();
+        return $mockBuilder->getMock();
+    }
+}
+