ACP2E-2204: Price indexing performance gradually degrades overtime

- bypassing table check for truncate

Author: aplapana

app/code/Magento/Catalog/Model/Indexer/Product/Price/AbstractAction.php

@@ -367,7 +367,8 @@ protected function _insertFromTable($sourceTable, $destTable, $where = null)
      */
     protected function _emptyTable($table)
     {
-        $this->getConnection()->truncateTable($table);
+        $connection = $this->getConnection();
+        $connection->query('TRUNCATE TABLE ' . $connection->quoteIdentifier($table));
     }
 
     /**

app/code/Magento/Catalog/Model/ResourceModel/Product/Indexer/Price/CustomOptionPriceModifier.php

@@ -122,8 +122,8 @@ public function modifyPrice(IndexTableStructure $priceTable, array $entityIds =
         $query = $select->crossUpdateFromSelect(['i' => $finalPriceTable]);
         $connection->query($query);
 
-        $connection->truncateTable($coaTable);
-        $connection->truncateTable($copTable);
+        $connection->query('TRUNCATE TABLE ' . $connection->quoteIdentifier($coaTable));
+        $connection->query('TRUNCATE TABLE ' . $connection->quoteIdentifier($copTable));
     }
 
     /**

app/code/Magento/Catalog/Test/Unit/Model/Indexer/Product/Price/CustomOptionPriceModifierTest.php

@@ -92,7 +92,7 @@ public function testModifyPrice(): void
         $connection->expects($this->exactly(2))->method('delete');
         $connection->expects($this->any())->method('select')->willReturn($select);
         $connection->expects($this->any())->method('fetchRow')->willReturn(['exists']);
-        $connection->expects($this->exactly(2))->method('truncateTable');
+        $connection->expects($this->exactly(6))->method('query');
         $this->resource->expects($this->any())->method('getConnection')->willReturn($connection);
         $this->resource->expects($this->any())->method('getTableName')->willReturn('table');
         $this->tableStrategy->expects($this->any())

lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php

@@ -2708,10 +2708,6 @@ public function isTableExists($tableName, $schemaName = null)
             $fromDbName = $this->quote($schemaName);
         }
 
-        if ($this->isTemporaryTable($tableName, $fromDbName)) {
-            return true;
-        }
-
         $sql = sprintf(
             'SELECT COUNT(1) AS tbl_exists FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = %s AND TABLE_SCHEMA = %s',
             $this->quote($tableName),
@@ -2726,26 +2722,6 @@ public function isTableExists($tableName, $schemaName = null)
         return false;
     }
 
-    /**
-     * Checks if temporary table exists with given name
-     *
-     * @param string $tableName
-     * @param string $schemaName
-     * @return bool
-     * @throws LocalizedException|Zend_Db_Adapter_Exception
-     */
-    private function isTemporaryTable(string $tableName, string $schemaName): bool
-    {
-        $query = "CALL sys.table_exists(" . $schemaName . ", '" . $tableName . "', @exists)";
-        $this->query($query);
-
-        if ($this->rawFetchRow('SELECT @exists')) {
-            return true;
-        }
-
-        return false;
-    }
-
     /**
      * Rename table
      *