AC-465: Allow to configure input limit for RESTful endpoints

Author: arhiopterecs

dev/tests/api-functional/framework/Magento/TestFramework/TestCase/HttpClient/CurlClient.php

@@ -118,17 +118,8 @@ public function put($url, $data, $headers = [])
         $curlOpts[CURLOPT_CUSTOMREQUEST] = \Magento\Framework\Webapi\Rest\Request::HTTP_METHOD_PUT;
         $headers[] = 'Content-Length: ' . strlen($data);
         $curlOpts[CURLOPT_POSTFIELDS] = $data;
-        try{
-            $resp = $this->invokeApi($url, $curlOpts, $headers);
-        }catch (\Exception $e){
-            var_dump([
-                'message' => $e->getMessage(),
-                'code' => $e->getCode(),
-                'file' => $e->getFile(),
-                'traceAsString' => $e->getTraceAsString(),
-            ]);
-            throw $e;
-        }
+
+        $resp = $this->invokeApi($url, $curlOpts, $headers);
         return $resp["body"];
     }
 

dev/tests/api-functional/framework/Magento/TestFramework/TestCase/Webapi/Adapter/Rest.php

@@ -99,17 +99,7 @@ public function call($serviceInfo, $arguments = [], $storeCode = null, $integrat
                 $response = $this->restClient->post($resourcePath, $arguments, $authHeader);
                 break;
             case Request::HTTP_METHOD_PUT:
-                try{
-                    $response = $this->restClient->put($resourcePath, $arguments, $authHeader);
-                }catch (\Exception $e){
-                    var_dump([
-                        'message' => $e->getMessage(),
-                        'code' => $e->getCode(),
-                        'file' => $e->getFile(),
-                        'traceAsString' => $e->getTraceAsString(),
-                    ]);
-                    throw $e;
-                }
+                $response = $this->restClient->put($resourcePath, $arguments, $authHeader);
                 break;
             case Request::HTTP_METHOD_DELETE:
                 $response = $this->restClient->delete($resourcePath, $authHeader);

dev/tests/api-functional/framework/Magento/TestFramework/TestCase/Webapi/Adapter/Rest/RestClient.php

@@ -103,18 +103,7 @@ public function put($resourcePath, $data, $headers = [])
                 $data = '';
             }
         }
-        try{
-            $responseBody = $this->curlClient->put($url, $data, $headers);
-        }catch (\Exception $e){
-            var_dump([
-                'message' => $e->getMessage(),
-                'code' => $e->getCode(),
-                'file' => $e->getFile(),
-                'traceAsString' => $e->getTraceAsString(),
-            ]);
-            throw $e;
-        }
-
+        $responseBody = $this->curlClient->put($url, $data, $headers);
         return $this->jsonSerializer->jsonDecode($responseBody);
     }
 

dev/tests/api-functional/framework/Magento/TestFramework/TestCase/WebapiAbstract.php

@@ -565,20 +565,7 @@ protected function _restoreAppConfig()
      */
     public function processRestExceptionResult(\Exception $e)
     {
-        echo 'pickachu';
-        var_dump([
-            'message' => $e->getMessage(),
-            'code' => $e->getCode(),
-            'file' => $e->getFile(),
-//            'trace' => $e->getTrace(),
-            'traceAsString' => $e->getTraceAsString(),
-//            'previous' => $e->getPrevious(),
-        ]);
         $error = json_decode($e->getMessage(), true);
-        if (empty($error) && json_last_error() !== JSON_ERROR_NONE) {
-            $error['message'] = $e->getMessage();
-        }
-
         //Remove line breaks and replace with space
         $error['message'] = trim(preg_replace('/\s+/', ' ', $error['message']));
         // remove trace and type, will only be present if server is in dev mode

dev/tests/api-functional/testsuite/Magento/Webapi/Routing/CoreRoutingTest.php

@@ -116,12 +116,7 @@ public function testRequestParamsUnexpectedValueException(): void
             $exceptionResult = $this->processRestExceptionResult($e);
             $actualMessage = $exceptionResult['message'];
             $this->assertStringNotContainsString($unexpectedMessage, $actualMessage);
-            $this->assertStringContainsString('getMessage', $e->getMessage());
-            $this->assertStringContainsString('getCode', $e->getCode());
-            $this->assertStringContainsString('getTraceAsString', $e->getTraceAsString());
-            $this->assertStringContainsString('getFile', $e->getFile());
-            $this->assertStringContainsString('line', $e->getLine());
-            $this->assertArrayHasKey('getTrace', $e->getTrace());
+            $this->assertStringContainsString($expectedMessage, $actualMessage);
         }
     }
 }

lib/internal/Magento/Framework/App/Bootstrap.php

@@ -429,8 +429,6 @@ public function isDeveloperMode()
      */
     protected function terminate(\Throwable $e)
     {
-        echo "ramamba";
-        var_dump($e);
         /** @var Response $response */
         $response = $this->objectManager->get(Response::class);
         $response->clearHeaders();

lib/internal/Magento/Framework/Webapi/ServiceInputProcessor.php

@@ -195,6 +195,7 @@ public function process($serviceClassName, $serviceMethodName, array $inputArray
     {
         $inputData = [];
         $inputError = [];
+        $this->inputArraySizeLimitValue->set($inputArraySizeLimit);
 
         foreach ($this->methodsMap->getMethodParams($serviceClassName, $serviceMethodName) as $param) {
             $paramName = $param[MethodsMap::METHOD_META_NAME];
@@ -217,7 +218,6 @@ public function process($serviceClassName, $serviceMethodName, array $inputArray
         }
 
         $this->processInputError($inputError);
-        $this->inputArraySizeLimitValue->set($inputArraySizeLimit);
 
         return $inputData;
     }