ACP2E-3900: Update product url_key via REST API does not generate a 301 URL Rewrite

- fixed static tests

Author: o-rykh

app/code/Magento/Catalog/Model/ProductRepository.php

@@ -20,7 +20,6 @@
 use Magento\Framework\Api\ImageProcessorInterface;
 use Magento\Framework\Api\SearchCriteria\CollectionProcessorInterface;
 use Magento\Framework\Api\SearchCriteriaInterface;
-use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\DB\Adapter\ConnectionException;
 use Magento\Framework\DB\Adapter\DeadlockException;
 use Magento\Framework\DB\Adapter\LockWaitException;
@@ -215,7 +214,6 @@ class ProductRepository implements \Magento\Catalog\Api\ProductRepositoryInterfa
      * @param ReadExtensions $readExtensions
      * @param CategoryLinkManagementInterface $linkManagement
      * @param ScopeOverriddenValue|null $scopeOverriddenValue
-     * @param ScopeConfigInterface|null $scopeConfig
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */

app/code/Magento/CatalogUrlRewrite/Model/Product/CurrentUrlRewritesRegenerator.php

@@ -30,18 +30,21 @@ class CurrentUrlRewritesRegenerator
     /**
      * @var Product
      * @deprecated 100.1.0
+     * @see not used
      */
     protected $product;
 
     /**
      * @var ObjectRegistry
      * @deprecated 100.1.0
+     * @see not used
      */
     protected $productCategories;
 
     /**
      * @var UrlFinderInterface
      * @deprecated 100.1.0
+     * @see not used
      */
     protected $urlFinder;
 
@@ -87,6 +90,7 @@ class CurrentUrlRewritesRegenerator
      * @param UrlRewriteFinder|null $urlRewriteFinder
      * @param \Magento\UrlRewrite\Model\MergeDataProviderFactory|null $mergeDataProviderFactory
      * @param CategoryRepository|null $categoryRepository
+     * @param ScopeConfigInterface|null $scopeConfig
      */
     public function __construct(
         UrlFinderInterface $urlFinder,
@@ -176,10 +180,11 @@ public function generateAnchor(
             ProductUrlRewriteGenerator::ENTITY_TYPE,
             $rootCategoryId
         );
-
-        foreach ($productCategories->getList() as $productCategory) {
-            $anchorCategoryIds = array_merge($productCategory->getAnchorsAbove(), $anchorCategoryIds);
-        }
+        $anchorCategoryIds = array_merge(
+            ...array_map(
+                fn($productCategory) => $productCategory->getAnchorsAbove(), $productCategories->getList()
+            )
+        );
 
         foreach ($currentUrlRewrites as $currentUrlRewrite) {
             $metadata = $currentUrlRewrite->getMetadata();
@@ -199,6 +204,8 @@ public function generateAnchor(
     }
 
     /**
+     * Generate URL rewrites for autogenerated URLs
+     *
      * @param UrlRewrite $url
      * @param int $storeId
      * @param Category|null $category
@@ -227,6 +234,8 @@ protected function generateForAutogenerated($url, $storeId, $category, $product
     }
 
     /**
+     * Generate URL rewrites for custom URLs
+     *
      * @param UrlRewrite $url
      * @param int $storeId
      * @param Category|null $category
@@ -255,6 +264,8 @@ protected function generateForCustom($url, $storeId, $category, $product = null)
     }
 
     /**
+     * Retrieve category from URL metadata
+     *
      * @param UrlRewrite $url
      * @param ObjectRegistry|null $productCategories
      * @return Category|null|bool