ACPT-1688: Fix Static Tests failures on Application-Server branch

Author: yaroslavGoncharuk

app/code/Magento/ApplicationPerformanceMonitor/Profiler/Metric.php

@@ -8,13 +8,13 @@
 namespace Magento\ApplicationPerformanceMonitor\Profiler;
 
 /**
- * A single metric.  Type is currently either MEMORY or TIME.
+ * A single metric. Type is currently either MEMORY or TIME.
  * This class is an immutable data object.
  */
 class Metric
 {
     /**
-     * @param int $type
+     * @param MetricType $type
      * @param string $name
      * @param mixed $value
      * @param bool $verbose
@@ -28,33 +28,41 @@ public function __construct(
     }
 
     /**
-     * @return MetricType
+     * Gets type of metric
+     *
+     * @return int|MetricType
      */
-    public function getType()
+    public function getType(): MetricType|int
     {
         return $this->type;
     }
 
     /**
+     * Gets a name
+     *
      * @return string
      */
-    public function getName()
+    public function getName(): string
     {
         return $this->name;
     }
 
     /**
+     * Gets a value
+     *
      * @return mixed
      */
-    public function getValue()
+    public function getValue(): mixed
     {
         return $this->value;
     }
 
     /**
+     * Checks if verbose
+     *
      * @return bool
      */
-    public function isVerbose()
+    public function isVerbose(): bool
     {
         return $this->verbose;
     }

app/code/Magento/ApplicationPerformanceMonitor/Profiler/Metrics.php

@@ -8,10 +8,16 @@
 namespace Magento\ApplicationPerformanceMonitor\Profiler;
 
 /**
- * Gathers and stores metrics.  Compares against another one to get the deltas.
+ * Gathers and stores metrics. Compares against another one to get the deltas.
  */
 class Metrics
 {
+    /**
+     * @param int $peakMemoryUsage
+     * @param int $memoryUsage
+     * @param array $rusage
+     * @param float $microtime
+     */
     public function __construct(
         private readonly int $peakMemoryUsage,
         private readonly int $memoryUsage,
@@ -20,21 +26,41 @@ public function __construct(
     ) {
     }
 
+    /**
+     * Gets peak memory usage
+     *
+     * @return int
+     */
     public function getPeakMemoryUsage() : int
     {
         return $this->peakMemoryUsage;
     }
 
+    /**
+     * Gets memory usage
+     *
+     * @return int
+     */
     public function getMemoryUsage() : int
     {
         return $this->memoryUsage;
     }
 
+    /**
+     * Gets fusage
+     *
+     * @return array
+     */
     public function getRusage() : array
     {
         return $this->rusage;
     }
 
+    /**
+     * Gets microtime
+     *
+     * @return float
+     */
     public function getMicrotime() : float
     {
         return $this->microtime;

app/code/Magento/ApplicationPerformanceMonitorNewRelic/Profiler/Output/NewRelicOutput.php

@@ -20,6 +20,10 @@ class NewRelicOutput implements OutputInterface
     public const CONFIG_ENABLE_KEY = 'application/performance_monitor/newrelic_output_enable';
     public const CONFIG_VERBOSE_KEY = 'application/performance_monitor/newrelic_output_verbose';
 
+    /**
+     * @param DeploymentConfig $deploymentConfig
+     * @param NewRelicWrapper $newRelicWrapper
+     */
     public function __construct(
         private readonly DeploymentConfig $deploymentConfig,
         private readonly NewRelicWrapper $newRelicWrapper

app/code/Magento/CatalogGraphQl/DataProvider/Product/RequestDataBuilder.php

@@ -12,22 +12,36 @@
  */
 class RequestDataBuilder implements ResetAfterRequestInterface
 {
+    /**
+     * @var array
+     */
     private array $data;
 
     public function __construct()
     {
         $this->_resetState();
     }
 
-    public function setData($data)
+    /**
+     * Sets the data
+     *
+     * @param $data
+     * @return void
+     */
+    public function setData($data): void
     {
         $this->data = $data;
     }
 
-    public function getData(string $key)
+    /**
+     * Gets the data
+     *
+     * @param string $key
+     * @return mixed|null
+     */
+    public function getData(string $key): mixed
     {
         return $this->data[$key] ?? null;
-
     }
 
     /**

app/code/Magento/CatalogGraphQl/DataProvider/Product/SearchCriteriaBuilder.php

@@ -69,6 +69,9 @@ class SearchCriteriaBuilder
      */
     private SearchConfig $searchConfig;
 
+    /**
+     * @var RequestDataBuilder|mixed 
+     */
     private RequestDataBuilder $localData;
 
     /**
@@ -80,6 +83,7 @@ class SearchCriteriaBuilder
      * @param SortOrderBuilder|null $sortOrderBuilder
      * @param Config|null $eavConfig
      * @param SearchConfig|null $searchConfig
+     * @param RequestDataBuilder|null $localData
      */
     public function __construct(
         Builder $builder,

app/code/Magento/CatalogGraphQl/Model/Resolver/Product/Price/Provider.php

@@ -34,7 +34,14 @@ class Provider implements ProviderInterface, ResetAfterRequestInterface
         RegularPrice::PRICE_CODE => []
     ];
 
+    /**
+     * @var array|array[]
+     */
     private readonly array $minimalPriceConstructed;
+
+    /**
+     * @var array|array[]
+     */
     private readonly array $maximalPriceConstructed;
 
     public function __construct()

app/code/Magento/Config/App/Config/ReloadConfig.php

@@ -8,20 +8,22 @@
 
 use Magento\Config\App\Config\Type\System;
 use Magento\Framework\App\State\ReloadProcessorInterface;
-use Magento\Framework\ObjectManagerInterface;
 
 /**
  * Config module specific reset state
  */
 class ReloadConfig implements ReloadProcessorInterface
 {
+    /**
+     * @param System $system
+     */
     public function __construct(private readonly System $system)
-    {}
+    {
+    }
 
     /**
      * Tells the system state to reload itself.
      *
-     * @param ObjectManagerInterface $objectManager
      * @return void
      */
     public function reloadState(): void

app/code/Magento/Sales/Model/Order/Config.php

@@ -93,7 +93,6 @@ public function _resetState(): void
         $this->collection = null;
     }
 
-
     /**
      * Get collection.
      *
@@ -140,7 +139,6 @@ public function getStateDefaultStatus($state): ?string
         return $status;
     }
 
-
     /**
      * Retrieve status label for detected area
      *

app/code/Magento/Store/Model/Config/ReloadDeploymentConfig.php

@@ -7,7 +7,6 @@
 namespace Magento\Store\Model\Config;
 
 use Magento\Framework\App\State\ReloadProcessorInterface;
-use Magento\Framework\ObjectManagerInterface;
 use Magento\Store\App\Config\Type\Scopes;
 use Magento\Store\Model\GroupRepository;
 use Magento\Store\Model\StoreRepository;
@@ -19,24 +18,29 @@
 class ReloadDeploymentConfig implements ReloadProcessorInterface
 {
 
+    /**
+     * @param StoreRepository $storeRepository
+     * @param WebsiteRepository $websiteRepository
+     * @param GroupRepository $groupRepository
+     * @param Scopes $scopes
+     */
     public function __construct(
         private readonly StoreRepository $storeRepository,
         private readonly WebsiteRepository $websiteRepository,
         private readonly GroupRepository $groupRepository,
         private readonly Scopes $scopes
-    )
-    {}
+    ) {
+    }
 
     /**
      * Tells the system state to reload itself.
      *
-     * @param ObjectManagerInterface $objectManager
      * @return void
      */
     public function reloadState(): void
     {
         // Note: Magento\Store\Model\StoreManager::reinitStores can't be called because it flushes the caches which
-        // we don't want to do because that is already taken care of.  Instead, we call the same clean methods that
+        // we don't want to do because that is already taken care of. Instead, we call the same clean methods that
         // it calls, but we skip cleaning the cache.
 
         $this->storeRepository->clean();

app/code/Magento/Translation/App/Config/ReloadConfig.php

@@ -7,7 +7,6 @@
 namespace Magento\Translation\App\Config;
 
 use Magento\Framework\App\State\ReloadProcessorInterface;
-use Magento\Framework\ObjectManagerInterface;
 use Magento\Translation\App\Config\Type\Translation;
 
 /**
@@ -19,12 +18,12 @@ class ReloadConfig implements ReloadProcessorInterface
      * @param Translation $translation
      */
     public function __construct(private readonly Translation $translation)
-    {}
+    {
+    }
 
     /**
      * Tells the system state to reload itself.
      *
-     * @param ObjectManagerInterface $objectManager
      * @return void
      */
     public function reloadState(): void