#29543: Removed general operations from partial synchronizer

Author: sivaschenko

app/code/Magento/MediaContentSynchronization/Model/SynchronizeIdentities.php

@@ -11,60 +11,34 @@
 use Magento\Framework\FlagManager;
 use Magento\Framework\Stdlib\DateTime\DateTimeFactory;
 use Magento\MediaContentSynchronizationApi\Api\SynchronizeIdentitiesInterface;
-use Magento\MediaContentSynchronizationApi\Model\SynchronizerIdentitiesPool;
+use Magento\MediaContentSynchronizationApi\Model\SynchronizeIdentitiesPool;
 use Psr\Log\LoggerInterface;
 
 /**
  * Batch Synchronize content with assets
  */
 class SynchronizeIdentities implements SynchronizeIdentitiesInterface
 {
-    private const LAST_EXECUTION_TIME_CODE = 'media_content_last_execution';
-
-    /**
-     * @var DateTimeFactory
-     */
-    private $dateFactory;
-
-    /**
-     * @var FlagManager
-     */
-    private $flagManager;
-
     /**
      * @var LoggerInterface
      */
     private $log;
 
     /**
-     * @var SynchronizerIdentitiesPool
-     */
-    private $synchronizerIdentitiesPool;
-
-    /**
-     * @var RemoveObsoleteContentAsset
+     * @var SynchronizeIdentitiesPool
      */
-    private $removeObsoleteContent;
+    private $synchronizeIdentitiesPool;
 
     /**
-     * @param RemoveObsoleteContentAsset $removeObsoleteContent
-     * @param DateTimeFactory $dateFactory
-     * @param FlagManager $flagManager
      * @param LoggerInterface $log
-     * @param SynchronizerIdentitiesPool $synchronizerIdentitiesPool
+     * @param SynchronizeIdentitiesPool $synchronizeIdentitiesPool
      */
     public function __construct(
-        RemoveObsoleteContentAsset $removeObsoleteContent,
-        DateTimeFactory $dateFactory,
-        FlagManager $flagManager,
         LoggerInterface $log,
-        SynchronizerIdentitiesPool $synchronizerIdentitiesPool
+        SynchronizeIdentitiesPool $synchronizeIdentitiesPool
     ) {
-        $this->removeObsoleteContent = $removeObsoleteContent;
-        $this->dateFactory = $dateFactory;
-        $this->flagManager = $flagManager;
         $this->log = $log;
-        $this->synchronizerIdentitiesPool = $synchronizerIdentitiesPool;
+        $this->synchronizeIdentitiesPool = $synchronizeIdentitiesPool;
     }
 
     /**
@@ -74,9 +48,9 @@ public function execute(array $mediaContentIdentities): void
     {
         $failed = [];
 
-        foreach ($this->synchronizerIdentitiesPool->get() as $name => $synchronizers) {
+        foreach ($this->synchronizeIdentitiesPool->get() as $name => $synchronizer) {
             try {
-                $synchronizers->execute($mediaContentIdentities);
+                $synchronizer->execute($mediaContentIdentities);
             } catch (\Exception $exception) {
                 $this->log->critical($exception);
                 $failed[] = $name;
@@ -93,17 +67,5 @@ public function execute(array $mediaContentIdentities): void
                 )
             );
         }
-
-        $this->setLastExecutionTime();
-        $this->removeObsoleteContent->execute();
-    }
-
-    /**
-     * Set last synchronizer execution time
-     */
-    private function setLastExecutionTime(): void
-    {
-        $currentTime = $this->dateFactory->create()->gmtDate();
-        $this->flagManager->saveFlag(self::LAST_EXECUTION_TIME_CODE, $currentTime);
     }
 }

…Api/Model/SynchronizerIdentitiesPool.php …nApi/Model/SynchronizeIdentitiesPool.phpapp/code/Magento/MediaContentSynchronizationApi/Model/SynchronizerIdentitiesPool.php renamed to app/code/Magento/MediaContentSynchronizationApi/Model/SynchronizeIdentitiesPool.php app/code/Magento/MediaContentSynchronizationApi/Model/SynchronizerIdentitiesPool.php renamed to app/code/Magento/MediaContentSynchronizationApi/Model/SynchronizeIdentitiesPool.php

@@ -9,7 +9,7 @@
 
 use Magento\MediaContentSynchronizationApi\Api\SynchronizeIdentitiesInterface;
 
-class SynchronizerIdentitiesPool
+class SynchronizeIdentitiesPool
 {
     /**
      * Content with assets synchronizers

app/code/Magento/MediaContentSynchronizationCatalog/etc/di.xml

@@ -38,7 +38,7 @@
             </argument>
         </arguments>
     </type>
-    <type name="Magento\MediaContentSynchronizationApi\Model\SynchronizerIdentitiesPool">
+    <type name="Magento\MediaContentSynchronizationApi\Model\SynchronizeIdentitiesPool">
         <arguments>
             <argument name="synchronizers" xsi:type="array">
                 <item name="media_content_catalog"

app/code/Magento/MediaContentSynchronizationCms/etc/di.xml

@@ -14,7 +14,7 @@
             </argument>
         </arguments>
     </type>
-    <type name="Magento\MediaContentSynchronizationApi\Model\SynchronizerIdentitiesPool">
+    <type name="Magento\MediaContentSynchronizationApi\Model\SynchronizeIdentitiesPool">
         <arguments>
             <argument name="synchronizers" xsi:type="array">
                 <item name="media_content_cms"