ACP2E-3930: [QUANS] - Does Magento_Fedex core module check for a valid-active token before sending a request to get a new one?

Author: soklymeach

app/code/Magento/Fedex/Model/Carrier.php

@@ -20,6 +20,7 @@
 use Magento\Shipping\Model\Carrier\AbstractCarrier;
 use Magento\Shipping\Model\Carrier\AbstractCarrierOnline;
 use Magento\Shipping\Model\Rate\Result;
+use Magento\Framework\App\CacheInterface;
 
 /**
  * Fedex shipping implementation
@@ -174,6 +175,11 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C
      */
     private $decoderInterface;
 
+    /**
+     * @var CacheInterface
+     */
+    private $cache;
+
     /**
      * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
      * @param \Magento\Quote\Model\Quote\Address\RateResult\ErrorFactory $rateErrorFactory
@@ -194,6 +200,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C
      * @param \Magento\Catalog\Model\ResourceModel\Product\CollectionFactory $productCollectionFactory
      * @param \Magento\Framework\HTTP\Client\CurlFactory $curlFactory
      * @param \Magento\Framework\Url\DecoderInterface $decoderInterface
+     * @param CacheInterface $cache
      * @param array $data
      * @param Json|null $serializer
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
@@ -218,6 +225,7 @@ public function __construct(
         \Magento\Catalog\Model\ResourceModel\Product\CollectionFactory $productCollectionFactory,
         CurlFactory $curlFactory,
         DecoderInterface $decoderInterface,
+        CacheInterface $cache,
         array $data = [],
         ?Json $serializer = null
     ) {
@@ -244,6 +252,7 @@ public function __construct(
         $this->serializer = $serializer ?: ObjectManager::getInstance()->get(Json::class);
         $this->curlFactory = $curlFactory;
         $this->decoderInterface = $decoderInterface;
+        $this->cache = $cache;
     }
 
     /**
@@ -966,7 +975,19 @@ private function retrieveAccessToken(?string $apiKey, ?string $secretKey): strin
             $this->_debug(__('Authentication keys are missing.'));
             return null;
         }
-
+        $cacheKey = 'fedex_access_token_' . md5($apiKey . $secretKey);
+        $cacheType = 'fedex_api';
+        $cachedData = $this->cache->load($cacheKey);
+        if ($cachedData) {
+            $cachedData = json_decode($cachedData, true);
+            $currentTime = time();
+            if (isset($cachedData['access_token']) &&
+                isset($cachedData['expires_at'])
+                && $currentTime < $cachedData['expires_at']
+            ) {
+                return $cachedData['access_token'];
+            }
+        }
         $requestArray = [
             'grant_type' => self::AUTHENTICATION_GRANT_TYPE,
             'client_id' => $apiKey,
@@ -980,8 +1001,14 @@ private function retrieveAccessToken(?string $apiKey, ?string $secretKey): strin
         if (!empty($response['errors'])) {
             $debugData = ['request_type' => 'Access Token Request', 'result' => $response];
             $this->_debug($debugData);
-        } elseif (!empty($response['access_token'])) {
+        } elseif (!empty($response['access_token']) && isset($response['expires_in'])) {
             $accessToken = $response['access_token'];
+            $expiresAt = time() + (int)$response['expires_in'];
+            $cacheData = [
+                'access_token' => $accessToken,
+                'expires_at' => $expiresAt
+            ];
+            $this->cache->save(json_encode($cacheData), $cacheKey, [$cacheType], (int)$response['expires_in']);
         }
 
         return $accessToken;