Skip to content

Commit f4f88c2

Browse files
committed
Merge remote-tracking branch 'origin/AC-13338' into spartans_pr_19112025
2 parents d2aa207 + dccf608 commit f4f88c2

File tree

4 files changed

+1108
-7
lines changed

4 files changed

+1108
-7
lines changed

app/code/Magento/CatalogRule/Model/Rule/Condition/ConditionsToSearchCriteriaMapper.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ public function mapConditionsToSearchCriteria(CombinedCondition $conditions): Se
8282
*/
8383
private function mapConditionToFilterGroup(ConditionInterface $condition)
8484
{
85-
if ($condition->getType() === CombinedCondition::class) {
85+
if ($condition instanceof CombinedCondition) {
8686
return $this->mapCombinedConditionToFilterGroup($condition);
87-
} elseif ($condition->getType() === SimpleCondition::class) {
87+
} elseif ($condition instanceof SimpleCondition) {
8888
return $this->mapSimpleConditionToFilterGroup($condition);
8989
}
9090

app/code/Magento/CatalogRule/Model/Rule/Condition/MappableConditionsProcessor.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ private function rebuildCombinedCondition(CombinedCondition $originalConditions)
6767
$invalidConditions = [];
6868

6969
foreach ($originalConditions->getConditions() as $condition) {
70-
if ($condition->getType() === CombinedCondition::class) {
70+
if ($condition instanceof CombinedCondition) {
7171
$rebuildSubCondition = $this->rebuildCombinedCondition($condition);
7272

7373
if (count($rebuildSubCondition->getConditions()) > 0) {
@@ -79,7 +79,7 @@ private function rebuildCombinedCondition(CombinedCondition $originalConditions)
7979
continue;
8080
}
8181

82-
if ($condition->getType() === SimpleCondition::class) {
82+
if ($condition instanceof SimpleCondition) {
8383
if ($this->validateSimpleCondition($condition)) {
8484
$validConditions[] = $condition;
8585
} else {

0 commit comments

Comments
 (0)