MC-32201: Reorder functionality (test coverage)

Author: RuslanKostiv1

dev/tests/api-functional/testsuite/Magento/GraphQl/Sales/ReorderConfigurableWithVariationsTest.php

@@ -14,6 +14,7 @@
 use Magento\TestFramework\TestCase\GraphQlAbstract;
 
 /**
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  * Test Reorder with and without products overlay in shopping cart.
  */
 class ReorderConfigurableWithVariationsTest extends GraphQlAbstract

dev/tests/integration/testsuite/Magento/Sales/_files/order_with_1_qty_product_rollback.php

@@ -4,4 +4,4 @@
  * See COPYING.txt for license details.
  */
 
-require __DIR__ . '/../../../Magento/Sales/_files/order_with_two_simple_products_rollback.php';
+require __DIR__ . '/../../../Magento/Sales/_files/order_with_two_simple_products_qty_10_rollback.php';

dev/tests/integration/testsuite/Magento/Sales/_files/order_with_different_types_of_product_rollback.php

@@ -5,5 +5,8 @@
  */
 
 require __DIR__ . '/../../../Magento/Customer/_files/customer_rollback.php';
+require __DIR__ . '/../../../Magento/Catalog/_files/product_simple_without_custom_options_rollback.php';
+require __DIR__ . '/../../../Magento/ConfigurableProduct/_files/product_configurable_rollback.php';
+require __DIR__ . '/../../../Magento/GraphQl/Catalog/_files/virtual_product_rollback.php';
+require __DIR__ . '/../../../Magento/Bundle/_files/bundle_product_radio_required_option_rollback.php';
 require __DIR__ . '/../../../Magento/Downloadable/_files/product_downloadable_rollback.php';
-require 'default_rollback.php';

dev/tests/integration/testsuite/Magento/Sales/_files/order_with_simple_product_rollback.php

@@ -6,94 +6,6 @@
 
 use Magento\Sales\Api\OrderRepositoryInterface;
 
-require __DIR__ . '/../../../Magento/Customer/_files/customer.php';
-require __DIR__ . '/../../../Magento/Catalog/_files/product_simple.php';
-require __DIR__ . '/../../../Magento/Catalog/_files/product_simple_without_custom_options.php';
-
-/** \Magento\Customer\Model\Customer $customer */
-$addressData = include __DIR__ . '/../../../Magento/Sales/_files/address_data.php';
-$billingAddress = $objectManager->create(\Magento\Sales\Model\Order\Address::class, ['data' => $addressData]);
-$billingAddress->setAddressType('billing');
-$shippingAddress = clone $billingAddress;
-$shippingAddress->setId(null)->setAddressType('shipping');
-
-$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
-$payment = $objectManager->create(\Magento\Sales\Model\Order\Payment::class);
-$payment->setMethod('checkmo');
-$customerIdFromFixture = 1;
-
-$optionValuesByType = [
-    'field' => 'Test value',
-    'date_time' => [
-        'year' => '2015',
-        'month' => '9',
-        'day' => '9',
-        'hour' => '2',
-        'minute' => '2',
-        'day_part' => 'am',
-        'date_internal' => '',
-    ],
-    'drop_down' => '3-1-select',
-    'radio' => '4-1-radio',
-];
-
-$requestInfo = ['options' => [], 'qty' => 1];
-$productOptions = $product->getOptions();
-foreach ($productOptions as $option) {
-    $requestInfo['options'][$option->getOptionId()] = $optionValuesByType[$option->getType()];
-}
-
-/** @var \Magento\Sales\Model\Order\Item $orderItem */
-$orderItem = $objectManager->create(\Magento\Sales\Model\Order\Item::class);
-$orderItem->setProductId($product->getId());
-$orderItem->setQtyOrdered(1);
-$orderItem->setBasePrice($product->getPrice());
-$orderItem->setPrice($product->getPrice());
-$orderItem->setRowTotal($product->getPrice());
-$orderItem->setProductType($product->getTypeId());
-$orderItem->setProductOptions(['info_buyRequest' => $requestInfo]);
-$orderItem->setName($product->getName());
-$orderItem->setSku($product->getSku());
-$orderItem->setStoreId(0);
-// create second order item
-
-$orderItem2 = $objectManager->create(\Magento\Sales\Model\Order\Item::class);
-$requestInfo = [
-    'qty' => 1
-];
-$orderItem2->setProductId($secondProduct->getId())
-    ->setQtyOrdered(1)
-    ->setBasePrice($secondProduct->getPrice())
-    ->setPrice($secondProduct->getPrice())
-    ->setRowTotal($secondProduct->getPrice())
-    ->setProductType($secondProduct->getTypeId())
-    ->setName($secondProduct->getName())
-    ->setSku($secondProduct->getSku())
-    ->setStoreId(0)
-    ->setProductId($secondProduct->getId())
-    ->setSku($secondProductSku)
-    ->setProductOptions(['info_buyRequest' => $requestInfo]);
-
-/** @var \Magento\Sales\Model\Order $order */
-$order = $objectManager->create(\Magento\Sales\Model\Order::class);
-$order->setIncrementId('100001001');
-$order->setState(\Magento\Sales\Model\Order::STATE_NEW);
-$order->setStatus($order->getConfig()->getStateDefaultStatus(\Magento\Sales\Model\Order::STATE_NEW));
-$order->setCustomerIsGuest(false);
-$order->setCustomerId($customer->getId());
-$order->setCustomerEmail($customer->getEmail());
-$order->setCustomerFirstname($customer->getName());
-$order->setCustomerLastname($customer->getLastname());
-$order->setBillingAddress($billingAddress);
-$order->setShippingAddress($shippingAddress);
-$order->setAddresses([$billingAddress, $shippingAddress]);
-$order->setPayment($payment);
-$order->addItem($orderItem);
-$order->addItem($orderItem2);
-$order->setStoreId($objectManager->get(\Magento\Store\Model\StoreManagerInterface::class)->getStore()->getId());
-$order->setSubtotal(100);
-$order->setBaseSubtotal(100);
-$order->setBaseGrandTotal(100);
-
-$orderRepository = $objectManager->create(OrderRepositoryInterface::class);
-$orderRepository->save($order);
+require __DIR__ . '/../../../Magento/Customer/_files/customer_rollback.php';
+require __DIR__ . '/../../../Magento/Catalog/_files/product_simple_rollback.php';
+require __DIR__ . '/../../../Magento/Catalog/_files/product_simple_without_custom_options_rollback.php';

dev/tests/integration/testsuite/Magento/Sales/_files/order_with_two_configurable_variations.php

@@ -52,9 +52,8 @@
 $orderConfigurableItem->setParentItemId(null);
 $orderConfigurableItem->setProductType('configurable');
 $configurableVariations = [];
-foreach (array_values($configurableProduct->getExtensionAttributes()->getConfigurableProductLinks())
-         as $key => $variationId
-) {
+$producLinks = array_values($configurableProduct->getExtensionAttributes()->getConfigurableProductLinks());
+foreach ($producLinks as $key => $variationId) {
     $simpleProductId = current($configurableProduct->getExtensionAttributes()->getConfigurableProductLinks());
 
     /** @var \Magento\Catalog\Api\Data\ProductInterface $simpleProduct */

dev/tests/integration/testsuite/Magento/Sales/_files/order_with_two_configurable_variations_rollback.php

@@ -5,4 +5,5 @@
  */
 
 require __DIR__ . '/../../../Magento/Customer/_files/customer_rollback.php';
+require __DIR__ . '/../../../Magento/ConfigurableProduct/_files/product_configurable_rollback.php';
 require 'default_rollback.php';