ACP2E-3676: Exception while creating UPS shipping label

Author: abukatar

app/code/Magento/Shipping/Model/Shipping/LabelGenerator.php

@@ -1,16 +1,17 @@
 <?php
 /**
- *
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2014 Adobe
+ * All Rights Reserved.
  */
 namespace Magento\Shipping\Model\Shipping;
 
 use Magento\Framework\App\Filesystem\DirectoryList;
 use Magento\Framework\App\RequestInterface;
+use Magento\Sales\Model\Order\Shipment;
 
 /**
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * phpcs:disable Magento2.Functions.DiscouragedFunction
  */
 class LabelGenerator
 {
@@ -61,12 +62,14 @@ public function __construct(
     }
 
     /**
-     * @param \Magento\Sales\Model\Order\Shipment $shipment
+     * Creates a shipping label
+     *
+     * @param Shipment $shipment
      * @param RequestInterface $request
      * @return void
      * @throws \Magento\Framework\Exception\LocalizedException
      */
-    public function create(\Magento\Sales\Model\Order\Shipment $shipment, RequestInterface $request)
+    public function create(Shipment $shipment, RequestInterface $request)
     {
         $order = $shipment->getOrder();
         $carrier = $this->carrierFactory->create($order->getShippingMethod(true)->getCarrierCode());
@@ -76,7 +79,8 @@ public function create(\Magento\Sales\Model\Order\Shipment $shipment, RequestInt
         $shipment->setPackages($request->getParam('packages'));
         $response = $this->labelFactory->create()->requestToShipment($shipment);
         if ($response->hasErrors()) {
-            throw new \Magento\Framework\Exception\LocalizedException(__($response->getErrors()));
+            $firstError = $response->getErrors()[0];
+            throw new \Magento\Framework\Exception\LocalizedException(__($firstError));
         }
         if (!$response->hasInfo()) {
             throw new \Magento\Framework\Exception\LocalizedException(__('Response info is not exist.'));
@@ -104,15 +108,17 @@ public function create(\Magento\Sales\Model\Order\Shipment $shipment, RequestInt
     }
 
     /**
-     * @param \Magento\Sales\Model\Order\Shipment $shipment
+     * Adds tracking number to a shipment
+     *
+     * @param Shipment $shipment
      * @param array $trackingNumbers
      * @param string $carrierCode
      * @param string $carrierTitle
      *
      * @return void
      */
     private function addTrackingNumbersToShipment(
-        \Magento\Sales\Model\Order\Shipment $shipment,
+        Shipment $shipment,
         $trackingNumbers,
         $carrierCode,
         $carrierTitle
@@ -168,9 +174,11 @@ public function createPdfPageFromImageString($imageString)
         $directory = $this->filesystem->getDirectoryWrite(
             DirectoryList::TMP
         );
-        $directory->create();
-        $image = @imagecreatefromstring($imageString);
-        if (!$image) {
+
+        try {
+            $directory->create();
+            $image = imagecreatefromstring($imageString);
+        } catch (\Exception $e) {
             return false;
         }
 

app/code/Magento/Shipping/Test/Unit/Model/Shipping/LabelGeneratorTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2015 Adobe
+ * All Rights Reserved.
  */
 declare(strict_types=1);
 
@@ -284,4 +284,61 @@ public static function labelInfoDataProvider(): array
             [['tracking_number' => '111111', 'label_content' => 'some']]
         ];
     }
+
+    public function testCreateResponseHasErrors()
+    {
+        $order = $this->getMockBuilder(Order::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $order->expects(static::once())
+            ->method('getShippingMethod')
+            ->with(true)
+            ->willReturn($this->getShippingMethodMock());
+
+        /**
+         * @var $shipmentMock \Magento\Sales\Model\Order\Shipment|MockObject
+         */
+        $shipmentMock = $this->getMockBuilder(Shipment::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $shipmentMock->expects(static::once())->method('getOrder')->willReturn($order);
+
+        $carrierMock = $this->getMockBuilder(AbstractCarrier::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['isShippingLabelsAvailable', 'getCarrierCode'])
+            ->getMockForAbstractClass();
+        $carrierMock->expects(static::once())
+            ->method('isShippingLabelsAvailable')
+            ->willReturn(true);
+        $this->carrierFactory->expects(static::once())
+            ->method('create')
+            ->with(self::CARRIER_CODE)
+            ->willReturn($carrierMock);
+
+        $responseMock = $this->getMockBuilder(DataObject::class)
+            ->addMethods(['hasErrors', 'getErrors'])->disableOriginalConstructor()->getMock();
+        $responseMock->expects(static::once())
+            ->method('hasErrors')
+            ->willReturn(true);
+        $responseMock->expects(static::once())->method('getErrors')->willReturn(['Error message']);
+
+        $labelsMock = $this->getMockBuilder(Labels::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $labelsMock->expects(static::once())
+            ->method('requestToShipment')
+            ->with($shipmentMock)
+            ->willReturn($responseMock);
+
+        $this->labelsFactory->expects(static::once())
+            ->method('create')
+            ->willReturn($labelsMock);
+
+        $this->expectException(\Magento\Framework\Exception\LocalizedException::class);
+        /**
+         * @var $requestMock \Magento\Framework\App\RequestInterface|MockObject
+         */
+        $requestMock = $this->getMockForAbstractClass(RequestInterface::class);
+        $this->labelGenerator->create($shipmentMock, $requestMock);
+    }
 }