Skip to content

Commit fbed91c

Browse files
committed
AC-15047::[CE] PHPUnit 12: Upgrade Media & Asset Management related test cases | PHPUnit12 Compatibility
1 parent e5431b4 commit fbed91c

File tree

14 files changed

+38
-32
lines changed

14 files changed

+38
-32
lines changed

app/code/Magento/MediaGallery/Test/Unit/Model/Asset/Command/DeleteByDirectoryPathTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
use Magento\Framework\Exception\CouldNotDeleteException;
1313
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
1414
use Magento\MediaGallery\Model\Asset\Command\DeleteByDirectoryPath;
15+
use PHPUnit\Framework\Attributes\DataProvider;
1516
use PHPUnit\Framework\MockObject\MockObject;
1617
use PHPUnit\Framework\TestCase;
1718
use Psr\Log\LoggerInterface;
@@ -68,8 +69,8 @@ protected function setUp(): void
6869
*
6970
* @param string $directoryPath
7071
* @throws CouldNotDeleteException
71-
* @dataProvider directoryPathDataProvider
7272
*/
73+
#[DataProvider('directoryPathDataProvider')]
7374
public function testDeleteByDirectoryPath(string $directoryPath): void
7475
{
7576
if (!empty($directoryPath)) {

app/code/Magento/MediaGallery/Test/Unit/Model/Keyword/Command/GetAssetKeywordsTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
use Magento\MediaGallery\Model\Keyword\Command\GetAssetKeywords;
1515
use Magento\MediaGalleryApi\Api\Data\KeywordInterface;
1616
use Magento\MediaGalleryApi\Api\Data\KeywordInterfaceFactory;
17+
use PHPUnit\Framework\Attributes\DataProvider;
1718
use PHPUnit\Framework\MockObject\MockObject;
1819
use PHPUnit\Framework\TestCase;
1920
use Psr\Log\LoggerInterface;
@@ -56,10 +57,10 @@ protected function setUp(): void
5657
/**
5758
* Posive test for the main case
5859
*
59-
* @dataProvider casesProvider
6060
* @param array $databaseQueryResult
6161
* @param int $expectedNumberOfFoundKeywords
6262
*/
63+
#[DataProvider('casesProvider')]
6364
public function testFind(array $databaseQueryResult, int $expectedNumberOfFoundKeywords): void
6465
{
6566
$randomAssetId = 12345;

app/code/Magento/MediaGallery/Test/Unit/Model/Keyword/Command/SaveAssetKeywordsTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
use Magento\Framework\Exception\CouldNotSaveException;
1515
use Magento\MediaGallery\Model\Keyword\Command\SaveAssetKeywords;
1616
use Magento\MediaGallery\Model\ResourceModel\Keyword\SaveAssetLinks;
17+
use PHPUnit\Framework\Attributes\DataProvider;
1718
use PHPUnit\Framework\MockObject\MockObject;
1819
use PHPUnit\Framework\TestCase;
1920
use Psr\Log\LoggerInterface;
@@ -71,12 +72,11 @@ protected function setUp(): void
7172
/**
7273
* Test saving the asset keywords
7374
*
74-
* @dataProvider assetKeywordsDataProvider
75-
*
7675
* @param array $keywords
7776
* @param int $assetId
7877
* @param array $items
7978
*/
79+
#[DataProvider('assetKeywordsDataProvider')]
8080
public function testAssetKeywordsSave(array $keywords, int $assetId, array $items): void
8181
{
8282
$expectedCalls = (int) (count($keywords));

app/code/Magento/MediaGallery/Test/Unit/Model/ResourceModel/DeleteAssetsByPathsTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
use Magento\Framework\DB\Select;
1313
use Magento\Framework\Exception\CouldNotDeleteException;
1414
use Magento\MediaGallery\Model\ResourceModel\DeleteAssetsByPaths;
15+
use PHPUnit\Framework\Attributes\DataProvider;
1516
use PHPUnit\Framework\MockObject\MockObject;
1617
use PHPUnit\Framework\TestCase;
1718
use Psr\Log\LoggerInterface;
@@ -43,9 +44,9 @@ class DeleteAssetsByPathsTest extends TestCase
4344
/**
4445
* When deleting an asset by path with mixed case, the asset with exact same path should be deleted
4546
*
46-
* @dataProvider assetDeleteByPathDataProvider
4747
* @throws CouldNotDeleteException
4848
*/
49+
#[DataProvider('assetDeleteByPathDataProvider')]
4950
public function testDeleteCorrectAssetByPathWithCaseSensitiveMatches(
5051
array $assets,
5152
string $assetPathToDelete,

app/code/Magento/MediaGallery/Test/Unit/Model/ResourceModel/GetAssetsByPathsTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
use Magento\Framework\DB\Select;
1313
use Magento\MediaGallery\Model\ResourceModel\GetAssetsByPaths;
1414
use Magento\MediaGalleryApi\Api\Data\AssetInterfaceFactory;
15+
use PHPUnit\Framework\Attributes\DataProvider;
1516
use PHPUnit\Framework\MockObject\MockObject;
1617
use PHPUnit\Framework\TestCase;
1718
use Psr\Log\LoggerInterface;
@@ -72,9 +73,8 @@ protected function setUp(): void
7273

7374
/**
7475
* When getting an asset by path with mixed case, the asset with exact same path should be loaded
75-
*
76-
* @dataProvider assetDeleteByPathDataProvider
7776
*/
77+
#[DataProvider('assetDeleteByPathDataProvider')]
7878
public function testGetCorrectAssetByPathWithCaseSensitiveMatches(
7979
array $assets,
8080
int $assetIndex,

app/code/Magento/MediaGallery/Test/Unit/Model/ResourceModel/Keyword/SaveAssetLinksTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
use Magento\Framework\Exception\CouldNotSaveException;
1313
use Magento\MediaGallery\Model\ResourceModel\Keyword\SaveAssetLinks;
1414
use Magento\MediaGalleryApi\Api\GetAssetsKeywordsInterface;
15+
use PHPUnit\Framework\Attributes\DataProvider;
1516
use PHPUnit\Framework\MockObject\MockObject;
1617
use PHPUnit\Framework\TestCase;
1718
use Psr\Log\LoggerInterface;
@@ -63,13 +64,12 @@ protected function setUp(): void
6364
/**
6465
* Test saving the asset keyword links
6566
*
66-
* @dataProvider assetLinksDataProvider
67-
*
6867
* @param int $assetId
6968
* @param array $keywordIds
7069
* @param array $values
7170
* @throws CouldNotSaveException
7271
*/
72+
#[DataProvider('assetLinksDataProvider')]
7373
public function testAssetKeywordsSave(int $assetId, array $keywordIds, array $values): void
7474
{
7575
$expectedCalls = (int) (count($keywordIds));

app/code/Magento/MediaGallery/Test/Unit/Plugin/Wysiwyg/Images/StorageTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
1515
use Magento\MediaGallery\Plugin\Wysiwyg\Images\Storage as StoragePlugin;
1616
use Magento\MediaGalleryApi\Api\DeleteAssetsByPathsInterface;
17+
use PHPUnit\Framework\Attributes\DataProvider;
1718
use PHPUnit\Framework\MockObject\MockObject;
1819
use PHPUnit\Framework\TestCase;
1920
use Psr\Log\LoggerInterface;
@@ -83,9 +84,8 @@ protected function setUp(): void
8384

8485
/**
8586
* @param string $path
86-
*
87-
* @dataProvider pathPathDataProvider
8887
*/
88+
#[DataProvider('pathPathDataProvider')]
8989
public function testAfterDeleteDirectory($path): void
9090
{
9191
$directoryRead = $this->createMock(ReadInterface::class);

app/code/Magento/MediaGalleryUi/Test/Unit/Model/Model/Directories/GetDirectoryTreeTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
use Magento\Framework\Filesystem\Directory\ReadInterface;
1414
use Magento\MediaGalleryApi\Api\IsPathExcludedInterface;
1515
use Magento\MediaGalleryUi\Model\Directories\GetDirectoryTree;
16+
use PHPUnit\Framework\Attributes\DataProvider;
1617
use PHPUnit\Framework\MockObject\MockObject;
1718
use PHPUnit\Framework\TestCase;
1819

@@ -102,8 +103,8 @@ protected function setUp(): void
102103
* @param array $allowedFolders
103104
* @param array $expected
104105
* @throws ValidatorException
105-
* @dataProvider executeDataProvider
106106
*/
107+
#[DataProvider('executeDataProvider')]
107108
public function testExecute(array $allowedFolders, array $expected): void
108109
{
109110
$directory = $this->createMock(ReadInterface::class);

app/code/Magento/MediaGalleryUi/Test/Unit/Model/UploadImageTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
use Magento\Framework\Filesystem\Directory\Read;
1515
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
1616
use Magento\MediaGalleryUi\Model\UploadImage;
17+
use PHPUnit\Framework\Attributes\DataProvider;
1718
use PHPUnit\Framework\MockObject\MockObject;
1819
use PHPUnit\Framework\TestCase;
1920

@@ -66,9 +67,8 @@ protected function setUp(): void
6667
* @param string $targetFolder
6768
* @param string|null $type
6869
* @param string $absolutePath
69-
*
70-
* @dataProvider executeDataProvider
7170
*/
71+
#[DataProvider('executeDataProvider')]
7272
public function testExecute(string $targetFolder, ?string $type, string $absolutePath): void
7373
{
7474
$this->fileSystemMock->expects($this->once())

app/code/Magento/MediaStorage/Test/Unit/App/MediaTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
use Magento\MediaStorage\Model\File\Storage\Synchronization;
2828
use Magento\MediaStorage\Model\File\Storage\SynchronizationFactory;
2929
use Magento\MediaStorage\Service\ImageResize;
30+
use PHPUnit\Framework\Attributes\DataProvider;
3031
use PHPUnit\Framework\MockObject\MockObject;
3132
use PHPUnit\Framework\TestCase;
3233

@@ -196,9 +197,8 @@ public function testProcessRequestReturnsNotFoundIfFileIsNotSynchronized(): void
196197
/**
197198
* @param bool $isDeveloper
198199
* @param int $setBodyCalls
199-
*
200-
* @dataProvider catchExceptionDataProvider
201200
*/
201+
#[DataProvider('catchExceptionDataProvider')]
202202
public function testCatchException(bool $isDeveloper, int $setBodyCalls): void
203203
{
204204
/** @var Bootstrap|MockObject $bootstrap */

0 commit comments

Comments
 (0)