Skip to content

Call RemoveItem on cart instead of ItemRepository #40248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
indykoning wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open

Call RemoveItem on cart instead of ItemRepository #40248

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff60eb5
Call RemoveItem on cart instead of ItemRepository
indykoning Oct 27, 2025
a7e5913
Merge branch '2.4-develop' into patch-6
indykoning Oct 30, 2025
622bb39
Merge branch '2.4-develop' into patch-6
indykoning Nov 19, 2025
ccb4088
Merge branch '2.4-develop' into patch-6
engcom-Hotel Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/QuoteGraphQl/Model/CartItem/DataProvider/UpdateCartItems.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public function processCartItems(Quote $cart, array $items): void
$quantity = (float)$item['quantity'];

if ($quantity <= 0.0) {
$this->cartItemRepository->deleteById((int)$cart->getId(), $itemId);
$cart->removeItem($itemId);
Copy link
Contributor

@engcom-Hotel engcom-Hotel Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further analysis, your point is valid. The current GraphQL implementation using CartItemRepositoryInterface::deleteById() is inconsistent with the rest of Magento (REST API, Controllers) which all use Quote::removeItem().

But please add a comment explaining the fix.

Copy link
Author

@indykoning indykoning Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! I have found a couple more places that could possibly also use this change
https://github.com/search?q=repo%3Amagento%2Fmagento2%20cartItemRepository-%3EdeleteById&type=code

magento2/app/code/Magento/QuoteGraphQl/Model/Resolver/RemoveItemFromCart.php

Line 104 in 0a3b703

$this->cartItemRepository->deleteById($cartId, $itemId);

magento2/app/code/Magento/QuoteGraphQl/Model/Cart/MergeCarts/CartQuantityValidator.php

Line 220 in 0a3b703

$this->cartItemRepository->deleteById($cartId, $itemId);

What should our approach be on that? Updating those files in this PR as well, or creating separate issues and fixing them separately?

} else {
$this->updateCartItem->execute($cart, $itemId, $quantity, $customizableOptions);
}
Expand Down