Link to GitHub when Webhook creation fails with 409

If the Webhook creation fails due to a conflict (i.e. it already exists)
the error message now links to the Webhook's page on GitHub, allowing
the admin to easily review it.

Author: dregad

SourceGithub/SourceGithub.php

@@ -124,6 +124,8 @@ public function route_webhook( $p_request, $p_response, $p_args ) {
 
 		if( $t_id ) {
 			# Webhook already exists for this URL
+			# Set the Github URL so user can easily link to it
+			$t_hook->web_url = "https://github.com/$t_username/$t_reponame/settings/hooks/" . $t_hook->id;
 			return $p_response
 				->withStatus( HTTP_STATUS_CONFLICT,
 					plugin_lang_get( 'webhook_exists', 'SourceGithub' ) )

SourceGithub/files/sourcegithub.js

@@ -35,10 +35,19 @@ jQuery(document).ready(function($) {
 			},
 			error: function(xhr, textStatus, errorThrown) {
 				status_icon.removeClass("fa-check green").addClass("fa-exclamation-triangle red");
-				status_message.text(errorThrown);
+
+				var details = JSON.parse(xhr.responseText);
+				if (xhr.status === 409) {
+					status_message.html(
+						'<a href="' + details.web_url + '">' + errorThrown + '</a>'
+					);
+				} else {
+					status_message.text(errorThrown);
+				}
+
 				console.error(
 					'Webhook creation failed',
-					{ error: errorThrown, details: JSON.parse(xhr.responseText), request: this.url }
+					{ error: errorThrown, details: details, request: this.url, x: textStatus }
 				);
 			}
 		});