Only display the Diff/File buttons when needed

In some cases, it does not make any sense to display the Diff or File
buttons (e.g. when a file has been deleted), and the generated target
URL may be invalid (HTTP 404).

The Changeset View page has been adapted to not show the button when the
URL returned by the url_diff() and url_file() methods is empty. It now
behaves like the List page (see Source_View_Changesets()).

Fixes #401

Author: dregad

Source/pages/view.php

@@ -259,15 +259,13 @@ function( $p_bug_id ) use ( $t_view_bug_threshold ) {
 <td class="small" colspan="<?php echo $t_columns-2 ?>"><?php echo string_display_line( $t_vcs->show_file( $t_repo, $t_changeset, $t_file ) ) ?></td>
 <td class="center">
 <?php
-	print_extra_small_button(
-		$t_vcs->url_diff( $t_repo, $t_changeset, $t_file ),
-		plugin_lang_get( 'diff', 'Source' )
-	);
-	echo ' ';
-	print_extra_small_button(
-		$t_vcs->url_file( $t_repo, $t_changeset, $t_file ),
-		plugin_lang_get( 'file', 'Source' )
-	);
+	if( $t_url = $t_vcs->url_diff( $t_repo, $t_changeset, $t_file ) ) {
+		print_extra_small_button( $t_url, plugin_lang_get( 'diff', 'Source' ) );
+	}
+	if( $t_url = $t_vcs->url_file( $t_repo, $t_changeset, $t_file ) ) {
+		echo "\n";
+		print_extra_small_button( $t_url, plugin_lang_get( 'file', 'Source' ) );
+	}
 ?>
 </td>
 </tr>

SourceBitBucket/SourceBitBucket.php

@@ -61,16 +61,22 @@ public function url_changeset( $p_repo, $p_changeset ) {
 	}
 
 	public function url_file( $p_repo, $p_changeset, $p_file ) {
-		$t_username = $p_repo->info['bit_username'];
-		$t_reponame = $p_repo->info['bit_reponame'];
+		# Can't link to a deleted file
+		if( $p_file->action == SourceFile::DELETED ) {
+			return '';
+		}
+
 		$t_ref      = $p_changeset->revision;
 		$t_filename = $p_file->filename;
 		return $this->main_url . "$t_username/$t_reponame/src/$t_ref/$t_filename";
 	}
 
 	public function url_diff( $p_repo, $p_changeset, $p_file ) {
-		$t_username = $p_repo->info['bit_username'];
-		$t_reponame = $p_repo->info['bit_reponame'];
+		# No point viewing the diff to a deleted file
+		if( $p_file->action == SourceFile::DELETED ) {
+			return '';
+		}
+
 		$t_ref      = $p_changeset->revision;
 		$t_filename = $p_file->filename;
 		return $this->main_url . "$t_username/$t_reponame/diff/$t_filename?diff2=$t_ref";

SourceGithub/SourceGithub.php

@@ -240,6 +240,11 @@ public function url_changeset( $p_repo, $p_changeset ) {
 	}
 
 	public function url_file( $p_repo, $p_changeset, $p_file ) {
+		# Can't link to a deleted file
+		if( $p_file->action == SourceFile::DELETED ) {
+			return '';
+		}
+
 		$t_username = $p_repo->info['hub_username'];
 		$t_reponame = $p_repo->info['hub_reponame'];
 		$t_ref = $p_changeset->revision;