refactored collection components and added default collection ordering like seen on PR of @pascalwengerter

Author: jonasjabari

app/concepts/matestack/ui/core/collection/filter/filter.rb

@@ -7,11 +7,9 @@ def setup
     end
 
     def response
-      components {
-        div @tag_attributes do
-          yield_components
-        end
-      }
+      div @tag_attributes do
+        yield_components
+      end
     end
 
   end

app/concepts/matestack/ui/core/collection/order/order.js

@@ -16,7 +16,7 @@ const componentDef = {
         this.ordering[key] = "asc"
       } else if (this.ordering[key] == "asc") {
         this.ordering[key] = "desc"
-      } else if (this.ordering[key] = "desc") {
+      } else if (this.ordering[key] == "desc") {
         this.ordering[key] = undefined
       }
       var url;

app/concepts/matestack/ui/core/collection/order/order.rb

@@ -7,11 +7,9 @@ def setup
     end
 
     def response
-      components {
-        div @tag_attributes do
-          yield_components
-        end
-      }
+      div @tag_attributes do
+        yield_components
+      end
     end
 
   end

app/concepts/matestack/ui/core/collection/order/toggle/indicator/indicator.rb

@@ -2,11 +2,12 @@ module Matestack::Ui::Core::Collection::Order::Toggle::Indicator
   class Indicator < Matestack::Ui::Core::Component::Static
 
     def response
-      components {
-        span @tag_attributes do
-          plain "{{orderIndicator( '#{@component_config[:key]}', {asc: '#{@component_config[:asc]}', desc: '#{@component_config[:desc]}'} ) }}"
-        end
-      }
+      span @tag_attributes do
+        span attributes: {"v-if": "ordering['#{@component_config[:key]}'] === undefined"}, text: @component_config[:default]
+        plain "{{
+          orderIndicator('#{@component_config[:key]}', { asc: '#{@component_config[:asc]}', desc: '#{@component_config[:desc]}'})
+        }}"
+      end
     end
 
   end