implemented feedback, moved logic out of app.js, fixed potential flaky test

Author: jonasjabari

app/concepts/matestack/ui/core/app/app.js

@@ -1,6 +1,7 @@
 import Vue from 'vue/dist/vue.esm'
 import VRuntimeTemplate from "v-runtime-template"
 import Vuex from 'vuex'
+import isNavigatingToAnotherPage from "./location"
 
 const componentDef = {
   props: ['appConfig', 'params'],
@@ -16,11 +17,11 @@ const componentDef = {
   mounted: function(){
     const self = this;
     window.onpopstate = (event) => {
-      let needToNavigate = self.currentPathName !== document.location.pathname ||
-        self.currentOrigin !== document.location.origin ||
-        self.currentSearch !== document.location.search
-
-      if (needToNavigate){
+      if (isNavigatingToAnotherPage({
+          origin: self.currentOrigin,
+          pathName: self.currentPathName,
+          search: self.currentSearch
+        }, document.location)){
         self.$store.dispatch("navigateTo", {url: document.location.pathname, backwards: true} );
       }
     }

app/concepts/matestack/ui/core/app/location.js

@@ -0,0 +1,9 @@
+const isNavigatingToAnotherPage = function(currentLocation, targetLocation) {
+
+  // omits hash by design
+  return currentLocation.pathName !== targetLocation.pathname ||
+    currentLocation.origin !== targetLocation.origin ||
+    currentLocation.search !== targetLocation.search
+}
+
+export default isNavigatingToAnotherPage

spec/usage/components/transition_spec.rb

@@ -141,18 +141,13 @@ def page2
     expect(page).to have_content("This is Page 2")
     expect(page).to have_selector("body.not-reloaded")
 
-    # page.evaluate_script('window.history.back()')
     page.go_back
 
-    element = page.find("#my-div-on-page-1")
-    refreshed_content_on_page_1 = element.text
-
     expect(page).to have_content("My Example App Layout")
     expect(page).to have_content("This is Page 1")
     expect(page).not_to have_content("This is Page 2")
     expect(page).to have_selector("body.not-reloaded")
-
-    expect(first_content_on_page_1).not_to eq(refreshed_content_on_page_1)
+    expect(page).to have_no_content(first_content_on_page_1)
   end
 
   # supposed to work, but doesn't. Suspect Vue is the culprint here