remove news api gem and use faraday to resolve clash with news plugin

Author: merefield

lib/discourse_chatbot/functions/news_function.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require_relative '../function'
-require 'news-api'
 
 module DiscourseChatbot
   class NewsFunction < Function
@@ -40,14 +39,27 @@ def process(args)
         EOS
         super(args)
 
-        newsapi = News.new(SiteSetting.chatbot_news_api_token)
-        all_articles = newsapi.get_everything(q: args[parameters[0][:name]],
-                                              from: args[parameters[1][:name]], #'2023-08-01'
-                                              language: 'en',
-                                              sortBy: 'relevancy')
+        conn_params = {}
+
+        conn_params = args[parameters[1][:name]].blank? ?
+          { q: "#{args[parameters[0][:name]]}", language: 'en', sortBy: 'relevancy' } :
+          { q: "#{args[parameters[0][:name]]}", language: 'en', sortBy: 'relevancy', start_date: "#{args[parameters[1][:name]]}" }
+
+        conn = Faraday.new(
+          url: 'https://newsapi.org',
+          params: conn_params,
+          headers: { 'X-Api-Key' => "#{SiteSetting.chatbot_news_api_token}" }
+        )
+
+        response = conn.get('/v2/everything')
+
+        response_body = JSON.parse(response.body)
+
+        all_articles = response_body["articles"]
+
         news = "The latest news about this is: "
         all_articles.each do |a|
-          news += "#{a.title}.  "
+          news += "#{a["title"]}.  "
         end
         news
       rescue

plugin.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 # name: discourse-chatbot
 # about: a plugin that allows you to have a conversation with a configurable chatbot in Discourse Chat, Topics and Private Messages
-# version: 0.27
+# version: 0.28
 # authors: merefield
 # url: https://github.com/merefield/discourse-chatbot
 
@@ -12,8 +12,6 @@
 gem "google_search_results", '2.2.0'
 # wikipedia
 gem "wikipedia-client", '1.17.0'
-# news api
-gem 'news-api', '0.2.0'
 # safe ruby for calculations and date functions
 gem "childprocess", "4.1.0"
 gem "safe_ruby", "1.0.4"