Added docs for workaround/fix of issue #5

Ben Grynhaus · Ben Grynhaus · commit 0ef14d85d71f · 2018-08-13T21:16:14.000+03:00
diff --git a/libs/core/src/lib/components/wrapper-component.ts b/libs/core/src/lib/components/wrapper-component.ts
@@ -94,6 +94,9 @@ export abstract class ReactWrapperComponent<TProps extends {}> implements AfterV
       this._setHostDisplay();
     }
 
+    // NOTE: Workaround/fix for Issue #5 (https://github.com/Microsoft/angular-react/issues/5).
+    // The wrapper component isn't added to the root react nodes list when it's inside a `ReactContent` node, we manually add it (note that the root nodes list is a `Set`, so it won't duplicate nodes if already exist).
+    // There's potentially a better solution instead of this
     const rendererData = this.renderer.data;
     if (isReactRendererData(rendererData)) {
       afterRenderFinished(() => {

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,9 @@ export abstract class ReactWrapperComponent<TProps extends {}> implements AfterV`
`94`	`94`	`this._setHostDisplay();`
`95`	`95`	`}`
`96`	`96`
	`97`	`+ // NOTE: Workaround/fix for Issue #5 (https://github.com/Microsoft/angular-react/issues/5).`
	`98`	+ // The wrapper component isn't added to the root react nodes list when it's inside a `ReactContent` node, we manually add it (note that the root nodes list is a `Set`, so it won't duplicate nodes if already exist).
	`99`	`+ // There's potentially a better solution instead of this`
`97`	`100`	`const rendererData = this.renderer.data;`
`98`	`101`	`if (isReactRendererData(rendererData)) {`
`99`	`102`	`afterRenderFinished(() => {`